From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Gaurav Kohli <quic_gkohli@quicinc.com>,
amitk@kernel.org, daniel.lezcano@linaro.org, robh@kernel.org,
krzk+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, quic_manafm@quicinc.com
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: qcs615: Enable TSENS support for QCS615 SoC
Date: Wed, 11 Jun 2025 16:47:55 +0200 [thread overview]
Message-ID: <4a8df547-e625-4dbf-9c6e-44a3f793e602@oss.qualcomm.com> (raw)
In-Reply-To: <x2avlatyjo7sgcjubefexsfk6gerdbhx5dcug2kszk2hukcusm@srs5dwuc2m22>
On 6/11/25 4:19 PM, Dmitry Baryshkov wrote:
> On Wed, Jun 11, 2025 at 04:08:57PM +0200, Konrad Dybcio wrote:
>> On 6/11/25 8:37 AM, Gaurav Kohli wrote:
>>> Add TSENS and thermal devicetree node for QCS615 SoC.
>>>
>>> Signed-off-by: Gaurav Kohli <quic_gkohli@quicinc.com>
>>> ---
>>
>> [...]
>>
>>> + thermal-zones {
>>> + aoss-thermal {
>>> + thermal-sensors = <&tsens0 0>;
>>> +
>>> + trips {
>>> + trip-point0 {
>>> + temperature = <110000>;
>>> + hysteresis = <5000>;
>>> + type = "passive";
>>
>> All of the passive trip points you added that aren't bound to any
>> cooling devices should be critical instead (otherwise they're not
>> doing anything)
>>
>> otherwise, looks good
>
> Don't we need cooling-maps for CPU thermal zones?
no, we have lmh
Konrad
next prev parent reply other threads:[~2025-06-11 14:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-11 6:37 [PATCH v2 0/2] Enable TSENS and thermal zone " Gaurav Kohli
2025-06-11 6:37 ` [PATCH v2 1/2] dt-bindings: thermal: tsens: Add QCS615 compatible Gaurav Kohli
2025-06-11 6:37 ` [PATCH v2 2/2] arm64: dts: qcom: qcs615: Enable TSENS support for QCS615 SoC Gaurav Kohli
2025-06-11 14:08 ` Konrad Dybcio
2025-06-11 14:19 ` Dmitry Baryshkov
2025-06-11 14:47 ` Konrad Dybcio [this message]
2025-06-12 10:42 ` Gaurav Kohli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a8df547-e625-4dbf-9c6e-44a3f793e602@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=amitk@kernel.org \
--cc=andersson@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_gkohli@quicinc.com \
--cc=quic_manafm@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®