From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFC5A5FBA0 for ; Tue, 23 Apr 2024 10:01:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713866469; cv=none; b=BHPx8O2iB8dHUyGe62PLJCX3gJNo3uXC9VJ5CStzBcep/Xu+U6bXX/VBR1OSKT4w4qMQDIhWxs1fKI57YCPp8mM2Icqu/CP4c9BZmPBeCmZcG4Z72JfmoS+7X7hmAT6mCAliQD4bcgpy3zOgBRmsN5nK5z94/E/Fq2fpp0aA3os= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713866469; c=relaxed/simple; bh=YwIkjif5BreNxnLNOWf6abaVgTHOQBKAwUvTq0Bl3Ug=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=YeGhuwZfP5zmAoMHrvByQrKoWUoMjmiah0ekh5Wgmgsq4pONWVKQNNLiSoFSjz7mO31u38o2aYZ7yhVwembmnSkBrcby/LCuudnz7s+EHQ60M327PAQfT9QGygL6XaAvuOghtPuwDXn1H4n0DuBtoMBS6N7mLZFNQTiYeCLLLv4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Wy7aYCT+; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Wy7aYCT+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713866466; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=YwIkjif5BreNxnLNOWf6abaVgTHOQBKAwUvTq0Bl3Ug=; b=Wy7aYCT+8RFva8VV/bXu8uMFTXFyUbPay1LaVJ1ci09ULOAM1vBJvGMAPyBmehC628HSyH EHJN7PI9qtLptG5OSHbcWBOplR4ZPlwDaPayoMTNHi8fCdeQviunf13JZ+mpBYeLCPa81d NYVzUrw1A/XDI/wHUIy1SdUYcHkx43Y= Received: from mail-oi1-f197.google.com (mail-oi1-f197.google.com [209.85.167.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-590-0O6f0zfJMT2cJKe5d_PBqQ-1; Tue, 23 Apr 2024 06:01:05 -0400 X-MC-Unique: 0O6f0zfJMT2cJKe5d_PBqQ-1 Received: by mail-oi1-f197.google.com with SMTP id 5614622812f47-3c73b20ff31so1608470b6e.2 for ; Tue, 23 Apr 2024 03:01:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713866465; x=1714471265; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YwIkjif5BreNxnLNOWf6abaVgTHOQBKAwUvTq0Bl3Ug=; b=ndOKV/OtzlOPItdJNZE/hk73tI4VFB2wDlcyEKUaJcVVCj373V4wG002+3YDWHy/oG MRpPEber5fh8XbpvSUBhhCfRWuW6+2L8v1nn4rPOeLhvJhF4mwJy92lS5LzcSGoN3oa2 OrGMM/HG6uo2L7fk+9pRejclbi22Afdj3mweT5b+PiZeFqRkGkHKDMPWEH9KedWwNzo6 5S10j37ZffMoPxDyu9hk2GMENcywN9znZ2BIXqurze+rN0588opXr0NMtP/FjUCmoX6e pBw9YKdKjX+0iicY29zqaBHs+g1Fi+A0cH+Sj0VqsQ1lxW6gFSohPnB2jldgDxhciYYc T7OA== X-Forwarded-Encrypted: i=1; AJvYcCUsTeF7J+2p/mrolrTxGdd/80Xdt2Ra26VemvCo7kXwioYlOM1RAm8rJSEZYUj7UglHE6CNW/8zn5pciLiSTc4UTqUtDwUZuKZjY2AS X-Gm-Message-State: AOJu0YzfGXuZ3yuesHByAfM2nMlnDDfp2HbZS34leRxdz0VztyNuDI1h uN1g9UGWug6OZDyBg9l0+6SEmE3/17ZAMRhzkw5ZnVIf0r1FRV8+yNofcFJds478wRcsK8enRd5 TybAmTTMUe3Qh4hUU1Untih/Q+KjgHWls1ELY0m0uyygSxDX2r6zPCuzgVozAvw== X-Received: by 2002:a05:6870:8891:b0:22e:dfbc:4aae with SMTP id m17-20020a056870889100b0022edfbc4aaemr14682574oam.2.1713866464844; Tue, 23 Apr 2024 03:01:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE2cGPqTX80VpHqtIO0GuVwmn2dBJMhu25/rZtGRTV0uf+aWtNYNNJgU7vEjgHSo783VHDnMA== X-Received: by 2002:a05:6870:8891:b0:22e:dfbc:4aae with SMTP id m17-20020a056870889100b0022edfbc4aaemr14682536oam.2.1713866464448; Tue, 23 Apr 2024 03:01:04 -0700 (PDT) Received: from gerbillo.redhat.com ([2a0d:3344:172c:4510::f71]) by smtp.gmail.com with ESMTPSA id x4-20020ac87304000000b00434c31fa60csm5023855qto.92.2024.04.23.03.01.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 03:01:04 -0700 (PDT) Message-ID: <4a92f794480b12c21eaeeeb66521dbe978f08414.camel@redhat.com> Subject: Re: [PATCH net] net: ethernet: ti: am65-cpts: Fix PTPv1 message type on TX packets From: Paolo Abeni To: Ravi Gunasekaran , s-vadapalli@ti.com, rogerq@kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, richardcochran@gmail.com, jreeder@ti.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, srk@ti.com Date: Tue, 23 Apr 2024 12:01:01 +0200 In-Reply-To: <20240419080547.10682-1-r-gunasekaran@ti.com> References: <20240419080547.10682-1-r-gunasekaran@ti.com> Autocrypt: addr=pabeni@redhat.com; prefer-encrypt=mutual; keydata=mQINBGISiDUBEAC5uMdJicjm3ZlWQJG4u2EU1EhWUSx8IZLUTmEE8zmjPJFSYDcjtfGcbzLPb63BvX7FADmTOkO7gwtDgm501XnQaZgBUnCOUT8qv5MkKsFH20h1XJyqjPeGM55YFAXc+a4WD0YyO5M0+KhDeRLoildeRna1ey944VlZ6Inf67zMYw9vfE5XozBtytFIrRyGEWkQwkjaYhr1cGM8ia24QQVQid3P7SPkR78kJmrT32sGk+TdR4YnZzBvVaojX4AroZrrAQVdOLQWR+w4w1mONfJvahNdjq73tKv51nIpu4SAC1Zmnm3x4u9r22mbMDr0uWqDqwhsvkanYmn4umDKc1ZkBnDIbbumd40x9CKgG6ogVlLYeJa9WyfVMOHDF6f0wRjFjxVoPO6p/ZDkuEa67KCpJnXNYipLJ3MYhdKWBZw0xc3LKiKc+nMfQlo76T/qHMDfRMaMhk+L8gWc3ZlRQFG0/Pd1pdQEiRuvfM5DUXDo/YOZLV0NfRFU9SmtIPhbdm9cV8Hf8mUwubihiJB/9zPvVq8xfiVbdT0sPzBtxW0fXwrbFxYAOFvT0UC2MjlIsukjmXOUJtdZqBE3v3Jf7VnjNVj9P58+MOx9iYo8jl3fNd7biyQWdPDfYk9ncK8km4skfZQIoUVqrWqGDJjHO1W9CQLAxkfOeHrmG29PK9tHIwARAQABtB9QYW9sbyBBYmVuaSA8cGFiZW5pQHJlZGhhdC5jb20+iQJSBBMBCAA8FiEEg1AjqC77wbdLX2LbKSR5jcyPE6QFAmISiDUCGwMFCwkIBwIDIgIBBhUKCQgLAgQWAgMBAh4HAheAAAoJECkkeY3MjxOkJSYQAJcc6MTsuFxYdYZkeWjW//zbD3ApRHzpNlHLVSuJqHr9/aDS+tyszgS8jj9MiqALzgq4iZbg 7ZxN9ZsDL38qVIuFkSpgMZCiUHdxBC11J8nbBSLlpnc924UAyr5XrGA99 6Wl5I4Km3128GY6iAkH54pZpOmpoUyBjcxbJWHstzmvyiXrjA2sMzYjt3Xkqp0cJfIEekOi75wnNPofEEJg28XPcFrpkMUFFvB4Aqrdc2yyR8Y36rbw18sIX3dJdomIP3dL7LoJi9mfUKOnr86Z0xltgcLPGYoCiUZMlXyWgB2IPmmcMP2jLJrusICjZxLYJJLofEjznAJSUEwB/3rlvFrSYvkKkVmfnfro5XEr5nStVTECxfy7RTtltwih85LlZEHP8eJWMUDj3P4Q9CWNgz2pWr1t68QuPHWaA+PrXyasDlcRpRXHZCOcvsKhAaCOG8TzCrutOZ5NxdfXTe3f1jVIEab7lNgr+7HiNVS+UPRzmvBc73DAyToKQBn9kC4jh9HoWyYTepjdcxnio0crmara+/HEyRZDQeOzSexf85I4dwxcdPKXv0fmLtxrN57Ae82bHuRlfeTuDG3x3vl/Bjx4O7Lb+oN2BLTmgpYq7V1WJPUwikZg8M+nvDNcsOoWGbU417PbHHn3N7yS0lLGoCCWyrK1OY0QM4EVsL3TjOfUtCNQYW9sbyBBYmVuaSA8cGFvbG8uYWJlbmlAZ21haWwuY29tPokCUgQTAQgAPBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEoitAhsDBQsJCAcCAyICAQYVCgkICwIEFgIDAQIeBwIXgAAKCRApJHmNzI8TpBzHD/45pUctaCnhee1vkQnmStAYvHmwrWwIEH1lzDMDCpJQHTUQOOJWDAZOFnE/67bxSS81Wie0OKW2jvg1ylmpBA0gPpnzIExQmfP72cQ1TBoeVColVT6Io35BINn+ymM7c0Bn8RvngSEpr3jBtqvvWXjvtnJ5/HbOVQCg62NC6ewosoKJPWpGXMJ9SKsVIOUHsmoWK60spzeiJoSmAwm3zTJQnM5kRh2q iWjoCy8L35zPqR5TV+f5WR5hTVCqmLHSgm1jxwKhPg9L+GfuE4d0SWd84y GeOB3sSxlhWsuTj1K6K3MO9srD9hr0puqjO9sAizd0BJP8ucf/AACfrgmzIqZXCfVS7jJ/M+0ic+j1Si3yY8wYPEi3dvbVC0zsoGj9n1R7B7L9c3g1pZ4L9ui428vnPiMnDN3jh9OsdaXeWLvSvTylYvw9q0DEXVQTv4/OkcoMrfEkfbXbtZ3PRlAiddSZA5BDEkkm6P9KA2YAuooi1OD9d4MW8LFAeEicvHG+TPO6jtKTacdXDRe611EfRwTjBs19HmabSUfFcumL6BlVyceIoSqXFe5jOfGpbBevTZtg4kTSHqymGb6ra6sKs+/9aJiONs5NXY7iacZ55qG3Ib1cpQTps9bQILnqpwL2VTaH9TPGWwMY3Nc2VEc08zsLrXnA/yZKqZ1YzSY9MGXWYLkCDQRiEog1ARAAyXMKL+x1lDvLZVQjSUIVlaWswc0nV5y2EzBdbdZZCP3ysGC+s+n7xtq0o1wOvSvaG9h5q7sYZs+AKbuUbeZPu0bPWKoO02i00yVoSgWnEqDbyNeiSW+vI+VdiXITV83lG6pS+pAoTZlRROkpb5xo0gQ5ZeYok8MrkEmJbsPjdoKUJDBFTwrRnaDOfb+Qx1D22PlAZpdKiNtwbNZWiwEQFm6mHkIVSTUe2zSemoqYX4QQRvbmuMyPIbwbdNWlItukjHsffuPivLF/XsI1gDV67S1cVnQbBgrpFDxN62USwewXkNl+ndwa+15wgJFyq4Sd+RSMTPDzDQPFovyDfA/jxN2SK1Lizam6o+LBmvhIxwZOfdYH8bdYCoSpqcKLJVG3qVcTwbhGJr3kpRcBRz39Ml6iZhJyI3pEoX3bJTlR5Pr1Kjpx13qGydSMos94CIYWAKhegI06aTdvvuiigBwjngo/Rk5S+iEGR5KmTqGyp27o6YxZy6D4NIc6PKUzhIUxfvuHNvfu sD2W1U7eyLdm/jCgticGDsRtweytsgCSYfbz0gdgUuL3EBYN3JLbAU+UZpy v/fyD4cHDWaizNy/KmOI6FFjvVh4LRCpGTGDVPHsQXaqvzUybaMb7HSfmBBzZqqfVbq9n5FqPjAgD2lJ0rkzb9XnVXHgr6bmMRlaTlBMAEQEAAYkCNgQYAQgAIBYhBINQI6gu+8G3S19i2ykkeY3MjxOkBQJiEog1AhsMAAoJECkkeY3MjxOkY1YQAKdGjHyIdOWSjM8DPLdGJaPgJdugHZowaoyCxffilMGXqc8axBtmYjUIoXurpl+f+a7S0tQhXjGUt09zKlNXxGcebL5TEPFqgJTHN/77ayLslMTtZVYHE2FiIxkvW48yDjZUlefmphGpfpoXe4nRBNto1mMB9Pb9vR47EjNBZCtWWbwJTIEUwHP2Z5fV9nMx9Zw2BhwrfnODnzI8xRWVqk7/5R+FJvl7s3nY4F+svKGD9QHYmxfd8Gx42PZc/qkeCjUORaOf1fsYyChTtJI4iNm6iWbD9HK5LTMzwl0n0lL7CEsBsCJ97i2swm1DQiY1ZJ95G2Nz5PjNRSiymIw9/neTvUT8VJJhzRl3Nb/EmO/qeahfiG7zTpqSn2dEl+AwbcwQrbAhTPzuHIcoLZYV0xDWzAibUnn7pSrQKja+b8kHD9WF+m7dPlRVY7soqEYXylyCOXr5516upH8vVBmqweCIxXSWqPAhQq8d3hB/Ww2A0H0PBTN1REVw8pRLNApEA7C2nX6RW0XmA53PIQvAP0EAakWsqHoKZ5WdpeOcH9iVlUQhRgemQSkhfNaP9LqR1XKujlTuUTpoyT3xwAzkmSxN1nABoutHEO/N87fpIbpbZaIdinF7b9srwUvDOKsywfs5HMiUZhLKoZzCcU/AEFjQsPTATACGsWf3JYPnWxL9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2024-04-19 at 13:35 +0530, Ravi Gunasekaran wrote: > From: Jason Reeder >=20 > The CPTS, by design, captures the messageType (Sync, Delay_Req, etc.) > field from the second nibble of the PTP header which is defined in the > PTPv2 (1588-2008) specification. In the PTPv1 (1588-2002) specification > the first two bytes of the PTP header are defined as the versionType > which is always 0x0001. This means that any PTPv1 packets that are > tagged for TX timestamping by the CPTS will have their messageType set > to 0x0 which corresponds to a Sync message type. This causes issues > when a PTPv1 stack is expecting a Delay_Req (messageType: 0x1) > timestamp that never appears. >=20 > Fix this by checking if the ptp_class of the timestamped TX packet is > PTP_CLASS_V1 and then matching the PTP sequence ID to the stored > sequence ID in the skb->cb data structure. If the sequence IDs match > and the packet is of type PTPv1 then there is a chance that the > messageType has been incorrectly stored by the CPTS so overwrite the > messageType stored by the CPTS with the messageType from the skb->cb > data structure. This allows the PTPv1 stack to receive TX timestamps > for Delay_Req packets which are necessary to lock onto a PTP Leader. >=20 > Signed-off-by: Jason Reeder > Signed-off-by: Ravi Gunasekaran Please provide a suitable fixes tag, thanks! Paolo