From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F09CB3590DF for ; Wed, 19 Nov 2025 12:30:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763555433; cv=none; b=ARH+SRTZ25YUUJhJ0QwPke9N6fnStHM89HV+OPh7Caet4VynRhe4bTeY8Ln76VjE3k24s2SVnA2qAWbG6gve7BG9ijjek5BUI4cmi0SC5hw8bJIA8gahYMP0rU47YAYpHuoTVWnz3y+u289PeIM8yBkSoJhWdggXLAG1D9sn7hQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763555433; c=relaxed/simple; bh=kXPjrkL1yFxBo0v4ux0Of/j01hMOeLRVISHZiR1+1yU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jrEKAr52BIXkICdHWIRJIUwb4JcCjn9LXqNG/iehRjPHxqDWUwGpbbdiwCvK7B7zQxrDbB0jaF094s6UiDmuk2kPMJZThrSHncB3jgNq8UAebxjO9WXmhLL3u0VyG/D6Cq7vttdxEu90+zA4Q9yCoEigGX1SiL1Ivgkq6UTajRM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bnfSHyM7; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bnfSHyM7" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-47796a837c7so28158925e9.0 for ; Wed, 19 Nov 2025 04:30:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763555428; x=1764160228; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ANuLCsNtCUF8tPoNyJV9ss6Pl4S7P3c/OwbemWzc+jQ=; b=bnfSHyM77VNkMvXIqgyNMIdSQHUWytulsBEYKYMSkui+KSV9JdE/I6xCNDRLVocKAq nfOqx2J6gtidiDJKKtkp8iGNvBzQYdw7K3RXqgBrxXwM1kRu4tPUK1QC4FEO5KXOkDii e9/vI9dul7hoizGWEFNQ3zYEyXJscJlWcueXwHelunGg5KAm7XnjLpYJJY/0/nwQxuUH cRCG6T9JvcjhHNJwk9bvX8yp6B8fu+/DpkEkmVSVI9aNZbFZRvoLFyPrIaYc+VhSb/Wb XX1crldlApuD4hUyn6gljbWsWom9wGWtMHoDwT4igBL1XjRt0FYwCrEys2ewHxUAR1Tg xdVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763555428; x=1764160228; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ANuLCsNtCUF8tPoNyJV9ss6Pl4S7P3c/OwbemWzc+jQ=; b=uKqqMvKXuF8xURXzX+12n3uHyAqh/LWUPFgWLzYJNM0MwNLOSnyq/QT8JkyGyDhU94 XLx/W+vHFnKm1a3FWPHwrQy4hj/0NIqaf1b3XItWctAORFrsIkQU77xtUgXQbBeXMcCE VypsrB6MgnH5ex6at3OtDiKONAnxTfk5aYfz4fUkkZ2FUbTRxfLvoukpZ8ZAT6Lb8O6u vFeIxCmZ/pJF+2Z1x01odvP+SO6OUkEgVkX4ZdK/HC0IGYxj8li6S1n4XKu7LtQnpzGW 4IUtDmAkaolT3Hke/4dBnvW/ALj6OncGi0w+n7UPou7Y5+UfApG3ARIra+59N0oXvm8U rJfg== X-Forwarded-Encrypted: i=1; AJvYcCWAMx52gposVU5FOaHDJrdzY/nbp99jW3XtIsh6ObfXBIf9IUYkYkV0gzw6rm3J3skQORqPtKBNhQkVgZQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyVmwx1KyLqaJLS/ka7YUDULkfm5nSMr2Yi9WfMM5CwvPzbhZzP FHhB6/BPzoc/zdUbS0yV+UOWdv3w2HB+4sCMfLgrbUUeqpAIkyPG5HQAy+xUVeaLlAQ= X-Gm-Gg: ASbGncs/v4Z3NTRue2vgv9s9S9mUmZnuZRaXeNIqzRQT4bVfiK8opB+h/K0hUcw/xe9 s5LLd10y20YiBg8PQ7Y3JgIcPHSw6fDqHCllrfmdkYD0NQCtd7nYORGTpxZV3oMgriPsPfJqSEy DLeu3km7kgXGbD/LJ15tXRr9TFWI8GnEwvN8ZMlVKFcx7Y1lcNlJPEr4Rb38isprKCo29xPnUaS UFo/WIVh19NeFf9qmEiwW5yfqbuqQUeCJteh2FLWW+P7tP2Vs72NW04fvDXpxM8rHNPXXAtJYA9 RLdGgxbWaU/LW1NIbwJ8oct9PXxCjpxXjVmeFf/WX1rvd5j59jYdXMU+ZDJQBPRMp1EfzA5nWxo Bz3pgijmKc3NAyirn0YF/UGSWiIa3KbeC7VDQ1Qa0waznoqvjN1NVEaTm/WZnpL+c8pne8IRBf/ PfCSDO3mVLQN1VZBVagmXvRhD2zpQ= X-Google-Smtp-Source: AGHT+IHqhbbvVZExNtwvyM5VtD1QzsNi1upkWPblMC3uEuvom1Rb/Pq0EdVbzlawrXFh3afQBP4jgw== X-Received: by 2002:a05:600c:19cc:b0:471:1774:3003 with SMTP id 5b1f17b1804b1-477b19e248cmr19240965e9.29.1763555427738; Wed, 19 Nov 2025 04:30:27 -0800 (PST) Received: from [10.11.12.107] ([5.12.85.52]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477afb54774sm23714085e9.3.2025.11.19.04.30.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Nov 2025 04:30:27 -0800 (PST) Message-ID: <4a94884d-ffc1-45b7-b014-65f9724a820a@linaro.org> Date: Wed, 19 Nov 2025 14:30:24 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/7] soc: samsung: exynos-chipid: use devm action to unregister soc device To: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Peter Griffin , =?UTF-8?Q?Andr=C3=A9_Draszik?= , Srinivas Kandagatla Cc: semen.protsenko@linaro.org, willmcvicker@google.com, kernel-team@android.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251118-gs101-chipid-v2-0-e9f1e7460e35@linaro.org> <20251118-gs101-chipid-v2-3-e9f1e7460e35@linaro.org> Content-Language: en-US From: Tudor Ambarus In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/19/25 2:13 PM, Krzysztof Kozlowski wrote: > On 18/11/2025 14:56, Tudor Ambarus wrote: >> Simplify the unwinding of the soc device by using a devm action. >> Add the action before the exynos_asv_init() to avoid an explicit call >> to soc_device_unregister(). >> >> Signed-off-by: Tudor Ambarus >> --- >> drivers/soc/samsung/exynos-chipid.c | 27 +++++++++++---------------- > > Can I take the cleanups before new GS support? Fine by me. I'll send v3 then, to have the cleanups first.> > That's btw preferred order for all work. Fixes should be independent or > first in the patchset. Then cleanups before features/new support. I agree for the fixes. In the past I used to do the cleanups before new support, and I got feedback that the cleanups might delay the integration of the new support. I'm okay with both approaches, v3 will come. Thanks, ta