From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754904AbcH0IhX (ORCPT ); Sat, 27 Aug 2016 04:37:23 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:61206 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754648AbcH0IhU (ORCPT ); Sat, 27 Aug 2016 04:37:20 -0400 Subject: Re: [PATCH 2/2] f2fs: fix to update node page under cp_rwsem To: Jaegeuk Kim , Chao Yu References: <1472228072-4555-1-git-send-email-chao@kernel.org> <1472228072-4555-2-git-send-email-chao@kernel.org> <20160826170455.GB88444@jaegeuk> CC: , From: Chao Yu Message-ID: <4a9f9515-c1e2-aab0-d573-c3a4eda6aed7@huawei.com> Date: Sat, 27 Aug 2016 16:30:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: <20160826170455.GB88444@jaegeuk> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020201.57C14FAD.0037,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: ef11bdb7bb6dd5dff46d707d8f47b619 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/8/27 1:04, Jaegeuk Kim wrote: > On Sat, Aug 27, 2016 at 12:14:32AM +0800, Chao Yu wrote: >> From: Chao Yu >> >> Update node page under cp_rwsem in order to keep data consistency >> during writting checkpoint. >> >> Signed-off-by: Chao Yu >> --- >> fs/f2fs/inode.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c >> index 9ac5efc..1057c73 100644 >> --- a/fs/f2fs/inode.c >> +++ b/fs/f2fs/inode.c >> @@ -377,8 +377,11 @@ retry: >> goto retry; >> } >> >> - if (err) >> + if (err) { >> + f2fs_lock_op(sbi); >> update_inode_page(inode); >> + f2fs_unlock_op(sbi); >> + } > > Any corner case? No, just follow the old rule. > Now, it allows updating node page when checkpoint is doing. Oh, so for current rule, during checkpoint it: 1. allows updating meta info of inode which is not related to metadata of filesystem (e.g. i_size, i_block, i_nlink..) 2. does not allow updating meta info of inode which is related to metadata of filesystem (i_addr, i_nid..) Is my understanding right? Thanks, > > Thanks, > >> sb_end_intwrite(inode->i_sb); >> no_delete: >> stat_dec_inline_xattr(inode); >> -- >> 2.7.2 > > . >