From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: sashiko-reviews@lists.linux.dev
Cc: linux-rt-devel@lists.linux.dev, tj@kernel.org,
hannes@cmpxchg.org, mkoutny@suse.com,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v4 10/17] sched/deadline: Fix an overflow of the 0-lag time with long periods
Date: Thu, 19 Nov 2026 13:14:44 -0500 [thread overview]
Message-ID: <4aa1c606-e569-4f46-8a05-f5c7be3b4365@efficios.com> (raw)
In-Reply-To: <sashiko-outbox-223567@kernel.org>
> Can mul_u64_u64_div_u64() in the dl_se->runtime < 0 branch still overflow
> s64 or u64 when dl_runtime was shrunk or the overrun spans multiple
> seconds?
Yes, by reading. It needs a raised period limit and a stall of
several seconds.
The runtime goes below zero within a single update. update_curr_dl_se()
throttles the task at the first update past zero, or refills a boosted
task from its donor. So your rt_mutex case adds at most one more update.
The tick does not stop while a deadline task is queued. An overrun
therefore lasts at most about a tick. Only a stall, such as the vCPU
preemption you mention, makes it longer.
With a dl_runtime of 1024ns, the quotient exceeds 64 bits only after a
single overrun of:
- 4.4s, with sched_deadline_period_max_us at its maximum;
- 63s, with a 300s period limit;
- 4504s, with the default limit of about 4.19s.
Only then does x86-64 trap. One tick never does. The s64 wrap needs half
of each, and releases the bandwidth at once. v7.4-rc2 already wrapped
the product in all these cases, and with much shorter overruns.
> Even with the default 4s period limit, scaling a single-tick overrun of
> the old runtime by the new dl_period / dl_runtime ratio can arm
> inactive_timer for hours, locking up running_bw and total_bw.
Right about the hours: about 4.5 hours for a 4ms tick, with a 1024ns
runtime and a 4.19s period. This is the time the task needs to pay back
its overrun, at its new runtime per period. If the task stayed in the
class, replenish_dl_entity() would push its deadline as far. v7.4-rc2
arms the same timer. The timer holds only the task's own bandwidth, the
new dl_runtime / dl_period. Here, it rounds to 0.
The comment of this patch says that the overrun is short and its
quotient fits. This is too strong. The next version will cap the
quotient in this branch. Its comment will say that a stall can make
the overrun longer.
Thanks,
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com
next prev parent reply other threads:[~2026-11-19 18:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 16:24 [RESEND PATCH v4 00/17] sched/deadline: first bandwidth accounting fixes and selftests Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 01/17] sched: Refuse SCHED_FLAG_KEEP_PARAMS that would change the policy or the class Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 02/17] sched/deadline: Do not admit bandwidth for parameters that are kept Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 03/17] sched: Let a task boosted by a deadline waiter change its policy Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 04/17] sched/deadline: Do not divide by zero active CPUs of a root domain Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 05/17] sched/deadline: Refuse dl_server debugfs writes while the rq is offline Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 06/17] sched: Take cpuset_mutex for a deadline policy change only with pi Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 07/17] sched/deadline: Do not lose a throttled task switched out and back Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 08/17] sched/deadline: Do not replenish a boost from cleared parameters Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 09/17] sched/deadline: Reset the deadline and the runtime with the parameters Mathieu Desnoyers
2026-11-19 16:49 ` sashiko-bot
2026-11-19 16:24 ` [RESEND PATCH v4 10/17] sched/deadline: Fix an overflow of the 0-lag time with long periods Mathieu Desnoyers
2026-11-19 16:46 ` sashiko-bot
2026-11-19 18:14 ` Mathieu Desnoyers [this message]
2026-11-19 16:24 ` [RESEND PATCH v4 11/17] sched/deadline: Release the bandwidth of a task that leaves the class asleep Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 12/17] sched/deadline: Reject SCHED_DEADLINE on exited tasks Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 13/17] sched/deadline: Fix this_bw when a task is changed during a remote wakeup Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 14/17] sched/deadline: Check SCHED_DEADLINE affinity under the rq lock Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 15/17] sched/debug: Show the deadline bandwidth of each runqueue Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 16/17] selftests/sched: Add a test of SCHED_DEADLINE policy round trips Mathieu Desnoyers
2026-11-19 16:24 ` [RESEND PATCH v4 17/17] selftests/sched: Add a test of SCHED_DEADLINE bandwidth accounting Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4aa1c606-e569-4f46-8a05-f5c7be3b4365@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=mkoutny@suse.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®