From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031837AbdIZTIp (ORCPT ); Tue, 26 Sep 2017 15:08:45 -0400 Received: from mail-bl2nam02on0048.outbound.protection.outlook.com ([104.47.38.48]:46848 "EHLO NAM02-BL2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S968158AbdIZTIm (ORCPT ); Tue, 26 Sep 2017 15:08:42 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, linux-kernel@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Andy Lutomirski , Tom Lendacky , Andy Shevchenko , David Laight , Arnd Bergmann Subject: Re: [Part1 PATCH v4 13/17] x86/io: Unroll string I/O when SEV is active To: Borislav Petkov References: <20170916123418.37807-1-brijesh.singh@amd.com> <20170916123418.37807-14-brijesh.singh@amd.com> <20170917150846.GK4733@nazgul.tnic> From: Brijesh Singh Message-ID: <4aa2ff15-771c-388d-a443-486808d9ae3f@amd.com> Date: Tue, 26 Sep 2017 14:08:35 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170917150846.GK4733@nazgul.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: CY4PR2201CA0019.namprd22.prod.outlook.com (10.171.208.157) To CY1PR12MB0151.namprd12.prod.outlook.com (10.161.173.21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5f811693-b6a9-429b-1bc5-08d50511fefd X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:CY1PR12MB0151; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0151;3:s/VknxDiwKpuWXSj+LITdgINswtOwotiMpjfZE2ptuNu/6ZOwjsT+0YIp2riNoFyGpkNQgFnAwK4B7B8/A5sIRgPMJZdrKK+R6Y9qPSi1GuYa+a4Z+lZFRpQajQTc5zJ2b9nxkJzB+CEr7T7ZRMV66u3qhIWU5hH/7JIKo6AjeIxqcsBIElpjyx8CKIJ/nYtdW23hY6rxmD2yQn27FMVJadVUaUTixmQ17ZCMpK+QEZOPbzGi7yu+V8LAKWlIBt0;25:4Kj+6pu2VmQbA8PvPWXUjzoBtaNGIVqkEC52m36NgNjBbdhcwsYL01omgICdrkzWkWkcVe5c3tyPBU+rC0MJue3fjLJDDWXIr0t3JLiIOFrZGaTtCoer9rQfoBlx2PPGD2dtDFq6sNf1imQQi2hVNJNqvC8HIARdsXOA2EN1a/lc97WdEmfhyvDYSiv1re6frK2QZS8vnPBU7zkZIeIo5iELTftFU3kUs67iFAEMIqV/AsCUXs+XNcuNQGLdwWlg1vC7eKuNttZOvDZywh1hBybWjVN5bvLlbzI3CFMhfAbeZN3dZrXUCj0JplPMQWkGgNq2TktqxVvVUJgM26wjhw==;31:o2niEUaBH4uzLcLUoHNbzW6yrf0/lG3Mwl7z9tKHqXqa+stuTp35N6/AHnWnQ2NR1FwWVrzSiLeueFbeHwDxMSxFCxQjMwqJBOCutvYzCWVqvsOIpxLkjvcN7bjohaITASfQU8zMrCZzmaoaks2XY+wd0pVWa/fTtpUudC0YanwB++Wg9QSud3U2g7NwaND9GicTaJLChRAIP9C/ePEz4tyXcKWcDbHDK6+1gleoI4E= X-MS-TrafficTypeDiagnostic: CY1PR12MB0151: X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0151;20:0q4IpPiL9lOZaXvfOWueqMQBtVQFp/Pt+HzqYsuTtQztafUC37XimrDm1avZ9k6N8bifsDI67KPTN0n/oyatMzmlP416tIA4+VC9rxbsVLHHZ+f9voIgwxdQypwRTSIsB97lv95uo2dQgWGZPiYFH5GPwxMBng5NMJDvQjLUMHmsZdZPdU1uEQfkknvevMlBJTz+JF0okSj4axOrz/3lyScMozpZxVom5TEjpmVDcQgfaI/iEGi8eME/OsS8M7TUo/l97ZlzFoM93mRwpg35nBqgPvkjRKR3BY2jV5SL1sYStIRmjssymt4rc754/I0xkBYtN0p7fYmKiaV1tnrprM7AAqtWJRhIeRRfNssXB1A7F7wNNH/c5/QRhxi0gtNJxK0BUg/9FlWMhuSl8pU8z6XYIqVgwLeH+vrz4TQI35Qq+m33lwI6BrO6+hO91aMWoZ/azB3eiB7dRmAVoki3MmEFcRgOXfG0dLwh8iPwmVIYSiPBERbRT/rQhj4vhmyC;4:CgiMrHsVQIxvkQVpQGQ6KynxrtPAYuDrVZFwc9epEBHImbtoQRQqWp2vEhFbp8tuxwf1Zqtr6pslu+Mx2VTFdVWMYgFU2J2pl8AM84Nd/9VpXB3OvVtdyMDruyW73kBKpF6xm6z5BP+zFYxxAq9Lagf2o7+W7o7NB+Ygr6l6cE5rE/u+LpB697E0GEE/VrUX8uqDIZEiy9AgY8L+oo1301087xRBQzSNBlI6oN1td7ohSP6PbO7bxQdLqJcFOgvT X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123564025)(20161123560025)(20161123555025)(20161123558100)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR12MB0151;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR12MB0151; X-Forefront-PRVS: 0442E569BC X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(346002)(39860400002)(376002)(189002)(377454003)(199003)(24454002)(54356999)(8676002)(101416001)(68736007)(90366009)(86362001)(16526017)(2906002)(31696002)(16576012)(97736004)(305945005)(53546010)(229853002)(4326008)(478600001)(31686004)(54906003)(316002)(7736002)(83506001)(8936002)(33646002)(77096006)(6116002)(6486002)(7416002)(23676002)(65826007)(2950100002)(64126003)(189998001)(105586002)(5660300001)(81166006)(81156014)(3846002)(230700001)(58126008)(53936002)(106356001)(6916009)(36756003)(47776003)(6666003)(6246003)(25786009)(76176999)(65806001)(65956001)(66066001)(50466002)(50986999);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0151;H:[10.236.136.62];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyTUIwMTUxOzIzOndxekZLSEMxZjVMeUZiZXVVdldiWnZTaGlW?= =?utf-8?B?QjdoU2JMRzNWaThrUjFQaXlFS3FqOVV5ZkJpYVZZQ21oV0JSeWZNZlp0cS8y?= =?utf-8?B?dmRKVk9TQU1IdG1Ib3FqSWEzR3gyVU1ZTHA4b0E4a3NwZ2Y3TTFieTBDck1j?= =?utf-8?B?ckQxTlJvZ1lleDJMSWF2cG5uUUc3L0ovUU1Ya3NDRGRkUU91cjJVZG54ejFq?= =?utf-8?B?QnNFUllOSlpvWUN3QnpoaTRiajNHUGxYT2FSUUpaMk94UG90dzArdWxUbFdZ?= =?utf-8?B?S2IyNk5mZ3dPM1JlRFE5M29aQVRkUnJiWnNNclNkQmJ4QTNQbnhpbGpncXNy?= =?utf-8?B?NUQzSS9xbXY0djBkSyt4Q3ltMkdCMnR3MHdCdmkwOVIvUlM4bDRKZm5WVEdN?= =?utf-8?B?L3BYRUttaXg0WXBhbDYzem9FaTJRZW9zazA4TTNFZk9RRXN1R3MwYVN5aFB4?= =?utf-8?B?VVNqNERiRVVxakErRlBtOGNnZllncmUzRXF0RExwT2NUNzRFcS9Zbm0zT0lJ?= =?utf-8?B?cVM0MktRK0d4WkYvWUxyYlE3MUtMV2wwdURRaHVYSXNVT1dwNXhYTVdJSWZU?= =?utf-8?B?b29LcVBlRXJVSjZpWENkZUt6VzBWcUU0M3NEeHJFKzdqaTF5SjB1T0x2Y3ho?= =?utf-8?B?VVhYUDEzcGFJbkZ0QXFySkRMTlRCMlR0STBxNjMrSUIrVGFaR1JNN2gvWk9z?= =?utf-8?B?bXNGMzYvNDc2MXFuaGNvVmZaNnlIYnNmV004dDhLVEhjNWJEYVNSdHkySCt2?= =?utf-8?B?ZzZOamtrdFByRnlnQXAwRUptYms2YVVzMkw0U1pLOWp2Qi94UjNvRVhNNWdO?= =?utf-8?B?N25oRnI5eDRIYlI3OHlMekpXd3JmdGlid2M0aDduYlV1cFpMSFFWaVRHNGV4?= =?utf-8?B?MFlpMXhmbDhLTUZGU21lTW51TFVnNFo0eURUbHh3YUZPZmFQNzVnMjNDd3FH?= =?utf-8?B?QTY4dTQ2VUtTeWJSWElydGRjSEhRd3RtVUJyWkZzbjhlSXh5OEhIdzI2d3U5?= =?utf-8?B?Si9yU2NwZW9hOHU4cXBaa1lxWXJ6TVRXU2pnZWVVeEQ3RGhUSVZxRllzNHZt?= =?utf-8?B?V2JhUmZsMnVVWUJ6NVJBYzI2NUpTaUJQRWZuaVFGdm1uL0ZSMXhRaGx0djR3?= =?utf-8?B?VUdxZmNxb3RLdzdpSkxUeUVsMmxzQkJaUmFIaVNsWHRVcHJSYm9KZGV6ZHZW?= =?utf-8?B?QzBFL2Z5RmFEWjl4RVBWZlBRcURUZXBFWW9sWS9BNWV5ck1UREZEZ1E4S0Zt?= =?utf-8?B?eWVJV0ErV3d4MXp2S0oxbGtnbTBaWnhlTy9DVFVZdUlycGlBdzVhK215NXRK?= =?utf-8?B?dVJMZndOck04REtMZUEzcFltYktISjRCeEZhZUFnQmFjbXUzUUhmaDdISjdP?= =?utf-8?B?RjgyOFA0aEl5bEhvMDhjTWcvZG9jYXcvOTV2ZElWNHR6Q2N2QWlJLzdCWTR4?= =?utf-8?B?RWlIdmo1Y1dWYnNSWE5iTGN6WkFRemJ2SnlFNFpLbEQwTk1PU3ZmT1RQdVJK?= =?utf-8?B?U1pmYUNNeVV1Qmd2QWw5YktselEyRGtKVjhPSEdSNGxIY3JUYWR4WGt1UFBa?= =?utf-8?B?K3NSWVgxajB6djNlV3pHcXRKcUlBeVFMUUZIa1Y3TGZDVUtQbFZNSVNpSnA0?= =?utf-8?B?bWZCYlpkb25aNzRncHRwUlZqOGlISEp6MThUWWJLaHV2Tk5MeDE3b3l6QWpz?= =?utf-8?B?ZW92b2NmUXZNQ3MyK1pWNUVsS1dBTWR4Ykt0SDkwZ1czSHJjRVRJVGF6QWQ5?= =?utf-8?B?K25uQzA1eC9GZzBRZDNQN2d2TE9NMjFxQ0hCRmlGaW9QczZXSHVEOFJCd2ZL?= =?utf-8?B?WkpoeGgrc1Z1Rk1INVhOS1RwU1Zmck1ZMDV0bGJBaVlkYTFWVGRKeE85Mzgy?= =?utf-8?B?M2l3S2hxWWxpdDU0dENIQlYzbGJjMytDU3J2Ky9VZ1JEMVlJT3ZzOFZ3ZzJo?= =?utf-8?B?QWZqZlorYTV3PT0=?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0151;6:bMTMysSJHjQK/U+fry+yJRU6KdL94O4xBQYM9CwR38EOMxyTLEjYpij5Hu1blX5wojCGYFU7b50braN3o0qYqmHM3L4QFoImdi9JnNyUeFVCXCd2vBI0HyWOey+SiyQ8KHyQhiE7GL+QZApHr1RrVsP/I2JKb+uAmrKkZSgASON4WGMPVaRz4CMxtPhGcXlVbo2xkic+Y2d/U6o63/UZl2x2do6rCHcSmBCXNoVbT4LuWRCeUOgNgmeS+0nQmX5QtWQR2t0dwoQ3BmS2smsPHn5seT/49dcLhNMnwJG2pva9KSy/sjZuZHQp6UY5TwsOevhii6BhoYuQICSqbGuV5g==;5:LVKiIdLi7qu/X1fwwSDBDeWe1/dtgTFfOF6EZyAKaA70uvditqNvAJSW8KsUExAXx0Ay+4WXnmDxfXqiHoqxRqlj+BqFCu+vmdfKsze9V/qT5TLo7XfaLWQUHjU/fuzhSSAx9qjnPQWH7nJikEX4Yg==;24:UfkcHbvZ7eiotjGkCh4io7RfvPoKxEuybI+hux7x4VF255NCsxsaoT6BhQTaAFtUb5JX3xfgCEhh153JBn1OqJSq+hXDyqV+Vt3nNDkwIWo=;7:HT+A70qQPYh/wVt0KK+jU12dtKdWIliZngjpQs8yPyTj9pF7YCxz/qhuHISwUqLT8xGJDrBqT0wL1cY1KbJcqHM4vMHAQL8Jec3S7SuNfbh45Dwk1LyATEoJiS6mm0L9FD5vJyzebWK0JLp/aJwTW4sNFbgRnufE7J0NsEFWbC3C5EIAavswiFuo2W1ZXFlMGmVWZnaJq1EDdAV8q353FM1eoBDfbuYo5wsoe4WUOr8= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0151;20:vogO53OzMJH4pTf20B46DUyP0/HW1c6NQntas4c2Q0FPA4tT1gAT84KQfewRjxJ7ezqbCQSuopPt+dj+6M7+hrKwsbI25M6EmGgWr18t8dz8XV7AY8ZGK7VyCImL759q12DG3Vi2RkPf9mG1NHBwhkgXeY48Py3AVPF0fzq5iV7K27lCR1MoHkggeL5nY/T6/poEG9Dxpj/W4/sHx5jG1OIFcBbACE+pgdLz0acT2WN5sVaa2EWibfIpUtD/PgLY X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2017 19:08:38.6814 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0151 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/17/2017 10:08 AM, Borislav Petkov wrote: ... >> + >> +extern struct static_key_false __sev; >> +static inline bool __sev_active(void) >> +{ >> + return static_branch_unlikely(&__sev); >> +} > > I'm still not happy about the two's sev_active() and __sev_active() > naming. Perhaps the __ variant should be called sev_key_active() or ... > Will rename it to sev_key_active() in next rev. -Brijesh