From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80B1B3242A5 for ; Thu, 22 Jan 2026 15:11:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769094697; cv=none; b=Ob27yQepQ/Ba9inPlPbDWJV4/pmnJrzsbKUrU7C2TRrYCFRt1eL/luyucjVa5SGDNJXHhJ615hbXtkT8C9ss3i78dX2DNOWvLFeKN/EQ16n70jFP3/wIec2uDYRhWYge+2w0jd3y+czUsjXTLQs5cnlRbO0AdU069W12DDdSRHY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769094697; c=relaxed/simple; bh=H5ThibAWvoajrZPKGPBvO69JSuR2rsvAoFuAmH4XUco=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WN5+aCM+iwUIZG0yX1c4BPCbi7GLqFu+8Cn4cFltAnNQjS6NlhWmdlNY9QT84HbLnEeihqCs9oFz2qOUx1+3i2Ng3Ux1+WgX7y7YBSlRgdS86pOhz4LCPmTbuP++9ZFI7nxYd/9IfwWt8WO81Poh2Tep93zHmbEcbnXySpJTva8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ecrd/+Og; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=W034MH4a; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ecrd/+Og"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="W034MH4a" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60M7tNKH4057909 for ; Thu, 22 Jan 2026 15:11:34 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= E+apXPPkNURrNT1i45k0NbCCo3UvVpz3ZhqjBzyjoTY=; b=ecrd/+OgSZBX7q1n SdzeAj471Tuy2Hd+3FbAQCJnpCFUAMaoFtMohm5SVM5aslmM7jh5ljKmkr4chqw0 J7UNIoU2xwVV/rMBFW6tF7zexKMeoxhZ2rBzSHout+er3sQkTwiQ2fEPpc97soRA ugSZ3u0CWTGxWgpQo6k8TALn3H00nBbgfL6THP5wUa8AYF6OhFvi+4eCktJVvGVV oLM6c2cxQFqY6sekNv2JHayyNIKVDuv6rGQ+JcunpOWJkIVEOvECJAu2QKgjwBgl GS0O6EQ2YA9QAFve4BUNqO/YUn0xK33cPn+OV8Dt5l4+yJrhN/7CpxaMxmRcvi/Z yeZrsA== Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bu7nbtqh9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 22 Jan 2026 15:11:34 +0000 (GMT) Received: by mail-ua1-f72.google.com with SMTP id a1e0cc1a2514c-9481cb46f60so116679241.0 for ; Thu, 22 Jan 2026 07:11:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769094694; x=1769699494; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=E+apXPPkNURrNT1i45k0NbCCo3UvVpz3ZhqjBzyjoTY=; b=W034MH4ai0H9x5LkJyHV5v5kGmT7sWeNc3VrnGbYLhS0KOttlQ6giJqoOKf7Tu41sN lDHRb7U1QEAGIA2isLBHTQsplf+B+X94vXpwLlXZQO01Q/0hCqgfUHUtYxRs9zUBGy+n cwxRYLPlKfKlxttNoC9TsP0gfNZc+EZbmPBSMrviGWtWQkKAL8qZQ9kM0gYhETjhCy56 jhV0x6dfyfCuWe3g+TS9n2wLKZaOCiLotknES6IXBTYUh/9wlRydzQdTzAdL9iyKRE9S mQxfdd2Y9dIVdg3LkFvLC8Y2MmKqE3O8Z1sczJSpl83Qn9e0BJCIXDRx1jS2+Wnk19Lx nMZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769094694; x=1769699494; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=E+apXPPkNURrNT1i45k0NbCCo3UvVpz3ZhqjBzyjoTY=; b=DnobA5vvai7q4D3M20SwDuGjQS/SM99FfE6T2yYW+CvWmqQT58SpTo0vYl47X6+ZSN ebHo2s+iSKI1+kiGbEPvXCfCTxwbo+GaHz6/jgGC36NJIT0W1Bq7MRGyyu3Bpjj4HsJt tMDRNlsHh9/YUrK4czk6Lf+8CZP3jog7kqMJDDbvD5ST//JnTzcBjhEkWdu/j/S2pD8t DJjzJNQrV86LVR2yg9ev8n373kXwEDkqyZYmxm0fjtUNf6OA+/QrNS6RLSLPiaMt1hwO oFBO5TyR8J4GE9aMceSUZBHM5v58ngpFGWSV/A8UVsIUJLEhxyWlieR+NJ1UFBapiRE9 5h0A== X-Forwarded-Encrypted: i=1; AJvYcCWp+HOumYQHmkpkOEhRTXwJXW2DGU5CQcG3ig5J7rhBiEimNB/tiJqxaHz0XPzHEklxDQbgLfw+N45KkNQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyO0/umUngWkOpwnsZtWR0SNb9QDD2jMimRobBu1GjXYpM5eAx/ XjziwH76ffwoZv2FmMvCiuTqXC5Ahf1jZSAtApYbb69hGNNnX8sI7Pfwv4Hob64S3xJ6OUxgqB+ 5psIN9xzdX6x3GeSwOW4xs0tS8biVdzoug6dSfkxRkBKwAXt83eyeENeHj8ErznRMJoM= X-Gm-Gg: AZuq6aKKrnPyPxqEXWHdRsImxLW8tQnlCtcAGDd0tsZN6JBdanBArB4OQgXin40lGUq 8TmBxb3Z6bW8Ob583R1QziOxYTuY2DjWvm2y0VTU4wPSKCqKQ8vfCRFrOFzfYFqR4lGSmuApy7D SbxYVg8t/+CmQvT18TEnUCOP7GQ9oZpgVOdg8wMWbBGP82+sagLMlPuO8VCMNiqLHsccuiG5bxb TvuodDuFycoszV631z5dvI5WjjKDv9uCFapaXgSfKn3Xd5Frtjad0t+ZPbaky1l2GI+FjvVYD0r hXArb906/iJdD2JzuJ5JI4fP8xOpILccHYS1ECzVNJoRjw1XKBglxjlGUvW+4/NOg2kJtjO0bI1 zNdAAC4iWu2C8yRuptYQS2FGfdRM3g5+iiG/5yUlHJUdJbXWVVAAOy6TJO+waUMLN7/k= X-Received: by 2002:ac5:c5d1:0:b0:559:a30f:1d47 with SMTP id 71dfb90a1353d-563b5c689d2mr3193465e0c.3.1769094693732; Thu, 22 Jan 2026 07:11:33 -0800 (PST) X-Received: by 2002:ac5:c5d1:0:b0:559:a30f:1d47 with SMTP id 71dfb90a1353d-563b5c689d2mr3193454e0c.3.1769094693292; Thu, 22 Jan 2026 07:11:33 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-654535c49f4sm16293405a12.31.2026.01.22.07.11.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Jan 2026 07:11:32 -0800 (PST) Message-ID: <4aad22c3-a720-4d88-baa5-aead6854a771@oss.qualcomm.com> Date: Thu, 22 Jan 2026 16:11:31 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V1 3/3] ufs: ufs-qcom: Fix sequential read variance To: Nitin Rawat , mani@kernel.org, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org References: <20260122141331.239354-1-nitin.rawat@oss.qualcomm.com> <20260122141331.239354-4-nitin.rawat@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260122141331.239354-4-nitin.rawat@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 5ykTIEZVCqHMWXkcwfUZbbp5Np2Fo5Bw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTIyMDExNiBTYWx0ZWRfX5t8LiCtl9Au5 /jcqqEpGrujT142tHhk+udQfcanMpq42ewCppBg5EsMeTKJIfyuRJRrwjAqoqtSWMPTIVOGjFTF 7C2b65/ZzwmG2xlf+fYnDovuNBkvOnhO/Wq1XmnUjMOHIN2dhhDJ1KXZY8RivY3rpeEcMylrEXT as0m4aiiNXmaPUI5lZ9MP2HEJjG6n0QCLQgoDi/285jsug0A6KxHPQF/twq5ydbb6zLwrhayVOS g5PelLAYPf+Zy5CrejIGWKREDMtkK4KjAD4YAsaBKYXjzpAb1YaUdSQ8XpFkQ4fCXEoi5Fkff/P 2tPuXzGww/4TEub8JRsZxZwHffTsFgF5yzNhPx6aMyM64uWM6oYS+4nUpr3d4m1hkKChdL9/Lkj sOaao1TxkEz5uBmB+pVPV8MtFoFA6dP3LWWaYIiJILiM1b8V6PXcYSn0wfFS8gO2sHbvPbCd2gB ldOO2IG3gb2tFqBSePQ== X-Authority-Analysis: v=2.4 cv=dZGNHHXe c=1 sm=1 tr=0 ts=69723e26 cx=c_pps a=ULNsgckmlI/WJG3HAyAuOQ==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=qSU9NBqPYLnPsOZMscYA:9 a=QEXdDO2ut3YA:10 a=1WsBpfsz9X-RYQiigVTh:22 X-Proofpoint-ORIG-GUID: 5ykTIEZVCqHMWXkcwfUZbbp5Np2Fo5Bw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-22_02,2026-01-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 clxscore=1015 priorityscore=1501 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601220116 On 1/22/26 3:13 PM, Nitin Rawat wrote: > The current devfreq downdifferential threshold of 5% causes overly > aggressive frequency downscaling, leading to performance degradation > sometimes during sequential read workloads. > > Update the UFS devfreq downdifferential threshold to 65. > This widens the hysteresis window and prevents overly aggressive > downscaling, ensuring that frequency is maintained for loads above 5% > and scaling down occurs only when utilization falls below this level, > while scale-up still triggers above the 70% threshold. > > Signed-off-by: Nitin Rawat > --- > drivers/ufs/host/ufs-qcom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c > index ab5aed241913..5ef810b95b72 100644 > --- a/drivers/ufs/host/ufs-qcom.c > +++ b/drivers/ufs/host/ufs-qcom.c > @@ -1962,7 +1962,7 @@ static void ufs_qcom_config_scaling_param(struct ufs_hba *hba, > p->polling_ms = 60; > p->timer = DEVFREQ_TIMER_DELAYED; > d->upthreshold = 70; > - d->downdifferential = 5; > + d->downdifferential = 65; FWIW I see this is the value that's been shipping on android for quite a while Reviewed-by: Konrad Dybcio Konrad