From: Joe Perches <joe@perches.com>
To: Scott Branden <scott.branden@broadcom.com>,
Andy Whitcroft <apw@canonical.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH] checkpatch: always allow C99 SPDX License Identifer comments
Date: Wed, 11 Mar 2020 21:42:17 -0700 [thread overview]
Message-ID: <4aadd119d4336de9eafcfbadb951630eb0cf2eb9.camel@perches.com> (raw)
In-Reply-To: <7056bd62-4251-f9bb-2b97-15f93a1e7142@broadcom.com>
On Wed, 2020-03-11 at 19:48 -0700, Scott Branden wrote:
> Hi Joe,
>
> On 2020-03-11 7:26 p.m., Joe Perches wrote:
> > On Wed, 2020-03-11 at 12:11 -0700, Scott Branden wrote:
> > > Always allow C99 comment styles if SPDK-License-Identifier is in comment
> > > even if C99_COMMENT_TOLERANCE is specified in the --ignore options.
> > Why is this useful?
> This is useful because if you run checkpatch with
> --ignore=C99_COMMENT_TOLERANCE
> right now it will warn on almost every .c file in the linux kernel due
> to the decision to
> use // SPDX-License-Identifier: at the start of every c file
Maybe this is better:
Just don't perform any other per-line checks on a valid or invalid
SPDX line.
---
scripts/checkpatch.pl | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 529c892..3f2ae7 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -3171,6 +3171,7 @@ sub process {
WARN("SPDX_LICENSE_TAG",
"'$spdx_license' is not supported in LICENSES/...\n" . $herecurr);
}
+ next;
}
}
}
next prev parent reply other threads:[~2020-03-12 4:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 19:11 Scott Branden
2020-03-12 2:26 ` Joe Perches
2020-03-12 2:48 ` Scott Branden
2020-03-12 4:42 ` Joe Perches [this message]
2020-03-13 2:47 ` Scott Branden
2020-03-13 8:21 ` [PATCH] checkpatch: No additional checking of SPDX License Identifier necessary Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4aadd119d4336de9eafcfbadb951630eb0cf2eb9.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=scott.branden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®