From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3E8E480950 for ; Thu, 2 Jul 2026 12:07:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782994041; cv=none; b=kg+utR2WidWfJfuZVkEoAWWEAXBn/pAwL1U8KOyAEquVbEBlNBZ36jitiuk4+WvECvcDJH3RNWbOdF6gauAj/rto2b3XQfXKkHsxW48hNkBhJFVsQZ5OzZXC/lbGU+FQrdmDxLneP+Eje30t1Q2jpghhG/3Nj6LGFpZXwu0j6Ps= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782994041; c=relaxed/simple; bh=2C6XjzLVn/DUO72k9GZ0t941Cgc1T77zwAvITnwzrcM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RBeCtwZ8mlLvCYrSNtRPfKlySjYz3uksrTE+im0GX0sJi8qPtajineC2luer0ZqqydF1LwoPOrJiBE7N4SDML1oge33UhSSXBr/puK9y/TsqZStJs/DxodPbkMLqNLWD7AklfjjuyyRtKjmDF0VGv3odl+HTmGsuCpA39EP9aTk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=FbkrEazX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=e2MkOmRA; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="FbkrEazX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="e2MkOmRA" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 662BoC6s360227 for ; Thu, 2 Jul 2026 12:07:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UOJwoCkAIusdGzHbjudQLH0WhneMpUY4FHhSIYQ8xfc=; b=FbkrEazXrEhwMupj aecSN4M9Luu5jFSOr7JPSRxil85+HbZJHPqiTRLjkUVN3wXZsUphN3TTO3AVUKZg nrof+KMfOzAwu1kr0MJUoJpBPjsJj8V10BvShu8aKQcv8fpfuswb3WzTZ1FMu8HL Xi+tJ4xXEfYcLZX1uPmgN2jMw9naZRXo4YVdhtMowhAGgTg/0mvDRbyTBA8kukMK Us5XUqHqwElwQ8Ey1Oz5xgA2yTojqPFoqKCuip7Mec6SMKLB4wPIiDTFOZAdaLsv 9P99+mFAtwkEeyfinyPjQl2T/g0/M+L0V61d2Xo78nw/2cCSedCrFo1pkIWXnvGo utOMVg== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f5qfc0250-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 02 Jul 2026 12:07:18 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c21be5bb4so8689181cf.0 for ; Thu, 02 Jul 2026 05:07:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782994037; x=1783598837; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UOJwoCkAIusdGzHbjudQLH0WhneMpUY4FHhSIYQ8xfc=; b=e2MkOmRAeEaQ9E+2ibN7Hz71vzm9YQylSqU+e2EjbX77Rlz0fLxTOrF4CdRjBWbU7j T1JiqAkRHe6F6mb6/9Zx4UsbmU2vQdAmaEwM8B/Kgmu3RAOy4y1Rh8ZPgsXzLnM3sMba F0dbxwYYoheFLzEehxB/GsP+2kh5t9khUiPHpOfPh3iZCjESk5SeMvLsjZNzuGiRmYAP NqvdX6g5lhetV2oDrSmAUJotN/76uLAB4Y1hSo2LWLx/pQSvuvQjJvcyjQn9OxcTJHFZ cfEev2QcLiku2R4IEE6+NxSLGo0B+j2rZbo2zRuuJCzmLwSLShGVCqlxt9PnAJvFrbgn Jdfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782994037; x=1783598837; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=UOJwoCkAIusdGzHbjudQLH0WhneMpUY4FHhSIYQ8xfc=; b=DdWPX1rYdG00ARpODUjfPyNwpZS6M7WpFEo5yGNz6k7QS9iqMsHwtvakm7SXh58hF5 Olnj1ilblmnGB7VmQugl/94Tp/++skKo/49whh1VVaClLAc4gChrm6jQlQQVTlPA4YU/ kCxmkpAU8/cuQ2kjo6561VYzJ/NEwY35YE/USRirVk03E2XmqytwPAteccIN28OJVKgN LJSCI4/yg47T7llpqCTaMuUyJx7mi5yusK2/PTpDHZRZXwMaWj9j6yOsd9MJyKkD1sFb cEBChRlR5OFr9es/Ya8oi6NGJXVrYTQYLjSjwgtQ2+faV98RPfsLVEG7vvH2sMJyTO6j 2ebw== X-Forwarded-Encrypted: i=1; AFNElJ/VE23Tr0nWJ0iCqOC2uNx2brmQhI/8DNieSBnSXOftPXhEPVvqJBSoCshp96Af4DxCl/GB91mBu0/cBmU=@vger.kernel.org X-Gm-Message-State: AOJu0YzmEw12T5P4cect56CSHTsd3TpA8c5SGbXQsmkFjNwvEjH/xzvz 9BjSg+zwSPnk9VxwbU5G4Ll73XSxpUpyHiwdbScE8wAzhEOcBfNWrvZ6qmUoud/n3/Skp+6/+ti dqjMN/kdqnRodaMHqvMqBtowjoMr9nhXZBmpMzWwd/MOMEnO535rSghl/nG12BhiL4/M= X-Gm-Gg: AfdE7ckjqsSr9cNRZrn6YF0Z563mTzZSaaZfZ4d6DAdF617dMt2J6+H4TJ98RhmvRcm EFYmPr0hwXwBTMgn5BOj14+Cs4tuOzVAljyNqNtXz2sfBcNGcCcKdR0VZnorYuzpTC90YbspM96 qUa042yhwWrkG4lfMBN9JzaGD4GDZ/9eV89De58SEEnjHu0jX9DUr5A2lF6Rl/Sb+oOs7tTu8vI fWowjWone7U9LVXbNLAdJSc04Z48+OHZWuCa0lmQLczBI5+EPL1p7TWLmGrj7zCIokQnHJBjQYf tdILAuq3xT5xvEToqhGmv9LnVx2thUv1Q9T9hNBB79U4IhyFbo3he8RP/sEs7XM4yPy9xIdIFF7 /+ka+2jz7w0Jq/8SRfjzNQUWO5r5TDh4Qn+U= X-Received: by 2002:a05:622a:148e:b0:51a:8c9b:64a5 with SMTP id d75a77b69052e-51c26b25b69mr45759981cf.9.1782994036903; Thu, 02 Jul 2026 05:07:16 -0700 (PDT) X-Received: by 2002:a05:622a:148e:b0:51a:8c9b:64a5 with SMTP id d75a77b69052e-51c26b25b69mr45759471cf.9.1782994036193; Thu, 02 Jul 2026 05:07:16 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c12b6290794sm118186566b.38.2026.07.02.05.07.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 05:07:15 -0700 (PDT) Message-ID: <4ab24c54-5e37-48df-a410-8fae6d7b5289@oss.qualcomm.com> Date: Thu, 2 Jul 2026 14:07:12 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/3] arm64: dts: qcom: Fix pm4125 vbus regulator compatible and constraints To: Rakesh Kota Cc: Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, jishnu.prakash@oss.qualcomm.com, kamal.wadhwa@oss.qualcomm.com References: <20260701-add_pm4125-vbus-reg-v2-0-6bac2bac7131@oss.qualcomm.com> <20260701-add_pm4125-vbus-reg-v2-3-6bac2bac7131@oss.qualcomm.com> <83cdc9dd-65d2-48c0-b172-d66f513b9c74@oss.qualcomm.com> <20260702073321.xsyu33rxtrku2xdn@hu-kotarake-hyd.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260702073321.xsyu33rxtrku2xdn@hu-kotarake-hyd.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: _f-MVXBLIzLmDllUkka5Ki2Dzq7YbN-6 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAyMDEyNSBTYWx0ZWRfXw3OwPms6dlr0 7KWZ+ZW4KTgN30hMKtBE7o3AC708ZA9IWdsSGR2gmgtWQN2P5iQ0Oylv/+9xDAFXYfE5rSBd6HL dw2o9Mo92SklsENQz7TmfXBz0+d0IGVQSzV1LK5BdLyxFDVmTO5qJocE2OBHuTDRiT8r0T8F6PM zJ5Is285ggfkRspYmPHZ0Tos5CeQCjem01mFieYxWs/QiPO32V08FRwNSdRrYUgaj+5tonf4V42 4y+gCP4A5HAD0Mt7BTMg9q6Fy30UlEKAr/KGKulnK8e7An52/LZ1DPfucUFIzx2D88+0dIHHLrc D5r58D2OOsq8RG1iVigk2cMocTsuDMBpMVSEgv04sjLuoMIx1NzOw/hFpNdzyB5LGJejlbLiOTk qmFE549Lz/GtmPyHApFxt2IyOv7GXgOu4jhi69BV8TrjJnifYRUY1L+LUp3eKYJV4SotSOE0iFz aFX21ZbRBDWU17wGt+w== X-Authority-Analysis: v=2.4 cv=dvXrzVg4 c=1 sm=1 tr=0 ts=6a465476 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=3DGyyXRA4hY-B3Y99UoA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: _f-MVXBLIzLmDllUkka5Ki2Dzq7YbN-6 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAyMDEyNSBTYWx0ZWRfX4KFdGq8Fa7QI nfIGr3P6kjJn+h41FNqU0fEetlD/TrQwBdsze0QQ2ETBQ3ik11u6+EhQKy0jfcqR4AQ5tByPo8t 0YcqVbpSPVBJkyqrkmSN3kMvnM5vmTU= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-02_01,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 priorityscore=1501 adultscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607020125 On 7/2/26 9:33 AM, Rakesh Kota wrote: > On Wed, Jul 01, 2026 at 01:26:11PM +0200, Konrad Dybcio wrote: >> On 7/1/26 12:28 PM, Rakesh Kota wrote: >>> Remove pm8150b fallback compatible from pm4125_vbus and fix regulator >>> constraints in qrb2210 DTS files to use microvolt instead of >>> microamp. >>> >>> Signed-off-by: Rakesh Kota >>> --- >>> arch/arm64/boot/dts/qcom/pm4125.dtsi | 2 +- >>> arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts | 4 ++-- >>> arch/arm64/boot/dts/qcom/qrb2210-rb1.dts | 4 ++-- >>> 3 files changed, 5 insertions(+), 5 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/pm4125.dtsi b/arch/arm64/boot/dts/qcom/pm4125.dtsi >>> index 542e8fe030da40dfefc7b744dcc30133fdb35e74..3dc8d667d091ceb4267081d32b7aae983fc25071 100644 >>> --- a/arch/arm64/boot/dts/qcom/pm4125.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/pm4125.dtsi >>> @@ -37,7 +37,7 @@ pm4125_resin: resin { >>> }; >>> >>> pm4125_vbus: usb-vbus-regulator@1100 { >>> - compatible = "qcom,pm4125-vbus-reg", "qcom,pm8150b-vbus-reg"; >>> + compatible = "qcom,pm4125-vbus-reg"; >>> reg = <0x1100>; >>> status = "disabled"; >>> }; >>> diff --git a/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts b/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts >>> index bf088fa9807f040f0c8f405f9111b01790b09377..2b50f3f577577d30a87fcb6466c7d7690270aaa3 100644 >>> --- a/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts >>> +++ b/arch/arm64/boot/dts/qcom/qrb2210-arduino-imola.dts >>> @@ -235,8 +235,8 @@ &mdss_dsi0_phy { >>> }; >>> >>> &pm4125_vbus { >>> - regulator-min-microamp = <500000>; >>> - regulator-max-microamp = <500000>; >>> + regulator-min-microvolt = <4250000>; >>> + regulator-max-microvolt = <5000000>; >> >> Perhaps that's a stupid question, but is there any good reason to >> not just keep it at 5V if enabled? >> > We could hardcode 5V, but keeping the range allows clients to select a > lower voltage if needed. The driver supports voltage selection per use > case, so hardcoding 5V would restrict that flexibility. I'm trying to understand if this would ever happen in practice Konrad