mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	linux-kernel@vger.kernel.org
Cc: linux-amarula@amarulasolutions.com, michael@amarulasolutions.com,
	Brian Masney <bmasney+clk@redhat.com>,
	Conor Dooley <conor+dt@kernel.org>,
	Jerome Brunet <jbrunet+clk@baylibre.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Rob Herring <robh@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
	devicetree@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: clock: ti: dpll: drop the ti,ssc-* properties
Date: Tue, 27 Oct 2026 12:03:30 +0100	[thread overview]
Message-ID: <4aba41b5-0aa9-4a3e-8d8e-efc5ee45fc54@kernel.org> (raw)
In-Reply-To: <20261026074654.3997494-2-dario.binacchi@amarulasolutions.com>

On 26/10/2026 08:46, Dario Binacchi wrote:
> The common clock binding provides assigned-clock-sscs to configure
> spread spectrum clocking (SSC), supported by the clock core since commit
> a7f16660af39 ("clk: conf: Support assigned-clock-sscs"). Keeping the
> vendor specific ti,ssc-deltam, ti,ssc-modfreq-hz and ti,ssc-downspread
> properties would leave two ways to describe the same thing.
> 
> The properties have no in-tree users, so they can be dropped.
> 
> Existing DTS files using them continue to work, with SSC disabled,
> until they switch to assigned-clock-sscs.
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> 
> ---
> If keeping the properties as deprecated is preferred, I can add a
> fallback to the driver in v2.
> 
> (no changes since v1)
> 

I responded under v1, so same here:

I see the user:
	git grep ti,ssc-deltam

Maybe you ordered patches incorrectly. Anyway, properties with in-tree
users must be documented, so make them deprecated instead.

Best regards,
Krzysztof

  reply	other threads:[~2026-10-27 11:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26  7:46 [PATCH v2 0/3] clk: ti: dpll: switch spread spectrum to the generic framework Dario Binacchi
2026-10-26  7:46 ` [PATCH v2 1/3] dt-bindings: clock: ti: dpll: drop the ti,ssc-* properties Dario Binacchi
2026-10-27 11:03   ` Krzysztof Kozlowski [this message]
2026-10-26  7:46 ` [PATCH v2 2/3] clk: ti: dpll: use the generic spread spectrum configuration Dario Binacchi
2026-10-26  7:46 ` [PATCH v2 3/3] clk: ti: dpll: apply the spread spectrum configuration right away Dario Binacchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4aba41b5-0aa9-4a3e-8d8e-efc5ee45fc54@kernel.org \
    --to=krzk@kernel.org \
    --cc=bmasney+clk@redhat.com \
    --cc=conor+dt@kernel.org \
    --cc=dario.binacchi@amarulasolutions.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jbrunet+clk@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-amarula@amarulasolutions.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael@amarulasolutions.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®