From: Joe Perches <joe@perches.com>
To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"Andy Whitcroft" <apw@canonical.com>
Cc: Rob Herring <robh@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: checkpatch.pl: Bogus case of DT_SPLIT_BINDING_PATCH
Date: Thu, 31 Dec 2020 17:55:00 -0800 [thread overview]
Message-ID: <4abaac7b4b792dd44880d8acf6ef51d9db89e512.camel@perches.com> (raw)
In-Reply-To: <X+5LAFw7AHvAXJaK@latitude>
On Thu, 2020-12-31 at 23:04 +0100, Jonathan Neuschäfer wrote:
> Hi,
>
> I've encountered a case where the DT_SPLIT_BINDING_PATCH warning was
> emitted even though I didn't change anything outside of Documentation/
> devicetree/bindings. I just converted a binding from plain text to YAML.
Rob? Your code...
> Here's a transcript of checkpatch (from Linux 5.11-rc1)'s output:
>
> $ scripts/checkpatch.pl --strict patches-wpcm/0001-dt-bindings-arm-Convert-nuvoton-npcm750-binding-to-Y.patch
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #31:
> deleted file mode 100644
>
>
> WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
>
>
> WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
>
>
> total: 0 errors, 3 warnings, 0 checks, 21 lines checked
>
>
> NOTE: For some of the reported defects, checkpatch may be able to
> mechanically convert to the typical style using --fix or --fix-inplace.
>
>
> patches-wpcm/0001-dt-bindings-arm-Convert-nuvoton-npcm750-binding-to-Y.patch has style problems, please review.
>
>
> NOTE: If any of the errors are false positives, please report
> them to the maintainer, see CHECKPATCH in MAINTAINERS.
>
>
> I attached the patch, for reference.
>
>
> Best regards,
> Jonathan Neuschäfer
prev parent reply other threads:[~2021-01-01 1:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-31 22:04 Jonathan Neuschäfer
2021-01-01 1:55 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4abaac7b4b792dd44880d8acf6ef51d9db89e512.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=j.neuschaefer@gmx.net \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®