From: "Paul E. McKenney" <paulmck@kernel.org>
To: K Prateek Nayak <kprateek.nayak@amd.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
Joel Fernandes <joelagnelf@nvidia.com>,
linux-kernel@vger.kernel.org, kernel-team@meta.com
Subject: Re: [PATCH] sched/core: Call wakeup_preempt() for queued tasks during class change
Date: Wed, 14 Oct 2026 05:59:12 -0700 [thread overview]
Message-ID: <4abd0c29-efde-4e8b-a498-aea5a0fb788f@paulmck-laptop> (raw)
In-Reply-To: <c334b382-a13c-4222-99bb-798340ff0d68@paulmck-laptop>
On Tue, Oct 13, 2026 at 05:13:00PM -0700, Paul E. McKenney wrote:
> On Tue, Oct 13, 2026 at 01:06:50PM -0700, Paul E. McKenney wrote:
> > On Tue, Oct 13, 2026 at 12:55:12PM -0700, Paul E. McKenney wrote:
> > > On Tue, Oct 13, 2026 at 10:57:17AM -0700, Paul E. McKenney wrote:
> > > > On Tue, Oct 13, 2026 at 03:24:55PM +0000, K Prateek Nayak wrote:
> > > > > Paul reported recent RCU changes exposed a lost resched where CPU idles
> > > > > with a rcutorture thread waiting while being completely runnable.
> > > > >
> > > > > Dumping the rq state at the time of idling with runnable tasks showed
> > > > > the following:
> > > > >
> > > > > rq->next_class = &fair_sched_class
> > > > > rq->nr_running = 1
> > > > > rq->cfs.h_nr_queued = 0
> > > > > rq->rt.rt_nr_running = 1
> > > > >
> > > > > Although the waiting task was an RT task, "rq->next_class" did not point
> > > > > to rt_sched_class and was stuck at the lower priority fair_sched_class.
> > > >
> > > > Thank you all very much! I have started a short test. If all goes well
> > > > with the short tests, I will run an overnight test.
> > > >
> > > > I will of course let you know how the individual tests go.
> > >
> > > 20 minutes of 39*TREE03 (13 hours) on x86 passed! 2 hours of 9*TREE03 (18
> > > hours) on arm64 in progress. Starting five hours of 200*TREE03 on x86.
> > > If that works, 12 hours of same.
> >
> > And the 2 hours of 9*TREE03 on arm64 passed! Started a 15-hour run.
>
> And the five hours of 200*TREE03 on x86 passed! Started a 12-hour run.
>
> So thus far, this patch has passed bit more than 1,000 hours on x86 and
> 18 hours on arm64. (Something about having access to quite a few more
> x86 boxes than arm64 boxes.)
>
> If it is still alive in the morning, Pacific Time, it will have more
> than earned itself a Tested-by. ;-)
Tested-by: Paul E. McKenney <paulmck@kernel.org>
Thank you all very much!!!
For those into statistics, these test results give 99.9% confidence that
this patch reduced the bug rate by more than two orders of magnitude. ;-)
Thanx, Paul
next prev parent reply other threads:[~2026-10-14 12:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-12 18:41 [BUG] Apparent lost wakeups Paul E. McKenney
2026-10-13 6:06 ` K Prateek Nayak
2026-10-13 6:46 ` K Prateek Nayak
2026-10-13 7:58 ` Vincent Guittot
2026-10-13 8:30 ` K Prateek Nayak
2026-10-13 8:36 ` Vincent Guittot
2026-10-13 10:14 ` Peter Zijlstra
2026-10-13 10:29 ` K Prateek Nayak
2026-10-13 10:37 ` Peter Zijlstra
2026-10-13 10:43 ` K Prateek Nayak
2026-10-13 10:06 ` Peter Zijlstra
2026-10-13 15:24 ` [PATCH] sched/core: Call wakeup_preempt() for queued tasks during class change K Prateek Nayak
2026-10-13 16:45 ` Vincent Guittot
2026-10-13 17:57 ` Paul E. McKenney
2026-10-13 19:55 ` Paul E. McKenney
2026-10-13 20:06 ` Paul E. McKenney
2026-10-14 0:13 ` Paul E. McKenney
2026-10-14 12:59 ` Paul E. McKenney [this message]
2026-10-14 13:03 ` Peter Zijlstra
2026-10-14 6:37 ` K Prateek Nayak
2026-10-14 10:59 ` Phil Auld
2026-10-14 13:12 ` [tip: sched/urgent] " tip-bot2 for K Prateek Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4abd0c29-efde-4e8b-a498-aea5a0fb788f@paulmck-laptop \
--to=paulmck@kernel.org \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=joelagnelf@nvidia.com \
--cc=juri.lelli@redhat.com \
--cc=kernel-team@meta.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®