From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7A265382281 for ; Wed, 8 Jul 2026 14:43:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783521811; cv=none; b=uCsnDs5rUtUokXeoqYX26LuVuiIHP6N7NLL+l34kbtVAcJnlp06rYyUKJK4U0/35xl5HbqhEvHH6ITyI7GoCXgT7WP8Rw1Z11Okedv4dP38EOKjkLXshzTkPZq89ib8L0EXz1M528jh20mxUcgfsPQbwFTrSOr8cI4R2W/fe20s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783521811; c=relaxed/simple; bh=BdoClZGhrMnHXO+Nj2ZOJIYUUzTfbMX+l2BW6eLj1z0=; h=Message-ID:Date:MIME-Version:Subject:To:References:From:Cc: In-Reply-To:Content-Type; b=lyAcFj+2vl/EyQ1mlTI9gGjISCE7DHf3g8RysQddwTRBKSmyv6DR2Q8Tr7R7Cv17GgOJT31r5gzwv/U+oLKKLta+r9ReHBBHwCMMoH7J57C6S4Zb1FdbDSfaEUNA+iKoDWSS1fgHYyK5PRuFIPyeIRYqI52D8p4felbtXAVZYFo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=I1+4CANb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ON6iNNl8; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="I1+4CANb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ON6iNNl8" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 668C3E5M2751574 for ; Wed, 8 Jul 2026 14:43:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0gdecsGlT1UYIEodgg+h6tmVGXJuiUMpriS8ug2nM0E=; b=I1+4CANbCIONvmem RP+pkwigRqRj3uyt0aYxKn29gYqSR6bPN/FNqTOWeQ3R5ffu+C6C8qGuAPknGnMj FPPwPDweZzcCTqEtE06Kqx4y+ocOnb8FgejP8UXFs+BaJFzb+zyDo11Rjqq393nS GOKVGYlNY82qWao4AQ+9ICxFFpfbck07yJ29Exzt9L2J9LzIhAlKql4AalrT0Xfv qjq+wLF8PlbsSRNimZX+SoU5Np3k/oyBrbruBESufbBUnZdvoZIqVx2ZnBBFjoPH obnzQlVJTPnJyBNRxJkN+RFeUh1FDbFoE8gsgf8EgO6+lf7LofP0tMU9/fw5y7RM yV7o7w== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f9g7hj7nh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 08 Jul 2026 14:43:28 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-8479cc04d8fso1527052b3a.2 for ; Wed, 08 Jul 2026 07:43:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783521808; x=1784126608; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:cc:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=0gdecsGlT1UYIEodgg+h6tmVGXJuiUMpriS8ug2nM0E=; b=ON6iNNl8QircjzlgwMAQk21eyvwtgyfllsbjSAR4zONxZOxCbQHk5t8Qsg0wekWFs3 FXZ/5uPadeWnbRL56Up+4rSV7w66jAeBWZtfQJHi5MVDOfmAKRzJRou+XYftPa6D5Car xqx48iAEIZNjnmBR6otv7sBmWL5qOeFOtEu901qc5ym00Ij8zB18MDeiKSFFMcbs1cXf c7uIngxvrCzbtzhBAXE0O1YQbTljs4rX43i46cQcYGy/GPdMpcex6OsvhBIhfgHvCQ5U GuLVwX2YEkwk5YCbSnx9nc7ZdLLJ7aRAnq5/li09Zh5CP61PfiwRVqBL2f7pPW6Ik6lj v0Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783521808; x=1784126608; h=content-transfer-encoding:content-type:in-reply-to:cc:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0gdecsGlT1UYIEodgg+h6tmVGXJuiUMpriS8ug2nM0E=; b=rS8h6GX+YDJ0sqLNVK62xAd5V2J3hv2pMVM5tIhL4CFZwafhO5mKHxvfjDwTyboOiz zECDFfrOVqm9OokFTKAamipz+z2/j3FVKeeofFC1MFrn9TuDuA9uZV2LdXPOdGTPEyPF 2d2acbCT86PhaaOkdJRXpB1bpIZHOik1g1ld74OQQiVCKX+1/uUCuEkUTUG6dSW/nyl5 8iFVlnFfglK9Dx6bdWsTTFhCFQ27ghMU45WoYcvkeluj0CSI8ACLGnzD8QJryhbjJSnF VTG67uPbsUQsMjranfEtnYCNmDRa75gTdnHYFZGTm7MJ+R8CrJ2g0U+1PHRZPrupY/eu snuw== X-Forwarded-Encrypted: i=1; AHgh+Rp1udP3/edCUWZDKH1CEgOXpeUNO/Ip8Y2pr5ZfiJs9t5bg5FyEegnGAw4v/6wvWj4T9CVxx8rXibVQ5zY=@vger.kernel.org X-Gm-Message-State: AOJu0Yxjs8IBo7ix+fjyosL3fwfr7AAI+Sep8Cccpwtlkg3RY7iBFyWB h75COQkJMTenFwjM7iFDlMsmccOfTm0D9/oIepyHD9tlCPsIxcPZNWlT+EeoBCCiOed/oBJd77z /wpB4FwqYcCGn9UdnXoFc5rccixyQr7DIZgRKStmlMeD5W7Hkskxx+hhHYB5Ye46UjT4= X-Gm-Gg: AfdE7ckUOLn8bcCpwOk8Q6LYBKr4Cgcd29nqpirxoABkpfH8xYIvYSbLCHzXGTMURU3 zyuxX58oXjEo8Khm6349JSerbSqMpDXcaATULrsIqOz9BtBUFKHj5j+LcN6WE7evG5L7KLQeFqN T1C9MsaujaADUbEaJSWOJL5O4xx3Lzt8oM/q9mxIhPuinkOTmm0W0kd9K0WdXEcDorhcb5ni4Z+ 02Ylyq1BDc7FGhf66AZJLhRx8lCpShWDaSfwpEK7q9ofUIwjATaSb2IpyOOLb//l5PHtJAoD+bU rZXcV4I98sl/yqGQq4NmhzSjfoMUnVdXMyYA67uGo3wdiQHOp4Pnsbm4rfeLKmKWuA5ZAiPzL5K BeE+bzZsn5JBpkuJiSKgeVu1tgx6dbxIXrr6bu6Vv0Il7eDC4yRNvSZ78KWTOQAqtFl+tD8jNXo rTUnhOICM= X-Received: by 2002:a05:6a00:2d86:b0:847:82dc:450e with SMTP id d2e1a72fcca58-84842ef8889mr2902175b3a.8.1783521808011; Wed, 08 Jul 2026 07:43:28 -0700 (PDT) X-Received: by 2002:a05:6a00:2d86:b0:847:82dc:450e with SMTP id d2e1a72fcca58-84842ef8889mr2902154b3a.8.1783521807551; Wed, 08 Jul 2026 07:43:27 -0700 (PDT) Received: from [10.133.33.185] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-ca5af7d58f3sm2460134a12.1.2026.07.08.07.43.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jul 2026 07:43:27 -0700 (PDT) Message-ID: <4ac18ed1-0807-443a-9031-c0bdb885fec6@oss.qualcomm.com> Date: Wed, 8 Jul 2026 22:43:21 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] cpufreq: nforce2: put PCI device on driver register failure To: Guangshuo Li , "Rafael J. Wysocki" , Viresh Kumar , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260708110131.748268-1-lgs201920130244@gmail.com> Content-Language: en-US From: Zhongqiu Han Cc: zhongqiu.han@oss.qualcomm.com In-Reply-To: <20260708110131.748268-1-lgs201920130244@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA4MDE0NSBTYWx0ZWRfX5Qnv4MFJuCJC cYkj5dpgx/XjUePcPUUPljw/KJ+jB7WVHUGVVOHIKJkoRHY1nr081gY7PO9DFni3N//ZJuuOSDT A03l/NaXOxbjwWuugzYcBVHZv1c2ZPAh7oeABkiGm/tN3Vxu15gzI1cm0I7dQcP+obu9OpX/wt5 UKBFtVWcKbQCwGOtx9b7yDPkmVmERAReu88uzKTjHJhj4pDenkEKLE4y5locEW9Kc8FdCI2M9ji cZfh83f6m7/jMSZi2zE1PHgadDpzMvhCu/vZ0DIQwtq/iDV6SPtpt0UbYfj+FlxgmiZSIA0sUl+ 6oNEs4BSQW0m0QkCmAo1PLOe2oWlQBgi7EfZKbuh0CP7tO8VTbmIbf4GmTbE4hHYpPrHNP4Wxj3 mLCS3ndo99PUyVofqBY1K98NU9AepOx3xBF6ZL9H0hnCzbN+7UwZs5jDZ5wnmX4Bvqw4Rx4lPpw 4DX7YIqy6HfbUBJdIHw== X-Proofpoint-GUID: sYBJxTtiSD0eiz89TEpwqofUxbYUiFJn X-Authority-Analysis: v=2.4 cv=TMp1jVla c=1 sm=1 tr=0 ts=6a4e6210 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=pGLkceISAAAA:8 a=EUspDBNiAAAA:8 a=ZQ7csA7MKCUh9F4vvJkA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA4MDE0NSBTYWx0ZWRfXw7LxJUan93HB vXeJ0mUO/D3FFHKBup6MZAHhdH3beQWqmwmvKd/9mul0VIQOUJMn4a3ehqFJkKm9mbn5O/Zdcn3 ZoaTzCWdScOp/7cEhbgP7hSoOmcFWWI= X-Proofpoint-ORIG-GUID: sYBJxTtiSD0eiz89TEpwqofUxbYUiFJn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-08_02,2026-07-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 suspectscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 phishscore=0 spamscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607080145 On 7/8/2026 7:01 PM, Guangshuo Li wrote: > nforce2_detect_chipset() stores a PCI device returned by > pci_get_subsys() in the global nforce2_dev pointer. That reference is > kept for the lifetime of the loaded module and is released from > nforce2_exit(). > > However, nforce2_init() gets the PCI device reference before registering > the cpufreq driver. If cpufreq_register_driver() fails, nforce2_init() > returns an error and the module exit path is not run. The reference held > in nforce2_dev is then leaked. > > Drop the PCI device reference before returning from the registration > failure path. Clear the global pointer as well so the failed > initialization leaves no stale reference behind. > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by: Guangshuo Li > --- > drivers/cpufreq/cpufreq-nforce2.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/cpufreq-nforce2.c b/drivers/cpufreq/cpufreq-nforce2.c > index 831102522ad6..5a101c69c47a 100644 > --- a/drivers/cpufreq/cpufreq-nforce2.c > +++ b/drivers/cpufreq/cpufreq-nforce2.c > @@ -409,6 +409,8 @@ static int nforce2_detect_chipset(void) > */ > static int __init nforce2_init(void) > { > + int ret; > + > /* TODO: do we need to detect the processor? */ > > /* detect chipset */ > @@ -417,7 +419,13 @@ static int __init nforce2_init(void) > return -ENODEV; > } > > - return cpufreq_register_driver(&nforce2_driver); > + ret = cpufreq_register_driver(&nforce2_driver); > + if (ret) { > + pci_dev_put(nforce2_dev); > + nforce2_dev = NULL; nit: setting nforce2_dev to NULL looks redundant here. Reviewed-by: Zhongqiu Han > + } > + > + return ret; > } > > /** -- Thx and BRs, Zhongqiu Han