From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 661E33A9639 for ; Wed, 18 Mar 2026 09:32:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773826327; cv=none; b=Hw0IWLiQzOJEOQoxkjUIJC37BMhYyH1gmNJbmnHGl90F1V1zGhVeyCr4pVNOdIdsa692JDdYD4N/qnqV1mWvodia+f+9TwHCp9bmEDketcSSOqHASedt7agng6+I2BnEyHMMwRr10wjjKNp49v1OEQzLPyt1vP2SNK8ToeeGKr8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773826327; c=relaxed/simple; bh=m7sKiZPj3SO+ZMld7la5ZQCKUA11O2/+oIVQrdIJ5A8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=jISsTSh8ZppsOo8mCqch7I71zWn/sYLKSvpPLkpX1czgNqTGTQZqtahASgFBiENCgH2+WLaHVx7USepaDGwefcOYcU41hnYb3VHCzW9eWEuHmyKYgbUZ1L9QfuiS0txjuCvdJMK814OVwee1Dh8jkt8jmKz2HxTegG0EBsoMIrk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=krDJyi/p; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LyjsCvzG; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="krDJyi/p"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LyjsCvzG" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62I99qdf402520 for ; Wed, 18 Mar 2026 09:32:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6rU9r6GK2AYbjb46aZ6kaVHJJ8hcMQ9WFGGRTQl1vss=; b=krDJyi/pzQ0hkcB8 Xe5KKZ9AX23pA3mGzmJK8ZX9JmMROwRKr3ppOsDC+ZgPMqxmz3tKzpM4bzZcgxap LNfk5MLnfDWdpFzm1iRHOTBBNNrH+TnZV9uuyMcfjTbIDe3MNfZykYKt6inFW2dx SUOx/nZq7aDNezHznyx/D63PQXVHOfI3fC/KyWtpPO/7ehac5oZ9+LeVEsWr7XO7 sFV05JXZWq8hJqb35AzjzdkCAZxovvrNB8Jai59n+svunv2BZJOYdLDrwUGQNRgt z9gsTzuI4r0ZET7QPscT/AhF8X44A6NCShTByiqZRzQ5CF/z3Kjgw3g4Zo1MnOa6 3lJd3Q== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cyc4du3pt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 18 Mar 2026 09:32:03 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cd97debc51so499793285a.1 for ; Wed, 18 Mar 2026 02:32:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773826322; x=1774431122; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6rU9r6GK2AYbjb46aZ6kaVHJJ8hcMQ9WFGGRTQl1vss=; b=LyjsCvzGdUKsecyPK8zJ4955So1A2TyKn9MaRZgSQEnspb0Y1UnrqLVYRi3uRgGX2Y E6RJD3l8BKlwyioTGjEhRAwA9Vvf/FdWoKc1pIs7z99qFHKzKQa9gXt9SmTvGINQx5S0 oYPOmmeUyCUYaJ3sYp/tlQUQDSThxQoaHmDZmg36FTlZkdeXJA1IV52FKQ+Y0BEabOw/ kgLLFLLIBClvxoT3+n3VNDCh03NeHcj/XhXlnALbZGELeePIB/BweqJS0vOEkaEVUUsN FSm5U6JNhqRKgrmbMidxUpdDAWroSSsMzJ38a2LVJqMhDEBXfNFhmsTcY5jektkBuHXm cP4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773826322; x=1774431122; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6rU9r6GK2AYbjb46aZ6kaVHJJ8hcMQ9WFGGRTQl1vss=; b=oxK3CIZmW5dqm+Y1UXMS2mdcEthrIwsg/XNLdTAeBgKF/usnVDDnZKGYgHu0dsmp3F hCtNFmEQbevUZdjv/rZKC95lXhT6cxWwgwkBCjIlDyiIyH+uu1tBDOdm+ZfrI4iREflC W110FH417t7fDFe3lCvSn+al6GgTIwfi3ZKKuALIbVrH7z9talwyqNy2SwkZzg6V0Wl6 RAk7MT3WtIBwAEgbj/hpdcpojTJcepY8lMfCdKOoE2+eYLN6k9AoGWMINhC/Q0bqEo0f x+UgXyWYwmUn7FcBu8DmERwW0FxndEI0HggG7w98F7lG/MUMlL97QCmNrLz8P0OWsZan HNVA== X-Forwarded-Encrypted: i=1; AJvYcCVUGHayrQYE+FG0Hhdy9/vLiKtPnZEmfaw8g6pcGDZ8qX4MYEc8zltU+zkQYTXQd076YAF/WQtklhqCon4=@vger.kernel.org X-Gm-Message-State: AOJu0YyIHTQPmcmJPj2oIWSMAiebof6/N4mloUMG+6TmdMHbF+0skrS1 sya2+ub/Au2E8hh8FluBH3pqX1Po03HvZqNc1C7QpoWmLb/FkoJm9ZQ8O6gu969m+LMstTIRGfi DCG1v66a3CtZ53wc7N29TwVXP3LuOPC26zdUcMjynAUdS8Z4IsPlc2xmyCwo8ZKCyelY= X-Gm-Gg: ATEYQzydpVkWRBBgsrUB9Rw/1UyxIbYX3wCcuLuyikCzqa7lFRxcMvt2ihi4srtUHFu RPwtTFUfrlHcCQ32tEm1+x021nU4bkgp5bOC3LavB21i0AbAP/eV00mfI9dU7OOwzE66vnsQwZF qP25WhFqf/zvDzjKVweE8msjtujuuuk43AxaRHgdPlpYUBAlh6ZKzxty3TN9kn3i5IhUGeQ55+7 69Xe9cPKk5B0rbaJHQ6sFJ9Py+9tknh4+gIBT+e+5aaZJJg2ig7i9CxKFNU1uSXNQCpVu/MzEXm xao3eUzyjmaOe0A7bkvozKmjZOKJYKqypMbVbZA2yijKVoLSUApH03jjVlAfxv4ezHwkzJSL9GS ivfgBrmQHk2vVXi0m6C/i10VAANBuhY4T0h8+1CSmdHedp/QmYLRj/MN6NNiATIRM6oNGzaTa8D C/kO8= X-Received: by 2002:a05:620a:171f:b0:8cd:b2cd:ed4 with SMTP id af79cd13be357-8cfad27373fmr254277285a.3.1773826322520; Wed, 18 Mar 2026 02:32:02 -0700 (PDT) X-Received: by 2002:a05:620a:171f:b0:8cd:b2cd:ed4 with SMTP id af79cd13be357-8cfad27373fmr254275385a.3.1773826322008; Wed, 18 Mar 2026 02:32:02 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-667b0eb9b0asm1287145a12.14.2026.03.18.02.31.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2026 02:32:01 -0700 (PDT) Message-ID: <4ac195f3-0241-43dd-8e67-41b56afae8dd@oss.qualcomm.com> Date: Wed, 18 Mar 2026 10:31:59 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 04/11] clk: qcom: gcc-sc8180x: Use retention for PCIe power domains To: Val Packett , Bjorn Andersson , Michael Turquette , Stephen Boyd Cc: Konrad Dybcio , Johan Hovold , Manivannan Sadhasivam , Dmitry Baryshkov , Maximilian Luz , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov References: <20260312112321.370983-1-val@packett.cool> <20260312112321.370983-5-val@packett.cool> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260312112321.370983-5-val@packett.cool> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE4MDA3OSBTYWx0ZWRfXz++mOtU8w5mq qr0PwIMaZNXzTvHHx2BM6nE8xeeSktfwXL9PL/aeBwQiI43lF1pEM55xm4uAQ2XF2GoT5tjpKH1 4uMcJhg2EG3DgHQ0VJkQw2VFOpGXdl9KOe+jLVtY08p1EKcAqkAAa5ZY2GG0VEmDMxMsIzqmNo5 VApSIBYlDuyftoI0FhhioqVBh1QOHaeu0MGsvj2IGidXHNy/lbyXHj42SrbbqberdVU96A7uqe1 dFQ9HaVrVKL0HjoMb0RLzyeRRHXJ939LXZz2cuIKJe4SrH3puD5M9fg7zcmyuwptUKfNWk8I/eT 8jfSdFSiDele1fnbmvnEpv2yqIhTAHb24IHBwX8tpGA7ceB/8+YPGgEm+Lm9LDA2t4CjKibcz+E Ft88kLGDX8kPORdlB9aMeh24y6dbXUEd87rbcawO67pj47LCfPKSjXxTLyTPf2quBztlXcGiWdv aAF7mDFxmFbdR2fQTcQ== X-Proofpoint-GUID: WDuFhcWNsxdWtXnTtEqYilgD7svOHMav X-Authority-Analysis: v=2.4 cv=DfQaa/tW c=1 sm=1 tr=0 ts=69ba7113 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=rY4xH7PTqmT0HzfHl3EA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-ORIG-GUID: WDuFhcWNsxdWtXnTtEqYilgD7svOHMav X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-17_05,2026-03-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 impostorscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 clxscore=1015 spamscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603180079 On 3/12/26 12:12 PM, Val Packett wrote: > As the PCIe host controller driver does not yet support dealing with the > loss of state during suspend, use retention for relevant GDSCs. > > This fixes the link not surviving upon resume: > > nvme 0002:01:00.0: Unable to change power state from D3cold to D0, device inaccessible > nvme nvme0: controller is down; will reset: CSTS=0xffffffff, PCI_STATUS read failed (134) > nvme 0002:01:00.0: Unable to change power state from D3cold to D0, device inaccessible > nvme nvme0: Disabling device after reset failure: -19 > > Fixes: 4433594bbe5d ("clk: qcom: gcc: Add global clock controller driver for SC8180x") > Reviewed-by: Dmitry Baryshkov > Signed-off-by: Val Packett > --- Reviewed-by: Konrad Dybcio Konrad