From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6663F3932EC for ; Fri, 13 Mar 2026 12:58:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773406687; cv=none; b=J833UxsynK75k9OZkEMgIwj7FkmK6ZKSG2KzZSq6u6FevZxZgG9IfiIEp8PcX9wekYyea7yrO3dCpxxuziinKqy4Xk9UAtVU4+Juk9OHzHu/V66vP+RbOvfg6xE2h3vscpnHS4lvqEo+5Qp087PZCHCVK6sLw+bdHxBhSGtArAs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773406687; c=relaxed/simple; bh=MyqNZV4kLPyL+KkBjM7DQKFlw5piMQTaOiqhQm3Rfu8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=t7ICmMA5gcol/l1M4wcIu9hGmzQi6VIi0HpzOvReZYjU96ndVZHBOIJz+vQXQLGQqvKULIb6hKZqLpEcSCW1xdy9mtMoicXWtDAeCf/G/v/I3p7N+Y3lkhDozsDlcdZ8r0yUV2GoKXvS+m4/hGJhEWShgJSG4nfyQUgMlwIUImk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fw6s9tIx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=h60wwW0M; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fw6s9tIx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="h60wwW0M" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62D6oMmN792882 for ; Fri, 13 Mar 2026 12:58:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qjWxh3bFSUoQMyo0hJ03HjGFms6uNt3s23pwaTXBU3o=; b=fw6s9tIxoLz0NPzo E0MFFfwVYMmIqcp2OfLullq43DdKFpia29Fo2dhz1iDDXGJPZTmL1iXX2gP+AGJq i/pN24o0ackgL311/q7+BTwAGQiA4Gepc7RknjaqrAlrB9rWQGb8kpSqWPrZ2uPx dEfAGwcIeFN6gJD2IDp0oC/DU7SOGlEg39g5HsRqExNMp1f2Vt0s2EUmTBCCufU7 /XohfSxJXzFn9o6zEzS/OgVS4J3FblcTRXaV1RQfSiwKApHWIIqWwE4C3bIzlqiU Pxk4spv7TnrEzwwRX1jBBGRtJTFAsVcn7aIYuUESh52fWSgHEIc+b04WkyLQJDOC LmACYQ== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cvdnt193m-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Mar 2026 12:58:02 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cd8198fe16so136742985a.2 for ; Fri, 13 Mar 2026 05:58:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773406682; x=1774011482; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qjWxh3bFSUoQMyo0hJ03HjGFms6uNt3s23pwaTXBU3o=; b=h60wwW0M2Rh4kyD4XHZ5SvAEqU2A5lBJes/tOHYo5ymIEidh9KGN7j6zExWICvOSNs 2L72M7Cfo6v1f7fwpZp9d53dntRFjoQGJmJh/LedY8a/2HZL61ikTmD0B/TizoYQcdhC 9affiZQxd4cdBXA/NeSAh2oC8LffeXMXiQYaKaFG5gSuknE8/siwk2PF42o4b18OUQ9/ WlbcYRm77TsyE1TIoTKrqE7qoUbgjdA37ak+mcAKLSk3tDewgsEnw5aYJZG5MMtRZ/Ek 6cLSjV73ns1zfISQtc0QtqkNLp7f6jRHj/PIgjvKjh+ne6DPT5lg9dkCtzy3+Zg6CKK5 X9wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773406682; x=1774011482; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qjWxh3bFSUoQMyo0hJ03HjGFms6uNt3s23pwaTXBU3o=; b=mncG8pnD4p6+uCuMNLr1hhi7gnWUDmJMYyL+pTvbqL8OrQhcXr8FE0XuxsMeSDSCXk 4tv7g3rUlljMIlEEKtUNPJRVW7OXsDOdHVJenvAK58us2Vk8Bhpf2xnI+zh4yFYBuSka g1UwkBUgJ0jCUOyNjr7S2n5LfFI9whUroJgr9Z3mZgz2HHgoud3mABY1kqXLYUWrrv4z Gh/E8n8427+ZQB5wgl8lPwVIGVjuStnHCm+3ev1051k5y0iQwhN/VsJDDpRV1ybFF1VW IbwYi1M1AT3SYGWa4obnk+gw5gewsuUx/ECsde5VaFB/7+29c1zSl2QBOfG1TBYAzg7c hOaw== X-Forwarded-Encrypted: i=1; AJvYcCVWgly+4ua3yPaWIbSLyiVzTRH8I0vpQIn0VTHidU1m9yNNLREknpeyZucFPW2HgTold6H6UP0j0aNb7sE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2bG2DTt7sGFTfAMB0gBYyqjrrO+GMdnId2SNvvi9hoFxlj0EK 2s3f8xRYpTYHF8MiGUqMPGKb+7BwZDsyUoGO7dsr1YoyOVZq4q5Myf9kbOo66K+h1ajqy9un1b/ g0XWBk0Q276VtxW1XGVCbiHBFRfSdccJAYroMZju6tyeAbqtqeSKr270Z45KmYtUkm9vdOLW45I Q= X-Gm-Gg: ATEYQzwLX7ep1NFayq/wKid53W6MzE1yODzeo8/CzEwkIB8JqflHmTsLCJEyppjz9FW uecI439RAStl7/g9yAwXRinOovbZBP6au6/lcsmbCBTngazo4ki5GqPNnJga2dCI8uoUmY/gtQf lo5rxaRomqJQQWku0Hlf6ECcC3aMfCgDtsQLfaad79jg3pgvKZIHk7WeJhxnBeX1ILrFotN48+y 7Trit+9pZkd5A+YuS5XJ8j704Fq5/cbHoVBHg8ifQKP1pSOlUVkgtIEeG9obX8kfo3HwqWPirTO V/5o5BxZ8ti5TmZv6TdbjrndxI6CQiuhTqDKkMfgTP5Y0cFW+RbzgOnjhE+qfpazKmja7yWGYSo CqkpINv4nAOWYdTj+r0/cHzqpxOqcI/8HXabHE7APiGmwogJiLHn00hYEweXc4YlvBNwkmWFyyi qPnVw= X-Received: by 2002:a05:620a:8e17:b0:8cd:b6e4:81df with SMTP id af79cd13be357-8cdb6e48634mr197173585a.6.1773406681456; Fri, 13 Mar 2026 05:58:01 -0700 (PDT) X-Received: by 2002:a05:620a:8e17:b0:8cd:b6e4:81df with SMTP id af79cd13be357-8cdb6e48634mr197171385a.6.1773406680850; Fri, 13 Mar 2026 05:58:00 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-66350b86008sm1212444a12.28.2026.03.13.05.57.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2026 05:57:59 -0700 (PDT) Message-ID: <4ac54faf-e27b-4907-ae8a-d3ec910e8040@oss.qualcomm.com> Date: Fri, 13 Mar 2026 13:57:56 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] arm64: dts: qcom: glymur-crd: Enable keyboard, trackpad and touchscreen To: Abel Vesa , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260312-glymur-dts-crd-enable-kbd-tp-ts-v2-1-2277bee4c564@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260312-glymur-dts-crd-enable-kbd-tp-ts-v2-1-2277bee4c564@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=KZrfcAYD c=1 sm=1 tr=0 ts=69b409da cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=c-Kx7w3T0iWJJxMe-8gA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-GUID: 0Revbn_SvgJxt9J45B0yfU5k8CaQ-7hZ X-Proofpoint-ORIG-GUID: 0Revbn_SvgJxt9J45B0yfU5k8CaQ-7hZ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEzMDEwMyBTYWx0ZWRfXxLH0YDitN5ke OJQ7M24hfRD0y1TPWC+jIIQIWd0CVPhChCZrAGZlCn/rbTFQqnpkA8xNm5AupKmJt7T4XbSMjB7 2TeVzJn25hNJtCA7v5ppTQ+dqdJS/nnz4iCBbu952xVqt84ncfQnVsemd3laL5AGxsxbytL7fNg 3EnxBKPC2Bj8g16Vm+SFfoWlTdAe5rgzz+JoFShcnx7fkzvBGDZue9lWOpur1pJzpqEhXAlTPIk 6NxNNA4kOt7nw9hBc8UOWo0dc8VHj915YOVWD95M02fipLswcSvcBPw3waN0V558dhR7c9MajtV G18jIW3CfBxd6IyIjWnHtRUFet19MMxJxHrbyxoMxjssTOaJWES3/mHL97J6LJCZ41O26DMsHmf sZJ+NB3od0y+HPKoQVjQ8OXD6wWSGf8smuXiqBIJILDTjEWEqInBrTR3saF/wRv2VkF9gZWDnfG 9i4pTQmAFXalFg3gqig== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-13_02,2026-03-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 impostorscore=0 adultscore=0 clxscore=1015 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603130103 On 3/12/26 2:00 PM, Abel Vesa wrote: > On CRD, the keyboard, trackpad and touchscreen are connected over I2C > and all share a 3.3V regulator. > > So describe the regulator and each input device along with their > pinctrl states. > > Signed-off-by: Abel Vesa > --- > + > + ts0_default: ts0-default-state { > + int-n-pins { > + pins = "gpio51"; > + function = "gpio"; > + bias-disable; > + }; > + > + reset-n-pins { > + pins = "gpio48"; > + function = "gpio"; > + output-high; we shouldn't need to drive this pin by default (also missing bias setting) other than that: Reviewed-by: Konrad Dybcio Konrad