From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3ED8148EBF6 for ; Wed, 29 Jul 2026 15:20:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785338416; cv=none; b=b5p0VQTBOBLtFFBPlIAjqxhmzZh+yjwe+pvWJYfBenKBTZXRLe5KANRDgzfKc2Sc3+gS6QMOBdY4bb+5KzaBdXCRR7mLDgC4BMP2yYJKuFZ1ygi6iz9n6ES19659KloJBPMAaEbUy3uSOhON9dFm/uFLdjH6SGfdhF0YhGvkWDk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785338416; c=relaxed/simple; bh=Q6sBthUihfALMVsGkLGR5ZzbAeYn7uW3Hj529CcHdig=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jHla8NJDyRwf7yWMdJTsKuT4Su7EO9y8J2ghnWqJk50vrDv4vbGfPl4ayd4WGLRbl5y7mMUcnrHi2Vt+eBgCmCvhXAHrS3lSEt0rxCeqkvmxjFrkOJqW5SHH8NTz4+9bh6NmyYlqiFjlkkPJAQHmwWHk7OLX4FaLxNgRcdHxBOk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OhuV60IL; arc=none smtp.client-ip=209.85.160.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OhuV60IL" Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-51c05dcdf49so9810841cf.0 for ; Wed, 29 Jul 2026 08:20:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785338414; x=1785943214; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zcRpeRPBTfk7ClMYXLvexss7+DxkZQ7yLWlVxi0mrIE=; b=OhuV60IL+DAfqS++Aua2Z8vFvQ2oTYprYGT0iIEDBTMtZCybDIQZ0p0hHx0j8ShRAo dDmXoO3x+gT2QpoLb5HbVb5j5ShN8pjk9ZtNmW/DBU0D1hFdNesWewVTHV6+uAW8KTIk mYZOSfI5jj40eXm9mB1dgOZaVaAO8ZmMLwvA6lQLZ/z3pB3AjBX1Wf9pi3Lzt976TZSB a10boQ6VvSBkpukvBmyoWeQYPrG45sFQNXHZYYQ3/1kKwEsjG45XbpZZRuc7vkj/qSL2 FajSt6nWj2PwvUN1DyBa69iVInbail31SrcmLfZilgaQNvuiF2z+4RJV03frip6PWo+j sobA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785338414; x=1785943214; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=zcRpeRPBTfk7ClMYXLvexss7+DxkZQ7yLWlVxi0mrIE=; b=lUyxCc1+SmSLb6wwGFNClgu/aKL+wM4kgczqhMW0mUleOhfdvuuxJDuyu5UhNGel47 T8VAXnraSXqXRMr8RywIazdYt5JvIkulVsAq6OqA2AbZxFDErPtURpUZek7b8gZkkX2z UT7Qi/kSxyGTu7yvaSRXTEqMmswPupvdJqOOtCxzZlomVNYbubObLr08D4lWIzVKZeyD yXCl5PKvhEy3Hs8zWmSEaPcW1PXFHWjRki6A8dDKvkf7n2T8YNrWxHCm7ZdelJE3UMgv uJHCgfxqHJSvN70imWMo6YY1kS9IDnEwlpVlv5xgBHcr+O0Kd6ie5/FUabu/gFXYzKxa ewkw== X-Gm-Message-State: AOJu0Yz/Qk/MNpLXpmC8u5wNCOnFwNkFBJbq1GEqKzCybjx97awCsbVK FDqTu94SJi7PMHyyqxVXJ4L/Wbc87Lkrk7+Z4vjoiS1DkWNvGg2mDWx404Us5SzHof0= X-Gm-Gg: AR+sD10zWKVL1RV8xbHfJleH9Gq0ULyZ96sdutnfHWfSIbJ0o5vFHoBeRHfsEsARedl +ofOQjkB7aO+SG17QDCcA58MRIcvWwckhuYUxhjb9+u0FgE1WEI3s9vXFM6EpR2umj1nMIUq2G4 mD6vO4hDdLy5h2JbCRZo4qYCzBb6YOVkClKgtk623m66UoZszngPQj4Jec2eGKyHQCvYks80quz s+rJp4GmDap4fh7BSxeEPNDn9j8Tb4aRL5jShH0E/+O5Q5WOPpMFmldayYsPFUIKuL7ftVVvqGY 4p0p8XGuo5eQ5ey/SzMhebj1ZGE7QI+GRjMH72maMJwS1LVVd9R11488vZL2EnMEm7oT/Eg4Hev zBlpp+sqXu5SQQOahuMyuEh8WMq7k21SGGKTrAvYb/zNLhghWYnLx1F5hVs/bOMOvn/fBCHf4Vk cJLR58QpIjxRLZyfsJ8exR5ZK+m881DzuU6D/2a5jbmZt2nE4jOF4WuPLCFqMMwGPoDDNS85QM7 Ruc X-Received: by 2002:a05:622a:1f94:b0:527:69ec:9725 with SMTP id d75a77b69052e-529d717663fmr68563171cf.74.1785338413953; Wed, 29 Jul 2026 08:20:13 -0700 (PDT) Received: from enjou-Legion-Y7000P-2019 ([165.232.167.5]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-9081dc4286dsm26812166d6.7.2026.07.29.08.20.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jul 2026 08:20:13 -0700 (PDT) From: Ren Wei To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, vega@nebusec.ai, rakukuip@gmail.com, enjou1224z@gmail.com Subject: [PATCH 1/1] tracing/uprobes: Reject unregistering enabled trace_uprobe to prevent UAF Date: Wed, 29 Jul 2026 23:19:59 +0800 Message-ID: <4ac73dd24e3123cdcdb3e938dc7bd74be66a3f77.1785227724.git.rakukuip@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Luxiao Xu When unregistering a trace_uprobe, if the probe has a sibling (i.e. trace_probe_has_sibling() is true), unregister_trace_uprobe() jumps directly to unreg, bypassing event busy checks and unregister_uprobe_event(). However, if the trace_uprobe is currently enabled, freeing it without disabling it allows uprobe callbacks (such as uprobe_dispatcher()) to continue accessing the freed trace_uprobe structure. This leads to a use-after-free (UAF) condition. Fix this by checking trace_probe_is_enabled() at the entry of unregister_trace_uprobe(). If the probe is enabled, return -EBUSY immediately to prevent unregistering and freeing an active probe. Fixes: 41af3cf587f4 ("tracing/uprobe: Add multi-probe per uprobe event support") Cc: Reported-by: Vega Assisted-by: Codex:gpt-5.4 Signed-off-by: Luxiao Xu Signed-off-by: Ren Wei --- kernel/trace/trace_uprobe.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c index c274346853d1..a514a82c4ae0 100644 --- a/kernel/trace/trace_uprobe.c +++ b/kernel/trace/trace_uprobe.c @@ -396,6 +396,9 @@ static int unregister_trace_uprobe(struct trace_uprobe *tu) { int ret; + if (trace_probe_is_enabled(&tu->tp)) + return -EBUSY; + if (trace_probe_has_sibling(&tu->tp)) goto unreg; -- 2.43.0