mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Tuncer Ayaz" <tuncer.ayaz@gmail.com>
To: linux-kernel@vger.kernel.org, ak@suse.de, yinghai.lu@amd.com
Subject: IO_APIC broken by 45edfd1db02f818b3dc7e4743ee8585af6b78f78
Date: Wed, 25 Oct 2006 14:37:57 +0200	[thread overview]
Message-ID: <4ac8254d0610250537m7ee628cbo255decde52586742@mail.gmail.com> (raw)

I've bisected the non-working'ness of HD-Audio and USB Mouse on one of
my x86_64 boxes back to the following commit.

The machine is an HP xw4400 Core 2 Duo E6600 with the Intel 975X chipset.
Please let me know if you need any debug info.

45edfd1db02f818b3dc7e4743ee8585af6b78f78 is first bad commit
commit 45edfd1db02f818b3dc7e4743ee8585af6b78f78
Author: Yinghai Lu <yinghai.lu@amd.com>
Date:   Sat Oct 21 18:37:01 2006 +0200

    [PATCH] x86-64: typo in __assign_irq_vector when updating pos for
vector and offset

    typo with cpu instead of new_cpu

    Signed-off-by: Yinghai Lu <yinghai.lu@amd.com>
    Signed-off-by: Andi Kleen <ak@suse.de>

:040000 040000 1d64801d89bfb23ef4d63d1625f47122d01ded6c
03bb862d9bfdfb05fb5382d56d52ffe1c5f8aba2 M	arch

Accordingly ther revert-diff is this
diff --git a/arch/x86_64/kernel/io_apic.c b/arch/x86_64/kernel/io_apic.c
index b000017..1fa95d5 100644
--- a/arch/x86_64/kernel/io_apic.c
+++ b/arch/x86_64/kernel/io_apic.c
@@ -651,12 +651,12 @@ next:
                if (vector == IA32_SYSCALL_VECTOR)
                        goto next;
                for_each_cpu_mask(new_cpu, domain)
-                       if (per_cpu(vector_irq, new_cpu)[vector] != -1)
+                       if (per_cpu(vector_irq, cpu)[vector] != -1)
                                goto next;
                /* Found one! */
                for_each_cpu_mask(new_cpu, domain) {
-                       pos[new_cpu].vector = vector;
-                       pos[new_cpu].offset = offset;
+                       pos[cpu].vector = vector;
+                       pos[cpu].offset = offset;
                }
                if (old_vector >= 0) {
                        int old_cpu;

             reply	other threads:[~2006-10-25 12:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-25 12:37 Tuncer Ayaz [this message]
2006-10-25 13:03 ` Muli Ben-Yehuda
2006-10-25 14:37   ` Tuncer Ayaz
2006-10-26 14:41     ` Tuncer Ayaz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ac8254d0610250537m7ee628cbo255decde52586742@mail.gmail.com \
    --to=tuncer.ayaz@gmail.com \
    --cc=ak@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yinghai.lu@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®