From: Waiman Long <longman@redhat.com>
To: john.p.donnelly@oracle.com, Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Will Deacon <will@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>
Cc: linux-kernel@vger.kernel.org, "Hillf Danton" <hdanton@sina.com>,
"Mukesh Ojha" <quic_mojha@quicinc.com>,
"Ting11 Wang 王婷" <wangting11@xiaomi.com>,
"Jack Vogel" <jack.vogel@oracle.com>,
"Jorge Lopez" <jorge.jo.lopez@oracle.com>,
"Vijayendra Suman" <vijayendra.suman@oracle.com>
Subject: Re: [PATCH v4 3/5] locking/rwsem: Change waiter->hanodff_set to a handoff_state enum
Date: Mon, 24 Oct 2022 14:46:49 -0400 [thread overview]
Message-ID: <4ac8ed1b-6f2c-5083-fae3-4b6fe9e8cf1b@redhat.com> (raw)
In-Reply-To: <e392155b-5c96-11a5-df32-6670139223da@oracle.com>
On 10/24/22 14:25, john.p.donnelly@oracle.com wrote:
> On 10/24/22 12:44 PM, Waiman Long wrote:
>> Change the boolean waiter->handoff_set to an enum type so that we can
>> have more states in some later patches. Also use READ_ONCE() outside
>> wait_lock critical sections for read and WRITE_ONCE() inside wait_lock
>> critical sections for write for proper synchronization. There is no
>> functional change.
>
> Hi,
>
> Do we need
>
>
> Fixes: d257cc8cb8d5 ("locking/rwsem: Make handoff bit handling more
> consistent")
>
> Fixes: 91d2a812dfb9 ("locking/rwsem: Make handoff writer
> optimistically spin on owner")
>
> Cc: stable@vger.kernel.org
>
>
> clauses added to patches 3,4,5 so they are all picked up in one series ?
>
> Thank you,
>
> John.
I am not planning to do that. The handoff code rewrite represent a
moderate amount of changes. So I don't want them to be backported to
stable in case there are some hidden bugs inside. That is why I have
patch 2 is essentially reverted in patch 4.
Cheers,
Longman
next prev parent reply other threads:[~2022-10-24 20:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 17:44 [PATCH v4 0/5] lockinig/rwsem: Fix rwsem bugs & enable true lock handoff Waiman Long
2022-10-24 17:44 ` [PATCH v4 1/5] locking/rwsem: Prevent non-first waiter from spinning in down_write() slowpath Waiman Long
2022-10-24 17:44 ` [PATCH v4 2/5] locking/rwsem: Limit # of null owner retries for handoff writer Waiman Long
2022-10-24 17:44 ` [PATCH v4 3/5] locking/rwsem: Change waiter->hanodff_set to a handoff_state enum Waiman Long
2022-10-24 18:25 ` john.p.donnelly
2022-10-24 18:46 ` Waiman Long [this message]
2022-10-24 17:44 ` [PATCH v4 4/5] locking/rwsem: Enable direct rwsem lock handoff Waiman Long
2022-10-24 17:44 ` [PATCH v4 5/5] locking/rwsem: Update handoff lock events tracking Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ac8ed1b-6f2c-5083-fae3-4b6fe9e8cf1b@redhat.com \
--to=longman@redhat.com \
--cc=boqun.feng@gmail.com \
--cc=hdanton@sina.com \
--cc=jack.vogel@oracle.com \
--cc=john.p.donnelly@oracle.com \
--cc=jorge.jo.lopez@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=quic_mojha@quicinc.com \
--cc=vijayendra.suman@oracle.com \
--cc=wangting11@xiaomi.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®