From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2890119B5B1 for ; Fri, 13 Jun 2025 13:54:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749822845; cv=none; b=Ykt5gJLyH1BmVicUONhf3ENE/hzFSzPnDSGxKgGFntMNiO4U45VM19nU4RYvMnpG65e0vNuRrRgit+Rh6wflqpeVtUXZ+eIwvZqE3+iaXyfg4YO0IUrux7CTcBsrWDWQIZbXPGchr+H+Cj+4hDEkXwSll3p23/NdU9/FvNpqWBk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749822845; c=relaxed/simple; bh=ORYavnhAPu0E8N1JgBTyHx4ZyOnhxOZgHMZuYqgAjk0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LD+DOSQDwrib9vkDqh5i+yx7tqB9uxO6YDk0p1PRp+L7aIWFRMa3FK97X7DVwd0hFLLl/Uvdr6XkzpAmpOTXzoynFY5wXfnt1hi4oGPwSw8ZwsTPL+LvQaOSbuf9D8IZHQ6qxs+G5eZQ+3mbIlw3Ax/kfWbKepMKGd39N5aC188= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=A1FHkI3E; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="A1FHkI3E" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749822843; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BU5JyOHWosQhM/6S0NPkSCkvdLM9aueb+w9hBh6xwnE=; b=A1FHkI3EJuN5fP0W6hU0kP0xbru3j4b1VBHTeeknkr+hqtZPrubfy1312hWw5/6QL0Ofnj 1QvEt7TLn487qaOR4ADciNFQc+htLCR+TiBym791E9BedGHvHU/kEf8LLc+bjChI3CTCpy yLiSqxxcI6MSkccbbzxkkPTujJBtlsI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-515-LEqFGRDJO12eOQE-j5BpUA-1; Fri, 13 Jun 2025 09:54:02 -0400 X-MC-Unique: LEqFGRDJO12eOQE-j5BpUA-1 X-Mimecast-MFC-AGG-ID: LEqFGRDJO12eOQE-j5BpUA_1749822841 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-452ff9e054eso11157125e9.2 for ; Fri, 13 Jun 2025 06:54:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749822841; x=1750427641; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=BU5JyOHWosQhM/6S0NPkSCkvdLM9aueb+w9hBh6xwnE=; b=PygL0xMSpJH76zH3hSHLwafUS8apX+GNEAn1rgs2KJnCX1k5+qHcb5l6/lQUYoeuTa WIj+5SejoWJajVIs9HzchQo5uYNsEbpJsMavNhTf1JdDF7gd3c5ferAwWO0F3/3Bt2MA h94A8OaxFYMGBpBYAD/SzBxpXKaXP9j3H4J15jXB1cfgCVswOQmY4ojmiTdHc7o9eYi/ qg/TTlc4xnl6Ng7uZxoN8qWtiXEIb/lykNuY04WDDN2HA3QazQKhP9yCfBMaqEBhbk1p YG7Y8dBCSqcaQFbnqGiVQ4TsLECmZi88A8FzUqE+MWPaB4rarMSCatM7fJFeL9dpJIq4 7+Pg== X-Gm-Message-State: AOJu0Yypbw2KBZcgIiwx7TUQ73hLFE4FSVfYto40HEnR0nM/PakY5mjP 3/UdfBh/gog2/Rr4bgfJ+oj+L8Xvv17z/nGQm3jwvbgmWZPXb0J7VpaSwe/s/goDZhMUYCs4T8E ilS3OrtcksGoTavjNeibQCIHQfPbqvmMDnHgmks++aB7QVtpxAUDgPb/3KAF9jWcovg== X-Gm-Gg: ASbGncsreYBHjw1VsSBB/dHNg4MnR5q1vdNGOChUnN23d7rB0y9IFDZ/cKoTHluyMAu ZIpHu7NtSdvDYKiB9vv/EXsyg7m9fXNX+RZqKoHa4umfPZlkII6zUPW3q72abMzsGILfq+KnER0 hpqXMmJrpxvm9uObjdMtpzFqy5GS6S/2jOdbucymvftmYFi0vtZH38OV+DGPvruoICRHvSQLsVo 9+1fxas3JFLDVSbjB9soFv1sCoAaTjUiJKCX2yOExPmHp/8StQCR00q00myAfJ9e3/l1ht2NP66 mTmkw1MkndSrDEGrOtTOd6p5Aiicb6+07AOcxv5PjfZNZt9fzuO9B+W4gcHLBK4quh7dV6ym/4K K4QefMjdW5qJ+UrJdMFq6pWTWx23fQEIgoOAvcnNKfYc7QvUN+w== X-Received: by 2002:a5d:5c84:0:b0:3a4:ee40:6c85 with SMTP id ffacd0b85a97d-3a568782a9dmr2754771f8f.54.1749822840866; Fri, 13 Jun 2025 06:54:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IET2fbn9FBBIkd7aBt+1E8zNBbPyT+ISzzLAkF7LjOk3Wnlvm3OEjK8bvUbn25abxKjOlKU0w== X-Received: by 2002:a5d:5c84:0:b0:3a4:ee40:6c85 with SMTP id ffacd0b85a97d-3a568782a9dmr2754728f8f.54.1749822840315; Fri, 13 Jun 2025 06:54:00 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1a:3700:2982:b5f7:a04e:4cb4? (p200300d82f1a37002982b5f7a04e4cb4.dip0.t-ipconnect.de. [2003:d8:2f1a:3700:2982:b5f7:a04e:4cb4]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a568b6debasm2463786f8f.93.2025.06.13.06.53.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Jun 2025 06:53:59 -0700 (PDT) Message-ID: <4acaa46f-f856-4116-917e-08e7c1f3156a@redhat.com> Date: Fri, 13 Jun 2025 15:53:58 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pmd() To: Oscar Salvador Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, Andrew Morton , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Dan Williams , Jason Gunthorpe References: <20250613092702.1943533-1-david@redhat.com> <20250613092702.1943533-3-david@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13.06.25 15:49, Oscar Salvador wrote: > On Fri, Jun 13, 2025 at 11:27:01AM +0200, David Hildenbrand wrote: >> Marking PMDs that map a "normal" refcounted folios as special is >> against our rules documented for vm_normal_page(): normal (refcounted) >> folios shall never have the page table mapping marked as special. >> >> Fortunately, there are not that many pmd_special() check that can be >> mislead, and most vm_normal_page_pmd()/vm_normal_folio_pmd() users that >> would get this wrong right now are rather harmless: e.g., none so far >> bases decisions whether to grab a folio reference on that decision. >> >> Well, and GUP-fast will fallback to GUP-slow. All in all, so far no big >> implications as it seems. >> >> Getting this right will get more important as we use >> folio_normal_page_pmd() in more places. >> >> Fix it by teaching insert_pfn_pmd() to properly handle folios and >> pfns -- moving refcount/mapcount/etc handling in there, renaming it to >> insert_pmd(), and distinguishing between both cases using a new simple >> "struct folio_or_pfn" structure. >> >> Use folio_mk_pmd() to create a pmd for a folio cleanly. >> >> Fixes: 6c88f72691f8 ("mm/huge_memory: add vmf_insert_folio_pmd()") >> Reviewed-by: Jason Gunthorpe >> Reviewed-by: Lorenzo Stoakes >> Reviewed-by: Dan Williams >> Tested-by: Dan Williams >> Signed-off-by: David Hildenbrand > > Altough we have it quite well explained here in the changelog, maybe > having a little comment in insert_pmd() noting why pmds mapping normal > folios cannot be marked special would be nice. Well, I don't think we should be replicating that all over the place. The big comment above vm_normal_page() is currently our source of truth (which I will teak soon further). Thanks! -- Cheers, David / dhildenb