From: Jens Axboe <axboe@kernel.dk>
To: Tao pilgrim <pilgrimtao@gmail.com>, Bart Van Assche <bvanassche@acm.org>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Chengkaitao <chengkaitao@kylinos.cn>
Subject: Re: [PATCH] mq-deadline: the dd->dispatch queue follows a FIFO policy
Date: Tue, 9 Dec 2025 15:11:54 -0700 [thread overview]
Message-ID: <4acab1b8-f67e-454b-a493-ac4c00193c51@kernel.dk> (raw)
In-Reply-To: <CAAWJmAb0+Xhm7Wy2kqH7E4VGLUqZa_2ohBYP4ttw6zzjD109JA@mail.gmail.com>
On 12/8/25 7:06 PM, Tao pilgrim wrote:
> However, now all requests in the dd->dispatch list carry
> the BLK_MQ_INSERT_AT_HEAD flag, and I can't find any justification for
> continuing to use a LIFO (last-in-first-out) policy.
What if a head insertion requires another TUR or similar before being
able to be processed?
I agree with notion that AT_HEAD should generally be issued in order,
but let's not make blanket changes like this just because you can't find
any immediate justification for why the current behavior is as it is.
It'd be different if you were fixing a bug and came across this. But
that does not seem to be the case.
--
Jens Axboe
prev parent reply other threads:[~2025-12-09 22:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-08 11:02 chengkaitao
2025-12-08 16:24 ` Bart Van Assche
2025-12-09 2:06 ` Tao pilgrim
2025-12-09 22:11 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4acab1b8-f67e-454b-a493-ac4c00193c51@kernel.dk \
--to=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=chengkaitao@kylinos.cn \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pilgrimtao@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®