From: Mukesh Savaliya <mukesh.savaliya@oss.qualcomm.com>
To: Thorsten Leemhuis <regressions@leemhuis.info>,
Daniel J Blueman <daniel@quora.org>,
Andi Shyti <andi.shyti@kernel.org>,
Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>
Cc: Sasha Levin <sashal@kernel.org>,
Manikanta Mylavarapu <quic_mmanikan@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Birk Skyum <birk.skyum@pm.me>,
Linux kernel regressions list <regressions@lists.linux.dev>
Subject: Re: [PATCH] i2c: qcom-geni: restore tSCL with 32MHz I2C fast-mode
Date: Tue, 13 Oct 2026 23:58:44 +0530 [thread overview]
Message-ID: <4acb0eee-f7ae-4817-9848-d72cf486bc06@oss.qualcomm.com> (raw)
In-Reply-To: <b7bfbf6a-e5b5-48be-84ad-8bcd8e22c5de@leemhuis.info>
Hi Thorsten, Thanks !
On 10/13/2026 1:04 PM, Thorsten Leemhuis wrote:
> On 10/9/26 21:01, Sasha Levin wrote:
>>> On 9/30/2026 3:01 PM, Daniel J Blueman wrote:
>>>> I would revert the original patch if there is hardware that uses the
>>>> I2C 1MHz fast-mode, since the current timings aren't to spec, but also
>>>> weren't before.
>>
>> For stable: cb97bf3d4f91 ("i2c: qcom-geni: Fix hardcoded clock index in
>> SE_GENI_CLK_SEL") has already shipped in 7.2.9, 6.18.55 and 6.12.112, and is
>> queued for 6.6, 6.1, 5.15 and 5.10.
>>
>> The 32 MHz clock map (506bb2ab0075, v6.13+) does not exist in 6.12.y and older.
>> The backports there pick only the 19.2 MHz entry, so the Yoga Slim 7x /
>> X1E80100 timing regression cannot occur on 6.12.y or older, and I'm keeping the
>> 6.6 and older queues as they are.
>>
>> 7.2.y and 6.18.y do have the 32 MHz table and are affected. Once the fix lands
>> in mainline, I'll pick it up for 7.2 and 6.18.
>
> @Andi, @viken, and/or @Daniel:
>
> Is the patch at the start of the thread or some improved version heading
> to mainline meanwhile? What Sasha wrote above is one reason why that
> would be good rather sooner than latter; another is a regression
> report[1] from Birk (now CCed) wo ran into the problem with mainline --
> so it would be good to fix this before 7.3 is released, too.
>
> Or is a revert the better option to achieve that?
>
This is in active discussion with hardware experts, but taking time to
get specs compliant configuration values while it's being tested.
I see 7.3 release on 25th, so what max time we can have before reverting ?
I am trying to get values asap.
> Ciao, Thorsten
>
> [1]
> https://lore.kernel.org/stable/179173732257.29426.7905170638383807320@pm.me/
next prev parent reply other threads:[~2026-10-13 18:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 4:14 Daniel J Blueman
2026-09-30 7:19 ` Mukesh Savaliya
2026-09-30 9:31 ` Daniel J Blueman
2026-10-06 4:57 ` Mukesh Savaliya
2026-10-09 19:01 ` Sasha Levin
2026-10-13 7:34 ` Thorsten Leemhuis
2026-10-13 18:28 ` Mukesh Savaliya [this message]
2026-10-14 5:08 ` Thorsten Leemhuis
2026-10-14 12:11 ` Birk Skyum
2026-10-12 12:25 Birk Skyum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4acb0eee-f7ae-4817-9848-d72cf486bc06@oss.qualcomm.com \
--to=mukesh.savaliya@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=birk.skyum@pm.me \
--cc=daniel@quora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_mmanikan@quicinc.com \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=viken.dadhaniya@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®