Re: [PATCH v2 0/5] arm64: dts: qcom: eliza-cqs-evk: Add storage subtypes and rework generic parts

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 9/15/26 2:03 PM, Abel Vesa wrote:
> It turns out there is a UFS variant of the Eliza CQS SoM as well. So lets
> differentiate between them with -emmc and -ufs suffixes for DTBs and
> compatible strings.
> 
> Adding -emmc suffix for to the current Eliza CQS SoM and EVK devicetree
> files will not affect any current users as these boards have not reached
> public use yet.
> 
> Also, move the sound card support from the eliza-cqs-evk to the generic
> eliza-evk, which will allow it to be reused not only by the UFS variant,
> but also by the Eliza CQM EVK later on.
> 
> Changes in v2:
> - Actually replace (and remove) the eliza-cqs-evk.dtsi when the
>   eliza-cqs-evk-emmc.dtsi is added.
> - Collect Krzysztof's R-b tag.
> - Link to v1: https://patch.msgid.link/20260914-dts-qcom-eliza-add-ufs-variant-v1-0-78b3249eae61@oss.qualcomm.com
> 
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---
> Abel Vesa (5):
>       dt-bindings: arm: qcom: Add more compatible for Eliza EVKs and SoMs
>       arm64: dts: qcom: eliza-cqs-evk: Move sound card support to Eliza EVK generic
>       arm64: dts: qcom: eliza: Rename existing EVK to suggest eMMC
>       arm64: dts: qcom: eliza: Add CQS SoM UFS variant
>       arm64: dts: qcom: eliza: Add CQS EVK UFS variant

I was hoping there would be a bit less duplication here..

$ diff arch/arm64/boot/dts/qcom/eliza-cqs-som-emmc.dtsi arch/arm64/boot/dts/qcom/eliza-cqs-som-ufs.dtsi

281,282c281,282
<                       regulator-min-microvolt = <1800000>;
<                       regulator-max-microvolt = <1800000>;
---
>                       regulator-min-microvolt = <1140000>;
>                       regulator-max-microvolt = <1260000>;
399,414d398
< &sdhc_1 {
<       vmmc-supply = <&vreg_l12b>;
<       vqmmc-supply = <&vreg_l1d>;
<       pinctrl-0 = <&sdc1_default>;
<       pinctrl-1 = <&sdc1_sleep>;
<       pinctrl-names = "default", "sleep";
<       mmc-hs400-1_8v;
<       mmc-hs200-1_8v;
<       non-removable;
<       supports-cqe;
<       no-sdio;
<       no-sd;
< 
<       status = "okay";
< };
< 
418a403,420
> };
> 
> &ufs_mem_hc {
>       reset-gpios = <&tlmm 185 GPIO_ACTIVE_LOW>;
> 
>       vcc-supply = <&vreg_l12b>;
>       vcc-max-microamp = <1300000>;
>       vccq-supply = <&vreg_l1d>;
>       vccq-max-microamp = <1200000>;
> 
>       status = "okay";
> };
> 
> &ufs_mem_phy {
>       vdda-phy-supply = <&vreg_l6b>;
>       vdda-pll-supply = <&vreg_l4b>;
> 
>       status = "okay";

Konrad