From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 112E5378832 for ; Thu, 28 May 2026 08:20:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779956428; cv=none; b=PiH8f/vH5AKUEddSH7s4dHzw8up8wlTvaZuy0xci3gLIG62wUw+M4OOdDUsyjt+z9NQvpXIYlf3hJr4Zsnz1yCXqM43Xq+Ov9yvuIlGZf2emO6/4l2zJKrGxFBR2zUknghOkvn2qhY72xI1XUTA/H2Y9TPe5es88kOar8ZaHJkQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779956428; c=relaxed/simple; bh=k6eRRFC+TiuYdWGZdLinc5vULGz0buSb/AMsG+EdJ4E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DRdUyJKug40Kg0tii7gJh+ykuauesmE8ORiJnI6FZwZhulD5DPiUh9WCEozgmC/ovQ86qWhnJ/IQzotX4QWa8rMcYe8rxXOdGrhPcC3XeGyWCgLnrcm3lF8tlgGyyr2PdAo/p9PMVpmmnT76Zum/nVKOSbVj7XI5E+VrGLiOI3M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=T6p/7hqE; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="T6p/7hqE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8AE9C1F000E9; Thu, 28 May 2026 08:20:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779956426; bh=x+8NAOb/A/8TvZS1/YH3oIOgxhYSlPSAkKFv4aDZ71w=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=T6p/7hqEY8yx3KAzDO2CkOs0GbdJi8Ut1Ic9XGT5wzeIEQwjJwFfaw3r76SOyIqM9 OJej+uLa9NKHPdFRiJdyHRHBF64bUMpbvdyublrgoRZez+j0md+KKFnFB+iPFeorkq SeH1YzEls4IMWEQmxsLEOeSw3U7hGXIHI3vxzEywf19n9jqlLVTeOSkIP0/lKcWDpH OjO5C0YDp+N4QQXr1rhedKhkvrHc4enOwUbV4iU4xgRc/3guNiiMLQsmiI6f5foMkx XB+2wryC0ssPPT7owuddA2EulqYqLhrtCl7nZjjQyWpkJGcG0h0HYCsOC0mJ931Rbo KFu460cKsjjFA== Message-ID: <4aceb6da-774f-4a6f-9a10-d06ff37b0e6c@kernel.org> Date: Thu, 28 May 2026 17:20:22 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] mm, slab: simplify returning slab in __refill_objects_node() To: "Vlastimil Babka (SUSE)" Cc: Hao Li , Christoph Lameter , David Rientjes , Roman Gushchin , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, hu.shengming@zte.com.cn, Vinicius Costa Gomes References: <20260522-b4-refill-optimistic-return-v3-0-2ba78ec1c6ed@kernel.org> <20260522-b4-refill-optimistic-return-v3-2-2ba78ec1c6ed@kernel.org> Content-Language: en-US From: Harry Yoo In-Reply-To: <20260522-b4-refill-optimistic-return-v3-2-2ba78ec1c6ed@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/22/26 11:23 PM, Vlastimil Babka (SUSE) wrote: > When we return slabs to the partial list because we didn't fully refill > from them, we observe the min_partial limit when the returned slab is > empty, and discard it when over the limit. But it's unlikely for the > limit to be reached while we were refilling, and the worst outcome is to > have temporarily more free slabs on the list than necessary. So just > drop that code and simplify the function. > > Signed-off-by: Vlastimil Babka (SUSE) > --- Reviewed-by: Harry Yoo (Oracle) -- Cheers, Harry / Hyeonggon