From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9A6E2354AFA for ; Fri, 30 Jan 2026 09:34:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769765672; cv=none; b=VyjmO/e7WyoPh9va8wKP5K/TMcvMuAi7SlvcZID8Auf/jAyv35SnnxJBysLWfXP1njPK5+jTLiYc4O77xHvelvNFYM28j4XLLY41WmxJBJ75DykKB1o/EX4JM+GYUVxe2tiPjG94OrL8XQLhiaS9NCMWBW9NOFPDJvqkW3wUIH8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769765672; c=relaxed/simple; bh=/qm+laPxDQSVVEBM1MDc3pzP5L/h6hONLDt5AdW3/s8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QIwn3UJdwgyYuUsM9e93Zx8Kzm1TmH8xGq6ksoMSUalwPgl5KyBdRb8HXgw4KKTq4NV9+e2MToASvJXxRWbPqfOakqi6fdjDnifhdvOWXmv9BIBoBsWP0V2ftTxRRWket7J22M6lBhYtvgjxOovddhreGsDggZ/9qc8xi29hCbE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VR5W4POk; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DkMAMCK6; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VR5W4POk"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DkMAMCK6" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60U3VZHt995901 for ; Fri, 30 Jan 2026 09:34:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2STZ0D4tnVYio8ZJ6lqbw7gF65jH7c36j1+cGpuh2Ms=; b=VR5W4POkW7p4mgLT WUsabdTPxSMe3U8PWJRjPwF60csEO7Y3SV27LxgdxpyA5PacEXmApgzA637byRGG ZSB7Yi6REfN7w/Ome6PXKYkQBsX8v03p+WNtEvfGeBvWSPKOOBbJk2PjPfOol3KQ 2qQgb/hDTNXgd/4Vu4dujT844MviJjNQfxp4wvZbqtjaDiQWRO6b8vRUuFmjZ6Ox H5liuFTbkPg5DPVH7eRv0Pv79EHzwp85FbRHq+dcYR+y2PrgLe3avgorT28wuwc5 r0NLWdj+901bxBeHzQQgsC0PQ/iwNcgeI665mUi4rVnH/AOfh+czRtPrC6WsgPTp rYatfw== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c0bvvjkek-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 30 Jan 2026 09:34:30 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8946ebb51a0so6461796d6.0 for ; Fri, 30 Jan 2026 01:34:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769765670; x=1770370470; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2STZ0D4tnVYio8ZJ6lqbw7gF65jH7c36j1+cGpuh2Ms=; b=DkMAMCK6qc9ENLpZ7yBuH0k2tyDarrPPVsZn/WiTMOvOhtRwlQd1o2quBV0Jv6kNnL 6CpdJhHAEhqpdjodl65mKhQdjsm4fafYfLo5uNtJvrOCYprp0xsNjN0VEHeSX6et9z4a 2y0GnxGjWP4GsZ2CJ/bS5LXbxYEUGukNrY3/Cb9x68fPnd6dOCg0tUT2/ftQ5Aq/nXtJ AoJPALz5SEaMbDBG9hrXesIFN+MQylyLoDRGSLSUJsGoFix9iMYcXPnh7stCg8ljGcV8 1VIF7JwnKy0yQmiEK2QjuZUhG6b15gGcnfWmyDVYncluZSTF8lQWcWWDSMix9QRPiJSy QZcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769765670; x=1770370470; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2STZ0D4tnVYio8ZJ6lqbw7gF65jH7c36j1+cGpuh2Ms=; b=YUWwvMo3LuCxaqBEjQ1b+dCwEk9sqUwIk4hEdFkRzeSXR7ryPgblIHpjBF/m2XqW6q iRZkO//YHF0GWcnfHijyzIzl7UQHXut3S0cwRRx83f6rMJFKBLIssDTQ1K3aXJKQyxO1 UUNRWy3QqNsJLvW/lGXZXp5u+EsDCpi6FZCz8kE/Ohby9k2tOwMbLN+Bj6Q4XxG75t2i a9I/GGDdF+8ehDvCGETrXx4fILihKgqbkC6u9ndxV2sDr8Nw/iYi3Cf4SzDly1FmDRyu F8WmSKXdtyMUB5QKWLHBqkf3NpH9r4b1TsCnjzzu8m3bNvtRpdrY7sUBni9fXj9MT5pv b/Sw== X-Forwarded-Encrypted: i=1; AJvYcCWfA/2XPjr0tDLHlNzHO0P+AcGkJS+A7i8T5pCgg8eQUZtaGrJs6s33jTw+5Rs6nFFeIWl/xaEtkPwjLG4=@vger.kernel.org X-Gm-Message-State: AOJu0Yxok2W8NJqlwsEo6F2cpm46OryrkvCH++parSS0I2/kE5Mej7i0 azVmt+h/y/DOsStLRO+Mf9sYo0rnPSgI7KAQ/mm3t1ZEYzyo/hklnimhYE7TPqnqeuFrOw8mmG0 tPR9F8GaIwGMJvwtH6iUUkPaP8cpw5Rvwug7yweGd9DqQfi7Am/JiZSqfJqkgKZoPSbM= X-Gm-Gg: AZuq6aJZ5pgrpWBZgTxUv1LaDnUYW/oe+307k5FUPcpHeEdsPC5rVXALoZKysCqg06b MZDhrUpTkF/XnYsmVC+NQR3Q+IZRiypCo223K8QNiYhraPzN0OPEJcYmwnnW5OkQrPquJKACi/H zVevZeav9+ke8P+JG+wWHdJME32Q+XYxtkz7kZ7qjF9bQdTLR21MMHR61EYtCdhf+RS7dWikfbP X0MKgE4LXOPhtfkF1KUT1N680UjoW0prx9FYrtvhSzg66iGgtRzNlSbpLRTHonbXCyn0tOhLw1G 7wWt4kJSZ9TIRWowkQ1RX89Wj4FaZjoRW0Qhi0mlj5YyxHQv4xPnoFC6Yulf0EsnWyMclR6J30F myM66ipHSgziXQVWmRELJpfZ8RvXTyYWRGq2BzkRGunI8m0M6su02itY6kEh2MAotTHU= X-Received: by 2002:a05:6214:4d06:b0:894:a36b:f7df with SMTP id 6a1803df08f44-894ea188ae6mr21143196d6.8.1769765669781; Fri, 30 Jan 2026 01:34:29 -0800 (PST) X-Received: by 2002:a05:6214:4d06:b0:894:a36b:f7df with SMTP id 6a1803df08f44-894ea188ae6mr21142996d6.8.1769765669267; Fri, 30 Jan 2026 01:34:29 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-658b4691d15sm3784885a12.19.2026.01.30.01.34.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Jan 2026 01:34:28 -0800 (PST) Message-ID: <4ad700f3-da8f-4175-9172-3fc4d87d8152@oss.qualcomm.com> Date: Fri, 30 Jan 2026 10:34:26 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] soc: qcom: ice: Avoid probe deferring for un-supported ICE feature To: Sumit Garg , linux-arm-msm@vger.kernel.org Cc: andersson@kernel.org, konradybcio@kernel.org, abelvesa@kernel.org, mani@kernel.org, linux-kernel@vger.kernel.org, Sumit Garg References: <20260130091118.147379-1-sumit.garg@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260130091118.147379-1-sumit.garg@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=ZdEQ98VA c=1 sm=1 tr=0 ts=697c7b26 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=4Re6pYePfbHeZKqWRTAA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-GUID: Wgl-_2vViRkNnVY2t1pnOnj4NvPmmhjf X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTMwMDA3NSBTYWx0ZWRfXx9yKhsNDWwzD jPTbRa7lTYZ7jwxqvXkKEOYhwX026/8uLorVIjbCTmcAfLz94SweX1Xe59KFKsu5bTclVX4lUdD dS227UvnzmZs8nZ0suRl4WLqewIesZuCLsWgwEiFGLyQVm+Gf10/3ulQxK1/RutBpo54ofN1P0l 3/I5BdzJX1Yj3Gg5hRbq8bYdQvmWBE9FQVXrvzUy4pzhHUKj+SKQX2CcwPHLhej7b+GScZZlUGi UA69KB+49hdSyssT03Isfrvt5VW9ssof2lz4OntpXSHOekyey9hsUyFci58rqCFvwWMT6TNBJpq cfs1Ryzn2Lq8m4jf0Dv2V9ZtuUl1wsOzn1X5bKAnEEGtWcr1BIacJZDqVpY1fawNFDsOyy6F0iS ri7KSXLLbIBymhXpiFr5ZxD3jr6Rj8IZY5VRiEHrAERiwek0+ILq0cjpCQM45o0HntEHt8s4a1x pk7Ov0IHS+GnWz3SGfQ== X-Proofpoint-ORIG-GUID: Wgl-_2vViRkNnVY2t1pnOnj4NvPmmhjf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-29_03,2026-01-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 phishscore=0 spamscore=0 suspectscore=0 malwarescore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601300075 On 1/30/26 10:11 AM, Sumit Garg wrote: > From: Sumit Garg > > ICE related SCM calls may not be supported in every TZ environment like > OP-TEE or a no-TZ environment too. So let's try to avoid probe deferring > when it's known that ICE feature isn't supported. > > This problem only came to notice after the inline encryption drivers were > enabled in the arm64 defconfig by: commit 5f37788adedd ("arm64: defconfig: > Enable SCSI UFS Crypto and Block Inline encryption drivers"). > > Fixes: 2afbf43a4aec ("soc: qcom: Make the Qualcomm UFS/SDCC ICE a dedicated driver") > Signed-off-by: Sumit Garg > --- > drivers/soc/qcom/ice.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soc/qcom/ice.c b/drivers/soc/qcom/ice.c > index b203bc685cad..ab9586b8caf5 100644 > --- a/drivers/soc/qcom/ice.c > +++ b/drivers/soc/qcom/ice.c > @@ -652,7 +652,7 @@ static struct qcom_ice *of_qcom_ice_get(struct device *dev) > dev_err(dev, "Cannot get ice instance from %s\n", > dev_name(&pdev->dev)); > platform_device_put(pdev); > - return ERR_PTR(-EPROBE_DEFER); > + return NULL; Wouldn't this wreck the "actually need to defer" case, i.e. qcom,ufs probes first calls devm_of_qcom_ice_get() "ice" reg is missing, non-legacy case qcom,ice is absent (not yet probed) return NULL ... qcom,ice probes ? Konrad