From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752159AbdHPO6I (ORCPT <rfc822;w@1wt.eu>);
        Wed, 16 Aug 2017 10:58:08 -0400
Received: from foss.arm.com ([217.140.101.70]:36502 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751569AbdHPO6H (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 16 Aug 2017 10:58:07 -0400
Subject: Re: [RCF PATCH] genirq/debugfs: Triggering of interrupts from
 userspace
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
References: <20170720155135.31962-1-marc.zyngier@arm.com>
 <alpine.DEB.2.20.1708161645220.1987@nanos>
From: Marc Zyngier <marc.zyngier@arm.com>
Organization: ARM Ltd
Message-ID: <4adc52d6-b7f6-a992-cd67-ba112edc1d01@arm.com>
Date: Wed, 16 Aug 2017 15:58:04 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1708161645220.1987@nanos>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 16/08/17 15:50, Thomas Gleixner wrote:
> On Thu, 20 Jul 2017, Marc Zyngier wrote:
>> When developing new (and therefore buggy) interrupt related
>> code, it can sometimes be useful to inject interrupts without
>> having to rely on a device to actually generate them.
>>
>> This functionnality relies on the irqchip driver to expose
>> a irq_set_irqchip_state(IRQCHIP_STATE_PENDING) callback.
> 
> I like that, but can we please extend that to utilize the irq resend
> mechanism:
> 
> 	desc = ....;
> 
> 	chip_bus_lock(desc);
>         raw_spin_lock_irq(&desc->lock);
> 
> 	if (has_set_state(desc))
> 		set_state(desc);
> 	else
> 		check_irq_resend(desc);
> 
> or something to that effect?
Definitely. That'd allow more HW to be supported. I'll have a look.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...