From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f72.google.com (mail-dl1-f72.google.com [74.125.82.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEC5E44BCA1 for ; Wed, 23 Sep 2026 07:14:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.72 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790147661; cv=none; b=Ihy9frWuM3mVfj74BA8UH43rh1GAvUgcQ5D3K0UiB3VFzlImVV9uBPahluTq/yu+3nl7opBaB+Khy6jm2RNe/D4Uz4dv1GDHHB/EAyQUl03xEsp36+PsXzLwUiler1kBnHEqYkUDd/0dFx0IW0i8yN7YYAqTWVlEIBgq6L1HXeY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790147661; c=relaxed/simple; bh=EiRm2DH268TnCKvfI9DUZ7whv7X6RJy/wJDSopSl0ss=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=daMue/st3BBrQ0wOO6FbJWAmqm4lfR4T1wgqsfFNQ9+Qh1qzWDGcYL6MQW2K6759nP9iKgpPiRV+Wef0jp31Co5p8GdjLddrp8NcRvcCdrw6q7OKBbcTXYzRBTUvBOFIeTr/gxxBdTTYoEkteDk/8aqYC+297t8iAjPV4c0dd7w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=eyWXBcrM; arc=none smtp.client-ip=74.125.82.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="eyWXBcrM" Received: by mail-dl1-f72.google.com with SMTP id a92af1059eb24-142f4306744so1621701c88.1 for ; Wed, 23 Sep 2026 00:14:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1790147659; x=1790752459; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Yo0H4ETGVUkK9yLMjrNccVJ0N31e67zNNSIX4uaHhQk=; b=eyWXBcrMcrN71zGriDld1u5ko2VJNy9PYVPMIBoiNHouImIOZBfiJI+ozS4sp/zAq+ Bo5hHOUBwqwUtKn9NFhgC5nkFlDBKEyWka256nY6hDz4eWU8wnYucVM/6b7zzkp/UyJ8 JO1FSWqQDMPEwZP+AAGTYfEXZHUYT5mkXbBZu9jGZqZBwZ+F2eAHY49mxOWTIMeZzKAS WOBv7nytGfctbWncI04vkHZNZSbXTpPU3j+IN74tPGNMrT1KXXVNFFAIVEhyGVTOZukx PN+PSA3AHlBriUMDxxwGvSIxr5dR/O8ojc5TyMwXGmO2deuTAqyI2jIpcg0bqAlazWiy HTSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790147659; x=1790752459; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Yo0H4ETGVUkK9yLMjrNccVJ0N31e67zNNSIX4uaHhQk=; b=QqnrCriHOzoSYFNYoCQD9DEv3xyfXrtlUvfgkaJZa9U3NDQHKtIsr4FlGuOID2pnex RBTxFpgZZ88WVJTyMxUk17coIJXtrekJxHOnDx5plT384XqRyZ1lMMJe2YxfJeaC0FkW qvYUO2axwJTA1BypHGqVe5WnYDqXp2K6rYyn5FFgzJUIYhGA7TmmXALr/LbjEFONHeUS ot4EdmuaUDvSRegpE6GlkDoZOcqeBp72h02O1eAEEcoTV5U6FLycb1k4AgoOO8Jf4YcA k6MKbdmSDMV5DtWU2O3SmLaQhEmiGefoz1dFqw33hbvjeIAuD0uRWai8p64q/pLy3WRQ xQ3Q== X-Forwarded-Encrypted: i=1; AKwUvByrhDhsFUnoedHkjIh/ndYta1CWGrKalx+VgcMqWNv6FJ9Lujc9go/Fe8oIQrNQMBZH9kpHXOsk9DFoGH0=@vger.kernel.org X-Gm-Message-State: AFuF++lV7cVYActIebkSLaFgIEZc92pZSBLu+yCyzy7DXn0D60Ge9mN/ jAxFJfO3BOAm6BhYUjWh7bFDVy0vieJdtZlH2Pj2gX2LMEHqWJhgqvPh8E/ti3tFMWevwKXzHJS QkDwK20QS0A== X-Received: from dldyr1-n2.prod.google.com ([2002:a05:701b:4501:20b0:144:c737:6f14]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:701b:4282:10b0:144:f4a0:a399 with SMTP id a92af1059eb24-144f91685bfmr2048914c88.1.1790147658536; Wed, 23 Sep 2026 00:14:18 -0700 (PDT) Date: Wed, 23 Sep 2026 00:13:43 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: X-Mailer: git-send-email 2.56.0.rc1.315.gc6ed9934b7-goog Message-ID: <4add8796a95e7cabee2a8094d6babdb39290bfe8.1790145937.git.irogers@google.com> Subject: [PATCH v5 03/23] perf trace: Include the headers declaring pid_t, strcmp and assert From: Ian Rogers To: irogers@google.com, acme@kernel.org, howardchu95@gmail.com, namhyung@kernel.org Cc: adrian.hunter@intel.com, james.clark@linaro.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, Arnaldo Carvalho de Melo Content-Type: text/plain; charset="UTF-8" trace_augment.h uses pid_t in the augmented_syscalls__set_filter_pids() prototype and in the !HAVE_BPF_SKEL stub. bpf_trace_augment.c calls strcmp() in augmented_syscalls__find_by_title() and assert() in augmented_syscalls__create_bpf_output(), but neither pulls in the header that declares what it uses. Both happen to build today only because something else in the include chain drags , and in first, which is not guaranteed and does not hold on libcs such as musl that keep the POSIX namespaces strictly separated. Include , and explicitly. Assisted-by: Antigravity:gemini-3.1-pro Signed-off-by: Ian Rogers Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/bpf_trace_augment.c | 2 ++ tools/perf/util/trace_augment.h | 1 + 2 files changed, 3 insertions(+) diff --git a/tools/perf/util/bpf_trace_augment.c b/tools/perf/util/bpf_trace_augment.c index a9cf2a77ded1..ebb26225fb04 100644 --- a/tools/perf/util/bpf_trace_augment.c +++ b/tools/perf/util/bpf_trace_augment.c @@ -1,5 +1,7 @@ +#include #include #include +#include #include "bpf_skel/augmented_raw_syscalls.skel.h" #include "debug.h" diff --git a/tools/perf/util/trace_augment.h b/tools/perf/util/trace_augment.h index 4f729bc67753..a1cd9a5e0213 100644 --- a/tools/perf/util/trace_augment.h +++ b/tools/perf/util/trace_augment.h @@ -2,6 +2,7 @@ #define TRACE_AUGMENT_H #include +#include struct bpf_program; struct evlist; -- 2.56.0.rc1.315.gc6ed9934b7-goog