From: Joel Selvaraj <foss@joelselvaraj.com>
To: Luca Weiss <luca.weiss@fairphone.com>,
Tamura Dai <kirinode0@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Joel Selvaraj <joelselvaraj.oss@gmail.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: sdm845-shift-axolotl: Fix typo of compatible
Date: Fri, 19 Sep 2025 06:23:27 +0000 [thread overview]
Message-ID: <4ae418ec-5b84-40b5-b47f-ee2e988d7e99@joelselvaraj.com> (raw)
Hi Luca Weiss and Tamura Dai,
On 9/12/25 02:24, Luca Weiss wrote:
> Hi Tamura,
>
> On Fri Sep 12, 2025 at 9:01 AM CEST, Tamura Dai wrote:
>> The bug is a typo in the compatible string for the touchscreen node.
>> According to Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml,
>> the correct compatible is "focaltech,ft8719", but the device tree used
>> "focaltech,fts8719".
>
> +Joel
>
> I don't think this patch is really correct, in the sdm845-mainline fork
> there's a different commit which has some more changes to make the
> touchscreen work:
>
> https://gitlab.com/sdm845-mainline/linux/-/commit/2ca76ac2e046158814b043fd4e37949014930d70
Yes, this patch is not correct. My commit from the gitlab repo is the
correct one. But I personally don't have the shiftmq6 device to smoke
test before sending the patch. That's why I was hesitant to send it
upstream. I have now requested someone to confirm if the touchscreen
works with my gitlab commit. If if its all good, I will send the correct
patch later.
Regards,
Joel
next reply other threads:[~2025-09-19 6:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-19 6:23 Joel Selvaraj [this message]
2025-09-19 8:12 ` Luca Weiss
-- strict thread matches above, loose matches on Subject: below --
2025-09-12 6:15 [PATCH] " Krzysztof Kozlowski
2025-09-12 7:01 ` [PATCH v2] " Tamura Dai
2025-09-12 7:24 ` Luca Weiss
2025-09-12 7:26 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ae418ec-5b84-40b5-b47f-ee2e988d7e99@joelselvaraj.com \
--to=foss@joelselvaraj.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joelselvaraj.oss@gmail.com \
--cc=kirinode0@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®