From: Greg Ungerer <gerg@linux-m68k.org>
To: Xin Gao <gaoxin@cdjrlc.com>, geert@linux-m68k.org
Cc: linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m68k: Complete variable type
Date: Tue, 16 Aug 2022 09:37:19 +1000 [thread overview]
Message-ID: <4ae72d0b-b197-f9d8-5cbe-ce7cfaf3affc@linux-m68k.org> (raw)
In-Reply-To: <20220815194806.3487-1-gaoxin@cdjrlc.com>
On 16/8/22 05:48, Xin Gao wrote:
> Complete the variable type of line 109.
>
> Signed-off-by: Xin Gao <gaoxin@cdjrlc.com>
> ---
> arch/m68k/coldfire/m520x.c | 2 +-
> arch/m68k/q40/q40ints.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/m68k/coldfire/m520x.c b/arch/m68k/coldfire/m520x.c
> index d2f96b40aee1..dca89214bbc6 100644
> --- a/arch/m68k/coldfire/m520x.c
> +++ b/arch/m68k/coldfire/m520x.c
> @@ -106,7 +106,7 @@ static struct clk * const disable_clks[] __initconst = {
>
> static void __init m520x_clk_init(void)
> {
> - unsigned i;
> + unsigned int i;
>
> /* make sure these clocks are enabled */
> for (i = 0; i < ARRAY_SIZE(enable_clks); ++i)
> diff --git a/arch/m68k/q40/q40ints.c b/arch/m68k/q40/q40ints.c
> index 100c05544c6a..fdac8a0cb75f 100644
> --- a/arch/m68k/q40/q40ints.c
> +++ b/arch/m68k/q40/q40ints.c
> @@ -169,7 +169,7 @@ void q40_sched_init (void)
> *
> */
>
> -struct IRQ_TABLE{ unsigned int mask; int irq ;};
> +struct IRQ_TABLE{ unsigned int mask; int irq };
> #if 0
> static struct IRQ_TABLE iirqs[]={
> {Q40_IRQ_FRAME_MASK,Q40_IRQ_FRAME},
This last change doesn't match the commit message.
It should be a separate patch.
Regards
Greg
next prev parent reply other threads:[~2022-08-16 6:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 19:48 Xin Gao
2022-08-15 23:37 ` Greg Ungerer [this message]
2022-08-16 6:24 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ae72d0b-b197-f9d8-5cbe-ce7cfaf3affc@linux-m68k.org \
--to=gerg@linux-m68k.org \
--cc=gaoxin@cdjrlc.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®