mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Dong Chuanjian <chuanjian@nfschina.com>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Changbin Du <changbin.du@intel.com>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>
Cc: linux-kernel@vger.kernel.org, Kernel@nfschina.com
Subject: Re: [PATCH] scripts:modify output format
Date: Sun, 15 May 2022 22:19:16 -0700	[thread overview]
Message-ID: <4aeee9a4-e8e1-bcac-1ebb-f2b8860ba363@infradead.org> (raw)
In-Reply-To: <20220516020442.GA4277@localhost.localdomain>

Hi,

The change looks good to me, but there are a few other
"process" problems.

1. Was there a compiler warning that caused this patch?
If so, then tell us about it.

2. This is v2 of the patch. You should describe what changed
between v1 and v2 (below the first --- line).

Thanks.

On 5/15/22 19:04, Dong Chuanjian wrote:
> scripts:modify output format
> 
> Signed-off-by: Dong Chuanjian <chuanjian@nfschina.com>
> ---
>  scripts/kallsyms.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
> index 8caabddf817c..ba50993785ec 100644
> --- a/scripts/kallsyms.c
> +++ b/scripts/kallsyms.c
> @@ -498,7 +498,7 @@ static void write_src(void)
>  
>  	output_label("kallsyms_token_index");
>  	for (i = 0; i < 256; i++)
> -		printf("\t.short\t%d\n", best_idx[i]);
> +		printf("\t.short\t%u\n", best_idx[i]);
>  	printf("\n");
>  }
>  

-- 
~Randy

  reply	other threads:[~2022-05-16  5:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-16  2:04 Dong Chuanjian
2022-05-16  5:19 ` Randy Dunlap [this message]
2022-05-17  2:04   ` Dong Chuanjian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4aeee9a4-e8e1-bcac-1ebb-f2b8860ba363@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=Kernel@nfschina.com \
    --cc=changbin.du@intel.com \
    --cc=chuanjian@nfschina.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®