From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B70A238C09; Thu, 12 Jun 2025 10:54:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749725683; cv=none; b=mDsi1rMDnQplP6xT8C71CC6Ap791QKZ0ad/4OEKUVQeDIej+rg7dm9U3qcFJHcmHEkEXmOdlVipiNyBoaLi/GvSMmbdcyvti9ZwzCFHbQSeyPlM6ubtRgP4C8PemLbwi2s4h7YpDUONjB/PHj0dX8ZdDfgSe8LSEP/Mpw6Jpaxs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749725683; c=relaxed/simple; bh=ipOkFqoZaaO0FvWvQy4SEgTGfv0EjxKZ+FWyZ8Rb/VM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=R2kG92eXiTK+s4nXJz2WRHB636avfslj/EKPYlDVxwHKc8KyfDObceq09i8kRkgg1FblnHFhDVXMOdRI2H531x+iVO3SOsHwHsEeM26JaqVfASOcxsVvHXDwu84E/M4YAogDEOq/K2x8gVuq7D84vOcvvms/LvGMy609SBLCSHc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=APrOtndh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="APrOtndh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 336CEC4CEEA; Thu, 12 Jun 2025 10:54:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749725682; bh=ipOkFqoZaaO0FvWvQy4SEgTGfv0EjxKZ+FWyZ8Rb/VM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=APrOtndhFLGCGq6HJIGdnCmTqMrzFsRVbOGhcNRU/4HB09tWSpyA7maL98/cq9nOo 7DrIyU9qPpOL8MPaPjl0jbJDW8Fk6qeD7Y0hFlKAsDE1kqaA7nYoCaLUSINHdUMf1u r85TQtK8i2oIL8b3rT871kwZgzMu0b3MhTGjjcm6HkLqMfCuU+XVzV5r9zIBXN/XKM k4BnGac/CVfrukKHXFX/0kcJw870L2XugLgv6JiQjHuWv6txbqueLeJndTnd+L32FX gp7mFHRejbEWTLwGCZxA/+sURp62CYEDJGY2KpX4LYgvMXbSeJG3lustAgOGBVLugy 9qParxTZMPIYA== Message-ID: <4af27621-6d81-4316-b57a-b546c8a7ad08@kernel.org> Date: Thu, 12 Jun 2025 12:54:37 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] xdp: Remove unused events xdp_redirect_map and xdp_redirect_map_err To: =?UTF-8?Q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , Steven Rostedt , LKML , Linux trace kernel , bpf@vger.kernel.org Cc: Masami Hiramatsu , Mathieu Desnoyers , Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jakub Kicinski , John Fastabend References: <20250611155615.0c2cf61c@batman.local.home> <87bjqtb6c1.fsf@toke.dk> Content-Language: en-US From: Jesper Dangaard Brouer In-Reply-To: <87bjqtb6c1.fsf@toke.dk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 12/06/2025 12.30, Toke Høiland-Jørgensen wrote: > Steven Rostedt writes: > >> From: Steven Rostedt >> >> Each TRACE_EVENT() defined can take up around 5K of text and meta data >> regardless if they are used or not. New code is being developed that will >> warn when a tracepoint is defined but not used. >> >> The trace events xdp_redirect_map and xdp_redirect_map_err are defined but >> not used, but there's also a comment that states these are kept around for >> backward compatibility. Which is interesting because since they are not >> used, any old BPF program that expects them to exist will get incorrect >> data (no data) when they use them. It's worse than not working, it's >> silently failing. >> >> Remove them as they will soon cause warnings, or if they really need to >> stick around, then code needs to be added to use them. >> >> Signed-off-by: Steven Rostedt (Google) > > I guess that makes sense; I have no objections to getting rid of them. > > Reviewed-by: Toke Høiland-Jørgensen Make sense. Toke we have to check how XDP-tools handle when these tracepoints disappears. Acked-by: Jesper Dangaard Brouer