From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD63DC2BB1D for ; Wed, 15 Apr 2020 00:21:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 966222072D for ; Wed, 15 Apr 2020 00:21:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392381AbgDOAU7 (ORCPT ); Tue, 14 Apr 2020 20:20:59 -0400 Received: from mga05.intel.com ([192.55.52.43]:34323 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392367AbgDOAUl (ORCPT ); Tue, 14 Apr 2020 20:20:41 -0400 IronPort-SDR: RxkoZ8DNMzGpRswodU4IRJwgR6y7SnTMpaOAqP3e/+sbk1cwC3yS7zwcnearylw2Lb4u22EwKo K/1E1jEHR/9g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2020 17:20:37 -0700 IronPort-SDR: I2x/gidc78O01nNuUEiMNqDfrI3QPGn5DYslsgbkT1bBP8sz6su/QxdNckTJU9ll5nFgitewiU Nn5uE+n2yp7A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,384,1580803200"; d="scan'208";a="271568319" Received: from swwoldee-mobl1.amr.corp.intel.com (HELO [10.251.15.118]) ([10.251.15.118]) by orsmga002.jf.intel.com with ESMTP; 14 Apr 2020 17:20:36 -0700 Subject: Re: [PATCH 3/4] PCI/AER: Don't select CONFIG_PCIEAER by default To: Bjorn Helgaas , linux-pci@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Bjorn Helgaas , Russell Currey , Sam Bobroff , Oliver O'Halloran References: <20200415001244.144623-1-helgaas@kernel.org> <20200415001244.144623-4-helgaas@kernel.org> From: "Kuppuswamy, Sathyanarayanan" Message-ID: <4af2f1b4-3032-5295-0668-9230e4b9012c@linux.intel.com> Date: Tue, 14 Apr 2020 17:20:36 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200415001244.144623-4-helgaas@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 4/14/20 5:12 PM, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > PCIe Advanced Error Reporting (AER) is optional and there's no need for it > to be selected by default. > > Remove the "default y" for CONFIG_PCIEAER. Makes sense. Reviewed-by: Kuppuswamy Sathyanarayanan > > Signed-off-by: Bjorn Helgaas > Cc: Russell Currey > Cc: Sam Bobroff > Cc: Oliver O'Halloran > Cc: Kuppuswamy Sathyanarayanan > --- > drivers/pci/pcie/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pci/pcie/Kconfig b/drivers/pci/pcie/Kconfig > index 66386811cfde..9cd31331aee9 100644 > --- a/drivers/pci/pcie/Kconfig > +++ b/drivers/pci/pcie/Kconfig > @@ -25,7 +25,6 @@ config PCIEAER > bool "PCI Express Advanced Error Reporting support" > depends on PCIEPORTBUS > select RAS > - default y > help > This enables PCI Express Root Port Advanced Error Reporting > (AER) driver support. Error reporting messages sent to Root >