From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from m16.mail.126.com (m16.mail.126.com [220.197.31.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4669614A4F0 for ; Wed, 26 Nov 2025 02:12:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764123170; cv=none; b=Wbt7d7ETSrEj0RDKHMVB/Ec9XLrLyqhg3egWKpZzNH5z4/fEtIsr9H78YuQgDBZBHnR2BXTPxxD6VBYZlO+qMXR0cvpHhWzhJnu5yJLrrchOtk7uq36ADOtAL3hLsM6ptGhmSfMohUuwnkYY/VgztpPX1eDjY/7say1FHnuBzwI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764123170; c=relaxed/simple; bh=U6FvkmAJgRMDnYSdcpvVIb0XPfrW4NiQeQtXgb1BM+s=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=enGFmWQqHW87LlbfeBTNKGFQUFBeJrXS7ZqAfX8169WYfvR8w9HMeqc4tS3Z0xM7s4cchUY3GkE1nVPC7brOyXCy/KsHbePTRb4dFlaJHN6fBwGRhsXOlhTforvYy1qcO0ijJCFzQew59wE7gRqMLd3ZOm8K0L1ItvfkRPOLtJA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=126.com; spf=pass smtp.mailfrom=126.com; dkim=pass (1024-bit key) header.d=126.com header.i=@126.com header.b=inU1RCY0; arc=none smtp.client-ip=220.197.31.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=126.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=126.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=126.com header.i=@126.com header.b="inU1RCY0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=Message-ID:Date:MIME-Version:Subject:From:To: Content-Type; bh=hrfYMegmoi3Ze7BkL1gxmL89yt/xLdy/j2GEGvb1I+E=; b=inU1RCY09Yd8z2ku8LbLz9mPT0Dz9CbhNWFi9mFx0jf9gYyqBSuHU/XdJMQlU0 8tAzrpD6poepeTUs10H5nLmATXtodYA/QYtJGR0g3AHVl/E/HSOnHlE1ZPfTOzC1 ECsxQ+q22BkELMCRsa7UtQy9dBsi3dUxFkeP+dq1ykp5E= Received: from [172.24.148.100] (unknown []) by gzga-smtp-mtada-g0-3 (Coremail) with SMTP id _____wDnHzd0XyZp+QkcAg--.9704S2; Wed, 26 Nov 2025 10:01:25 +0800 (CST) Message-ID: <4af61dbb-ab24-4f5a-8bc7-2dce3cbdc2cb@126.com> Date: Wed, 26 Nov 2025 10:01:24 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] sched/stats: correct the wait_start calculation logic From: Honglei Wang To: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com Cc: linux-kernel@vger.kernel.org References: <20251113124326.27588-1-jameshongleiwang@126.com> Content-Language: en-US In-Reply-To: <20251113124326.27588-1-jameshongleiwang@126.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CM-TRANSID:_____wDnHzd0XyZp+QkcAg--.9704S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7GrWxXry8Ww4DKF1rKw47twb_yoWDAFg_ta yYvF1jkryUtrZ5tF18Gw4xJ3sYyw4DtF4kAa4kAF1UAFy5JrZ8Jas8W3W5WrnFgrnagFy7 Grn3ZF95K3ZFvjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUjc4S7UUUUU== X-CM-SenderInfo: 5mdpv2pkrqwzphlzt0bj6rjloofrz/1tbirwgSrWkmWl97fwAAsW Gentle ping on this one submitted a couple of weeks earlier. Is it worthy of being picked? Thanks, Honglei On 11/13/25 8:43 PM, Honglei Wang wrote: > It's not necessary to do the delta-related subtraction if the task > is not on rq migrating. Add the migrating related judgment back. > > Signed-off-by: Honglei Wang > --- > kernel/sched/stats.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/kernel/sched/stats.c b/kernel/sched/stats.c > index d1c9429a4ac5..60560fb31e63 100644 > --- a/kernel/sched/stats.c > +++ b/kernel/sched/stats.c > @@ -12,7 +12,8 @@ void __update_stats_wait_start(struct rq *rq, struct task_struct *p, > wait_start = rq_clock(rq); > prev_wait_start = schedstat_val(stats->wait_start); > > - if (p && likely(wait_start > prev_wait_start)) > + if (p && task_on_rq_migrating(p) && > + likely(wait_start > prev_wait_start)) > wait_start -= prev_wait_start; > > __schedstat_set(stats->wait_start, wait_start);