From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751327AbdJBLwH (ORCPT ); Mon, 2 Oct 2017 07:52:07 -0400 Received: from mail-sn1nam01on0067.outbound.protection.outlook.com ([104.47.32.67]:29847 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750986AbdJBLwF (ORCPT ); Mon, 2 Oct 2017 07:52:05 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Jonathan Corbet , Tom Lendacky , x86@kernel.org Subject: Re: [Part2 PATCH v4 01/29] Documentation/virtual/kvm: Add AMD Secure Encrypted Virtualization (SEV) To: Borislav Petkov References: <20170919204627.3875-1-brijesh.singh@amd.com> <20170919204627.3875-2-brijesh.singh@amd.com> <20170929065416.ow55bzvaqf5unxjn@pd.tnic> From: Brijesh Singh Message-ID: <4af7b73c-2ed0-9787-c07c-6a577c4c3c04@amd.com> Date: Mon, 2 Oct 2017 06:52:01 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170929065416.ow55bzvaqf5unxjn@pd.tnic> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [70.112.153.56] X-ClientProxiedBy: DM5PR12CA0058.namprd12.prod.outlook.com (2603:10b6:3:103::20) To DM2PR12MB0156.namprd12.prod.outlook.com (2a01:111:e400:50ce::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d7c0eba1-fc14-4cb5-31e8-08d5098bff41 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:DM2PR12MB0156; X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0156;3:4imIIvexkVek/lgcj5dexNfPyeVjo/lZsLEr32YeMUsMuv7vyPi6/mUjR+Drv2nwfypk5itB5ziY2G3b0BOTmSDjcTp5nQTt1n9+ofPIgjXbROegWm7wSkuMFeiipfuG+py+sqnJwPsX2GSSRWxcmJA+VSco0VEZv3R1hg8qzI3qFB0Bjdt22dm+CI5mHrS+46I4sXGoSIvLTzAc8pBmKKaZJHUIJPZaOBBC+wtDX9LoQaFv8KUXNfpic8dpEUBH;25:UrxmSbSG/nVUPUdxNAb4cU5gwN9WSbTRtONpmTQOavfEVaYbIiuZw52IGQCHEvKcWiRWf1cPPRnA+UoIXBOCtJsqYZ5I0GjXdkO6sgsFYwE4xS94PZNTzh0ze7GkneU8+T83o+lg4UhOgw+zhR/SPygrKK3K12nZre3bcrqEm5ViYlG6dlI4vLu0ralvG7TlT4NYs35C7savMhORXpT9x/rL1+cAcj2u6d6pPPJcVH/O7/oUk3VihHywENWBEmRuFWYjOB5rKlmy5dpYLG/AhQCf/imyjfsRIMLA+J/bYc9tml285pCyaors+93ccN/HXNc9TVcUkxm/DQ79jyAxuQ==;31:/6bp3NtCxXOiOLMMD9BUzTsWEVx7weCqHRZS4MHY/JjRrad+QkyeLBB7zpKGuSuHiw51LLuX277bfNF1lZJW+bNbIUbMnm1hyz8N04txJ0/xJGevBt42vz3l/A9hpTAB3LlxtjsyMq3hXu5QAovr+Q04nZtbGjbuO0JMJZrVqvtWm9XhVftm1DyGRJv4g5yEgQCKC7h7jcomjshghFcUIoFU6i6scOP7Ydyt9KIFwwg= X-MS-TrafficTypeDiagnostic: DM2PR12MB0156: X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0156;20:OC6rFpVsZigMzgQX0mIv5i0wLHwKYUP1R2TQ9Pf9E+1kk5SXMEizDI0QL9CBn7IkNE4xtNuHvIaWd5H3SCCbX/QXP5aykVKnvF6u02dmD3ewOUS9CzoiAdR/CsXLmeanNzjPnQ8Qn8Z77TTVGBiBNiVk9T9cj2KhIoo/lm0Q25yZ+CSv7KYpgxkgTLJ6/2rQdHA2lavEJP2N9fI+davl50Kf8TwAneSoQX0/8wzS+1ZS8cw2TX+9s7KemBUzYc4uqJ0eKQ2KKC9bpQTdAH93Fi8ih3DkksGzqhCNQcH/AdQVYKOdtbTZDQNB4zrlaw5Ke5Va6BICViQJkNlHrqKKeWCmgmy6WRCWrWYn7yM2+ynVbDxEWUlpc4/K+sjykVC/TaNHLMya+h9iv1vc29W6PfuMSoVDFmbkN+BdDrx0DySH7dDbgsJaWwN12qRyzETPSTmae4fFYcPtkDA7rC9o7F8jve6B3gpA652pRH5H84tC6RbQFiBm1c+x0N1TQrPo;4:R1kgbvkryOuN3wKlRU8NKboiMh0W4aJ60VrLPf3V0fZ4/+KF67ccT+4sm4haiW13BxunYSv5vbBf2F6+2EckmYGNthUQbLH7m5+zfdVEGC6E4N+LmAbOsCNIkUEQXiFUG2xI52IBPU5Mrm5wIzlL6Lv2fJRFl29SqAidITsWtitu3M3v90rDBvWv2uCHTaftMtydSVmsSX9pnaW2Y6+Nk0sLWcdN5K2vjVURtuMCCfgo33kYO8hvarwPJsBrkSJH X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(20161123562025)(20161123558100)(20161123560025)(20161123555025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM2PR12MB0156;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM2PR12MB0156; X-Forefront-PRVS: 0448A97BF2 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(979002)(6009001)(376002)(346002)(39860400002)(189002)(24454002)(199003)(377454003)(316002)(97736004)(305945005)(7736002)(86362001)(50466002)(31686004)(81166006)(81156014)(16526017)(65826007)(2950100002)(8676002)(6916009)(3846002)(5660300001)(23676002)(58126008)(2906002)(64126003)(54906003)(2870700001)(31696002)(53546010)(68736007)(6116002)(66066001)(966005)(36756003)(6306002)(189998001)(345774005)(65806001)(65956001)(47776003)(478600001)(33646002)(25786009)(105586002)(229853002)(106356001)(4326008)(6486002)(76176999)(54356999)(101416001)(83506001)(50986999)(7416002)(53936002)(6512007)(6506006)(6246003)(8936002)(6606295002)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR12MB0156;H:Brijeshs-MacBook-Pro.local;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTJQUjEyTUIwMTU2OzIzOk9pZ0htY3FZcTRJZ1crUlhCclNLY29VN0hM?= =?utf-8?B?eGVvNG1DU3grc3VodFQvdElXREoxN05aWmdQOVFzYngxVTYyWStDaStDR2kr?= =?utf-8?B?ZFpROXVoOHFZWGd0V3FZVGRJcGJpODlUQmlQYWJuT1h2QWh1NkVKaWo1cyth?= =?utf-8?B?ams5SnlZejZXS3pDNEJ2SmdVZVFVRlJMbjlQT2ppN0RiZ2lYK2tnYzgxckRH?= =?utf-8?B?Q2ExMEhTQ2RSVkhzNVJLVTJUc1FSSUdxTjdna1Jld2FXVGFQaHJxTXc4aDRa?= =?utf-8?B?U1BmaDMvQXE5aldjOXVORUE2ZEdqUWJ1VlM5VHBka09xOTFPNHFDT0pZSlZs?= =?utf-8?B?UENPZExSdUZPTWQvU2wzMk9JeWsvMmNxMXVlSXpDcmM3bHg0a0ZlZWM0V3Nv?= =?utf-8?B?ZHdwQWtOL2tGeWlsNTlMcUYvUU1VOHRHbGJGQVZLcE5WL1U3M2c0dk4wMUta?= =?utf-8?B?MDVDZGZDMmYwWU15VjlSYVNhWlFCdmZYRnR3NUcxVktNRjdjS1NsM2g2aUdH?= =?utf-8?B?QWxKSS8reWVydkd5eE1LMEtoL25LNWFaU09YTlY0UkxkbVdpQi9DSlQ0QjNU?= =?utf-8?B?SUUveTh3dFE2YWVvVzk5ZlU2c3RYY0FpK01VeU9MVXhVdzVXdDMxZ1NPbFVG?= =?utf-8?B?UDhZTVNSUlBTbEVDTUJWSWpaZ0ZHeHg2NXViRzR4L1JkTW9vOWtLSkF5Tmh2?= =?utf-8?B?c3oyRWJHK2YxTjNCQjlDNWduT2hleDd5T00xUS9qMmc1SkIzeXBSS1hCVGMw?= =?utf-8?B?dXc2TGZFYVozVENUR1JFMFdDNEhsWmYyQkF1RVhQNW5JblQ5VC8wT1RmbEVJ?= =?utf-8?B?aFo4V2JZeGRIOHh2eEVIRXVhaTdvbXJnRDZsNit6Wi85Lzh3MndYTFV3TmtF?= =?utf-8?B?TU0zeTl0VnZsMHV1YzJmaEsxKzB6K2VFYUJqQ28zOVRzbmUvc29lNjNadzhy?= =?utf-8?B?ZHhWVzRWTzFpaFNYUFNWRmRWcXJlZXpySlVvYit0a2FLZ0NRRUptaTlYaHFz?= =?utf-8?B?bU1mQ3l3KzFIUUlpQXdoZnZSby8zNU1NMTRlZzd5SDl6a2pwcEozOHh0TVk4?= =?utf-8?B?WVozUGpsSUVLOUhJZm9UZ3NqVVE3Tk91VS9MMjlXNWEzNmFQdlcvb3BxeW9B?= =?utf-8?B?QkRxSHBVeVJDcmpiZUVUNU55QnMyeVdkWk5DQW5yem4rZ0pOUkg4SytvZmFH?= =?utf-8?B?dTZ2NjNENFliWDduWGkrUkhTRjFIMjlrQnk4aG1xamsweXh4U2dnK2MrbUlC?= =?utf-8?B?VUpDUG4rYjZaQnBVZGhVaEFOaVAyQk83aWxmeFNiNG95bVNiVm9IZjZGS3Ey?= =?utf-8?B?czQyS1ZlT1RlRXFhLzBoY21KNkVWM2QwTWZqZDZEOXdWc1ozeXFFb05XNHRa?= =?utf-8?B?QkEwbUJJSEpwWGtMVkVVSG5xN1B5cktlei9taHQ3THJVRnlKZ201ZGlud0w5?= =?utf-8?B?VlNickIzNkk2WnFLMk1xVlphVXFwdzlxZnBvT1J0cXFCczUwK29iYUZldWFP?= =?utf-8?B?bjlWbkMrS0RqRnNHMzBRQUFZMitaKzBYRjR6dUoyTWpPcTNRbGpKZVRVdldT?= =?utf-8?B?ZVdkNVM5ajRDamVTU2ZDU2VWcHBZdUo1QmFMWWUwU3JhMEtoVnBRZUR3anpo?= =?utf-8?B?N3RkQVdzdmN6bG9qNmVFbmFJZ1lGcURLSDFPT3VFQTdyWko5QUFUR2JPUXRy?= =?utf-8?B?a3RIR2NhZENGYlhINzdIalpvc0pxZlFMeFl4RVpuR1QzTHJnTGVyMlNHWVNO?= =?utf-8?B?Wit5dWg2ZGxyNG5xTmwxamUxQlBaWlhVTDZveFJpbW1PVHM4RGNyZ1ROQ0Fu?= =?utf-8?B?aVdUaWdsR25UQml3VDhiQ3g2eE8rZENoWTNrWkZUd0ZyUmNQWUY0bml5TUxY?= =?utf-8?B?bEhKOStHR1c3aUFPWUNTenZKWmRDUjR5SlRYRTBFZHEvN2ppSHdOS2d5WXNB?= =?utf-8?B?Z1dsSmllaW1vTUZXTTk5THlJd2E2dGJBOWJDd2p2MUlqd2VweVk4ekRlTWh6?= =?utf-8?B?UkpmYXZxTWN0RUkxK3FDeVZiVWoxdmxvbkI5dWIvcDRybmZBTjVicSs4cXo0?= =?utf-8?B?Y1pidS9GTHZ6TGpHTHNBYlNJR0FGSlZSU0RxenZwb1B3VzE0WHM4cmV5Z1Jy?= =?utf-8?B?UGc9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0156;6:KPtJC20uOewE5er1Dj4TqLYqcV2yFz7OkLsECSbvdSzLBm/aGJmpwDls1lLUxd+BhZfW+UTob2B57hcj40GQy28T7diVXmdDpEr+vuHAKdORoX1NMxLLTulHDSUCY/A2AvWrmhxLnkUU9f87bYu8rja7xf8xkcR4ZzaOKETY+WvMzZXJc1DbLlMkRLj/JWllZ9eb2Zj31pKU5AD4qzVQCLA2HdulQ3iWGxbzKQJb5nxCFwceSAQTXBh/Uw5cp9KGf6Jq33qMEGEZKt437gjqbo+tPnIX3Ph4yIPoP/satlHJkvsiCNoRTuSeVMQIyV0aE15mPRyRhfdiQ2V7bM5u7w==;5:/vNxpSwOIrvgd9MMCb1O2xFHfyrS4R36BUqo9T5sr+bPtNz5WTrK3B4H7PofxAVRJLPZ1QJSpFWLyHy79LKs16eQIq2C+Gs7r8ITYo5+uQ0efq2rdt56y9zsz66kzmI/y+u86WYYWs3lhEN1HauesB9SbWZv6Lv4ZDEH6dq+cCY=;24:1OSGXdbgtRr2hO3kmsSOuxSuGUgQfH4rSh6vrP5OdRZ+tCgisnw/pCWxlMSHVKLJzLEK4iZf2RBclkgFWSSMA9K7fHbLkGXSQbwB+7jS29U=;7:MxUQKgEd5EnLMnt3O649eSYIEfWnWZ1FihUENIq21tomXsrdrTTxQShQr1HizKYswuvQCtq6QtGgpiuuLCBFHHJG4edW3RRP5D6UFZrWa4x4+bg4WeuG+//Sq71LrWMR1fYbLBhQ0sb/takViQHH/yS6qNMKP0eaMC7+gG/A8eXTqwaTs72tZpaU4o8X3QVJ4VZELOmUOr7yTyxvjKW3Xnp7hAXvGq1PUd4gkmZEhOA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM2PR12MB0156;20:CHuUpDJCKkikVP3tVDbngOuWgB0Hx2YLAN+9EYNhlZ3OuxHa398Bymkk1jHaNuDw5H/d7/Kq1blDyzyjIOfh6B+nvIJdUIMBNdlglPThXYOYnW1F3kRRgSHAbtIK+eejAsL47hY6JcFvf3rkQDTUg5Hj7xtQ0Jw42ts4F1HLPCCF4dAd12j77gSauAUnrfNQGut99eLKjnxHtH2nsYHSj8J0DFyKYg1tyq8r6Zt3Ef/bgDqnyg3MlkxbvkfDHVLD X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2017 11:52:02.4266 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR12MB0156 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/29/17 1:54 AM, Borislav Petkov wrote: --- >> Documentation/virtual/kvm/00-INDEX | 3 + >> .../virtual/kvm/amd-memory-encryption.txt | 210 +++++++++++++++++++++ >> 2 files changed, 213 insertions(+) >> create mode 100644 Documentation/virtual/kvm/amd-memory-encryption.txt > Here's a diff which applies ontop of this one, it moves the KVM_SEV_* > commands to Documentation/virtual/kvm/api.txt where they're all together > in one place for obvious advantages. Thank you for the patch. One of feedback in RFC patches was to put the command id and their definitions in amd-memory-encryption.txt hence I was trying to follow that recommendation. Most of ioctls I have seen in api.txt are either common or architecture specific. These commands are vendor specific and I was not sure if they belong to api.txt. I am okay with moving the definition to api.txt in next patch and we can see if kvm folks have any objections. Are you okay if I move the command id definition documentation later in the patch -- basically include it as part of  'KVM: Define SEV key management command id' [1] [1] https://marc.info/?l=kvm&m=150585445223846&w=2 > Also I did some small cleanups while at it. > Notable is that the commands are a smaller number now and > KVM_SEV_RECEIVE_UPDATE_DATA, KVM_SEV_RECEIVE_START and a couple more are > missing. > > On purpose? The series does not implement the migration commands yet hence I took it off.