From: liubaolin <liubaolin12138@163.com>
To: Namjae Jeon <linkinjeon@kernel.org>
Cc: hyc.lee@gmail.com, ntfs@lists.linux.dev,
linux-kernel@vger.kernel.org, chenxiaosong@chenxiaosong.com,
Baolin Liu <liubaolin@kylinos.cn>
Subject: Re: [PATCH v2 02/10] ntfs: validate EA chains and link zero-terminated tails
Date: Mon, 21 Sep 2026 18:34:40 +0800 [thread overview]
Message-ID: <4afe1b4d-7fbf-4fb6-866e-71bff3bbea6f@163.com> (raw)
In-Reply-To: <CAKYAXd80AqEnzUvad2Od8fLh4yh20X8G7CVN1EcQCg1Vj1iJQw@mail.gmail.com>
在 2026/9/21 14:17, Namjae Jeon 写道:
> On Sun, Sep 20, 2026 at 5:31 PM Baolin Liu <liubaolin12138@163.com> wrote:
>>
>> From: Baolin Liu <liubaolin@kylinos.cn>
>>
>> A zero next-entry offset terminates an EA list. Appending an entry
>> without linking the old tail makes the new entry unreachable. Invalid
>> entries are also treated as missing names, allowing setters to proceed
>> on corrupt metadata.
>>
>> Validate the entire chain before modifying it and connect a zero tail
>> to the append position. Check name terminators and retain the full tail
>> span when removing an entry. Return EUCLEAN for malformed EA structures
>> and inconsistent information lengths, preserving that error through the
>> get and set paths. Keep ENOENT for a missing name and translate it to
>> ENODATA only at the xattr read boundary. Preserve lower-level read errors.
> Could ntfs_listxattr() reuse the same chain validation and return
> -EUCLEAN for malformed EA structures? And you can send only this patch
> for v3.
> Thanks.
Hi Namjae,
Thanks for your feedback. I've updated ntfs_listxattr() to reuse the
full-chain validation and return -EUCLEAN for malformed EA
structures,while preserving lower-level read errors.
I've submitted only this revised patch as v3, as requested. I
verified that patches 3-10 of v2 still apply cleanly without
modification, and completed build checks and QEMU tests covering normal
and malformed EA lists.
Please see:
"[PATCH v3 02/10] ntfs: validate EA chains and link zero-terminated
tails"
Thanks,
Baolin.
next prev parent reply other threads:[~2026-09-21 10:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-20 8:31 [PATCH v2 00/10] ntfs: persist Linux file attributes in an EA Baolin Liu
2026-09-20 8:31 ` [PATCH v2 01/10] ntfs: keep the EA presence flag after creating the first entry Baolin Liu
2026-09-20 8:31 ` [PATCH v2 02/10] ntfs: validate EA chains and link zero-terminated tails Baolin Liu
2026-09-21 6:17 ` Namjae Jeon
2026-09-21 10:34 ` liubaolin [this message]
2026-09-20 8:31 ` [PATCH v2 03/10] ntfs: propagate EA write and truncate errors Baolin Liu
2026-09-20 8:31 ` [PATCH v2 04/10] ntfs: preserve EA attribute lookup errors Baolin Liu
2026-09-20 8:31 ` [PATCH v2 05/10] ntfs: distinguish empty EA values from removal Baolin Liu
2026-09-20 8:31 ` [PATCH v2 06/10] ntfs: restore EA attributes when an update fails Baolin Liu
2026-09-20 8:31 ` [PATCH v2 07/10] ntfs: add fileattr query support Baolin Liu
2026-09-20 8:31 ` [PATCH v2 08/10] ntfs: persist immutable in the $LXFLAGS EA Baolin Liu
2026-09-22 1:21 ` Hyunchul Lee
2026-09-22 3:26 ` liubaolin
2026-09-22 5:25 ` Hyunchul Lee
2026-09-22 6:02 ` liubaolin
2026-09-20 8:31 ` [PATCH v2 09/10] ntfs: persist append-only " Baolin Liu
2026-09-20 8:31 ` [PATCH v2 10/10] ntfs: persist nodump " Baolin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4afe1b4d-7fbf-4fb6-866e-71bff3bbea6f@163.com \
--to=liubaolin12138@163.com \
--cc=chenxiaosong@chenxiaosong.com \
--cc=hyc.lee@gmail.com \
--cc=linkinjeon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liubaolin@kylinos.cn \
--cc=ntfs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®