From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EEE6C43441 for ; Tue, 13 Nov 2018 00:15:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 541062250E for ; Tue, 13 Nov 2018 00:15:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 541062250E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730476AbeKMKK5 (ORCPT ); Tue, 13 Nov 2018 05:10:57 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:15089 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725991AbeKMKK5 (ORCPT ); Tue, 13 Nov 2018 05:10:57 -0500 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id C0FDD3D90D4E9; Tue, 13 Nov 2018 08:15:24 +0800 (CST) Received: from [10.151.23.176] (10.151.23.176) by smtp.huawei.com (10.3.19.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 13 Nov 2018 08:15:19 +0800 Subject: Re: [PATCH 1/3] staging: erofs: unzip_vle.c: Replace comparison to NULL. To: Cristian Sicilia CC: Chao Yu , Greg Kroah-Hartman , , , References: <1542055439-24444-1-git-send-email-sicilia.cristian@gmail.com> <1542055439-24444-2-git-send-email-sicilia.cristian@gmail.com> From: Gao Xiang Message-ID: <4afeb152-b205-792f-8289-95d1fddb19ef@huawei.com> Date: Tue, 13 Nov 2018 08:15:14 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <1542055439-24444-2-git-send-email-sicilia.cristian@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.151.23.176] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Cristian, On 2018/11/13 4:43, Cristian Sicilia wrote: > Replace equal to NULL with logic unary operator, > and removing not equal to NULL comparison. > > Signed-off-by: Cristian Sicilia Indeed, I have several pending changes for this file... But these coding style fixes looks good to me. I will rebase them on your work... Reviewed-by: Gao Xiang Thanks, Gao Xiang