From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A467385519 for ; Mon, 25 May 2026 13:35:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779716129; cv=none; b=ryMb+kQ+MVrvif68jv8Gx2VDCag65fSiDymiIPYQXSQZ8sEvY7Kq8zAdRTJdLZMHNzIFROKQNwkY6clMvE5ypJI5DeB1wggVJtngqfrOgNemdHSThJvWGijDDd4ajoUTIvRQH/dn6OE7XdH1flbvxPTulG9PpFONx7wrBPRYcqM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779716129; c=relaxed/simple; bh=ITfBPysZvQqB7wtH0cju2S9jTfTV8R5uIRWoqG9MZeA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cRPajVT8HyXh87viLis5PonDqZf8rTOaREZ8hZB8ZM9azVEaaIg7mJlXiOsn5zP5vb4ymtYR+rKoTg/sm0UMVxIscjx5pxftoVSYGwku7KbfkjAB6KHHw2NHS4XtAd9ZgIWJhPgtL+jpuRXnyk6zrFPObcUfvOfXv7ztFB3HuAY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ArMoF0E0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=HWY+b9Sl; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ArMoF0E0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="HWY+b9Sl" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64PBPWTD3263573 for ; Mon, 25 May 2026 13:35:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= ZNLxbtGJrP9x6ELJiMrV9m0Y5RYj50NF/BQj9YA7V10=; b=ArMoF0E0Zh4o/UjO yx+pVe07APozjE7Bu2qU7ZstTsKjacKHrR3r4anw3+137NN/5zxTJD8VoHvy+3nh dSXPZLcRoLu2s65JmVtseYDTrnFnhdFfKxR56n4RZn5vEnOCDE1zzcOrgDZHv+fq GK4NU8mXCl9U0MAdqYPLLFJ8pMWN6obtNkttEtaMyqHTs3UVru8gGOEyZOi48khI amPkpzTwsi+kRjrfL43j2NkMQCl3uH8NtvIPXArmLmgfgHadHOr7IbjPZvCRetBs B8q35YLL+0W7RTShImHf7NvChqS2wQIW99Jt/uvxwMk4CgVYozLotLooD3C/sljO bxfxrw== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ecnhs0dx4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 25 May 2026 13:35:27 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50f13da9684so118121561cf.3 for ; Mon, 25 May 2026 06:35:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779716127; x=1780320927; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZNLxbtGJrP9x6ELJiMrV9m0Y5RYj50NF/BQj9YA7V10=; b=HWY+b9SlVBkmjA1vmk/EW7hIzj7ZJWTrnzuCwfugRIzxasbtLHZpeo4GpZPYPT1PNM xZbbXYipDyzXb+T21zKzDq7LFGI0brMed4NW+4ZKCBf5akVQRWBNkfz93tTM+eaa8u9Y rzk3yYI9LKvuF3w9kPAYOtPIntduGMucViVbWiYYsp1VcY+oZRe+zax3pXNzFqXKUZi/ poLWCxp2CljLIvDQr5gtfoMt/aljNg91EFouuIdUT3uEB3dnjb4It35G6sWRu0PZijEq GEcL16lQ5HmL7L8Q6bOyUW8sWPiU4n3d/9D2kjHOumOQBFxwIquYUKz5o5e11a1FXWlV 43mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779716127; x=1780320927; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZNLxbtGJrP9x6ELJiMrV9m0Y5RYj50NF/BQj9YA7V10=; b=aF38QKPqOTsRvu7F9U5Zk4KFI1iBsBa4YB59g5wN4DWu1rhPmcMAqsJfOgkaQlAmxp N8DB6eTjTv+vOEfr9Ho5v+0UpUQ1wsWXgfL7ZTs92oU0ADyGx5tECsYEiJAvrubLfo9N vzVasVbq5tnQB6rmLW92nrSoJypF+nnsWZFUkJZKhwmc7a65SIDXvvkTd38PWjJ9ueUX J+sQy0v6b6NswW9x8EJoudMIFp3O3MnmtM9cvFNLuUO0eR/mKDI/VwpXm7nlETd1nQei sh1ct+Lh8tRk/QhsT89Z2qyLHKF0LVBgNWtzm9xs9Qt3LEMIDPKjab/ntpq/PVuOJizq GgAQ== X-Forwarded-Encrypted: i=1; AFNElJ+OHqTQswbkoytLsJ1cUrb9aa4U8WHSvmWMaqCJ5esQMyjEeDCP6Pjna3od8C1i0VLp026M34q3Lb5noTE=@vger.kernel.org X-Gm-Message-State: AOJu0Yyiqc4bZB26X6t9QCf22O1XmxdrZvnigsnhDoQtBoV2RmWNASRW q6OmDFHXV6Bu5BkPFtmPI3dYemIRzXhWATZzQRbyv2hrfjB2qhRhLh8hEJlLfNi6R473QW1rVeA gDDLerroa1kvkBEb9bSQFCmLNh24m3juAbWx9ud8pXEl58nlLThu1XNm1XJBpScbjC6g= X-Gm-Gg: Acq92OHPJp69f6WjwMg7LTIdjoi14Nc8c8li6OUAO6Dc3Oop0OtRIMr5tRGnl+yL0HI tH9/pRuaIqRRbDwdHAmPoPVA9RA3Oh94GiKXnIvIqUPrpLR+Y5/djeAHN25G2phd/X/eWm+az07 9M4kPjgJ4MsRpvzQM9wQE6reOXiuS/tpsQ6UawerMH7MImL5wt0WIVYxfeX7hk2V6sJI0hkAix4 Esw4PvjaAMDaCqTJyBhKmu5R6zaN04Awo578jZQ+de6Q16UCYVhYXQ+0MIizQJY1aRsjwDSRUO1 czM4q8w/uZvIITVHJTJtPYCnx3W6LZD8QAigC/Ujjg8aj4f6KCOFeXX9t9U9VPT7O7TzY2tPJ6G tvWNfr/Ztv0HLjYlyJb+094CYPJI/rpm0F2Hbi5xHPBM= X-Received: by 2002:ac8:7d45:0:b0:50d:cd5a:577b with SMTP id d75a77b69052e-516d436a31cmr178465691cf.35.1779716126597; Mon, 25 May 2026 06:35:26 -0700 (PDT) X-Received: by 2002:ac8:7d45:0:b0:50d:cd5a:577b with SMTP id d75a77b69052e-516d436a31cmr178465131cf.35.1779716126048; Mon, 25 May 2026 06:35:26 -0700 (PDT) Received: from [10.236.54.193] ([88.128.88.68]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45eb6cd151asm26639898f8f.13.2026.05.25.06.35.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 May 2026 06:35:25 -0700 (PDT) Message-ID: <4afff193-8d2d-45b3-b8b6-0334e1f8921a@oss.qualcomm.com> Date: Mon, 25 May 2026 15:35:22 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 03/10] drm/msm/dp: Read DPCD and sink count in bridge detect() To: Konrad Dybcio , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Kuogee Hsieh , Yongxing Mou Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jessica Zhang , Val Packett References: <20260524-hpd-refactor-v6-0-cf3ab488dd7b@oss.qualcomm.com> <20260524-hpd-refactor-v6-3-cf3ab488dd7b@oss.qualcomm.com> <00ee4b34-7f71-4448-806b-65bd62ebe574@oss.qualcomm.com> Content-Language: en-US From: Dmitry Baryshkov In-Reply-To: <00ee4b34-7f71-4448-806b-65bd62ebe574@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Vd3H+lp9 c=1 sm=1 tr=0 ts=6a14501f cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=REkWmwYpG64U3YBEcLtx5Q==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=fzl85mFQbXLh34uAWx0A:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: V24YJMuTG4nw0_wjhGpmJ7X1ec9d-tzk X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI1MDEzOCBTYWx0ZWRfX8vWqFz6nSdB8 FD6RpKNEt4g8FoFhEqb+P3ykKbgCECYBV5m5+pG/v/nekLiQvJnhwg4J+3xXwHe51VvTw0gMVPg ZF7u21xIkNqnGyQ0htH5ZwKr7DB+eAenAvtG8e7aOL52uiBKnfM11OSq/DCXDEEjm0/fUbHOUtL 3hK73C/26CI+PMtB+/7D9KIr4apU9mYWZdgZzUEiSb4K5UV+g9GW2ijTazbZyFIEihgd3DiXGd0 b4cQ+qmRaTIEFf5dXAIwvL9ah9t1MO2keGVQ854ytdx2pNTQGQfIV/gtDkJR6i0L8anbXqxZN2m uj2RRygqMQzhDEqMgAexoMCrrhKdWM5/1T+gZyKgzRAypOhvYTP32r2+YsRivGfw9yVO+HT70Aw dHw4TygbBfkrf+3ekf1o9YY8MvS484IJ8npVlBnoEFdTbCQ2HbL8ODCFNNv+t1eqzGAVFNyui9V k0tD7a5RL8ksHaHxCgw== X-Proofpoint-ORIG-GUID: V24YJMuTG4nw0_wjhGpmJ7X1ec9d-tzk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-25_04,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 malwarescore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 adultscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605250138 On 25/05/2026 15:32, Konrad Dybcio wrote: > On 5/24/26 12:33 PM, Dmitry Baryshkov wrote: >> From: Jessica Zhang >> >> Instead of relying on the link_ready flag to specify if DP is connected, >> read the DPCD bits and get the sink count to accurately detect if DP is >> connected. >> >> Signed-off-by: Jessica Zhang >> Tested-by: Val Packett # x1e80100-dell-latitude-7455 >> Tested-by: Yongxing Mou # Hamoa IOT EVK, QCS8300 Ride >> Signed-off-by: Dmitry Baryshkov >> --- >> drivers/gpu/drm/msm/dp/dp_display.c | 63 +++++++++++++++++++++++++++++++++++++ >> drivers/gpu/drm/msm/dp/dp_drm.c | 20 ------------ >> drivers/gpu/drm/msm/dp/dp_drm.h | 2 ++ >> 3 files changed, 65 insertions(+), 20 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c >> index 1dd168acbbc3..97c4752005c0 100644 >> --- a/drivers/gpu/drm/msm/dp/dp_display.c >> +++ b/drivers/gpu/drm/msm/dp/dp_display.c >> @@ -1152,6 +1152,69 @@ static int msm_dp_hpd_event_thread_start(struct msm_dp_display_private *msm_dp_p >> return 0; >> } >> >> +/** >> + * msm_dp_bridge_detect - callback to determine if connector is connected >> + * >> + * @bridge: Pointer to drm bridge structure >> + * @connector: Pointer to drm connector structure >> + * >> + * Returns: where there is a display connected to the DPTX (returning > > whether? yep > > Otherwise, if keeping msm_dp_aux_enable_xfers(true) is intentional > in bailout cases: In the non-error bailouts, yes. I might want to change that later, but for now it's expected this way. > > Reviewed-by: Konrad Dybcio > > Konrad -- With best wishes Dmitry