From: Alex Elder <elder@linaro.org>
To: Markus Elfring <Markus.Elfring@web.de>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
linux-remoteproc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Ohad Ben-Cohen <ohad@wizery.com>, Suman Anna <s-anna@ti.com>
Subject: Re: [PATCH 1/4] remoteproc: Fix a bug in rproc_alloc()
Date: Tue, 14 Apr 2020 07:27:14 -0500 [thread overview]
Message-ID: <4b05d794-095b-7efe-c71c-42dca785ca49@linaro.org> (raw)
In-Reply-To: <e459f807-4c61-257b-b7b5-dd767202c435@web.de>
On 4/14/20 3:24 AM, Markus Elfring wrote:
>> I'm not actually sure this case causes an observable problem, but
>> it's incorrect. Fix this by initializing the notifyids field before
>> calling ida_simple_get() in rproc_alloc().
>
> I suggest to improve the commit message.
>
> * Can the information “field initialisation” be more helpful than “bug”
> in the patch subject?
No objection, though I personally would have spelled it
differently :)
> * Will the tag “Fixes” become relevant?
This bug was present when this code was first added.
Fixes: b5ab5e24e960 ("remoteproc: maintain a generic child device for each rproc")
Mathiew, feel free to add that.
-Alex
> Regards,
> Markus
>
next prev parent reply other threads:[~2020-04-14 12:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 8:24 Markus Elfring
2020-04-14 12:27 ` Alex Elder [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-04-13 19:33 [PATCH 0/4] remoteproc: Refactor function rproc_alloc() Mathieu Poirier
2020-04-13 19:33 ` [PATCH 1/4] remoteproc: Fix a bug in rproc_alloc() Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b05d794-095b-7efe-c71c-42dca785ca49@linaro.org \
--to=elder@linaro.org \
--cc=Markus.Elfring@web.de \
--cc=bjorn.andersson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
--cc=s-anna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®