From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07EF82D63E1 for ; Fri, 4 Jul 2025 12:21:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751631701; cv=none; b=e1a/dLEKGwZl3S6eUhdUnl20G81w0iz1NfaCz3AfW9FzjyA7MFy5omeBHLgz31ouZCHWUMAp1YSMiua8K0rWPCbW20kPM49lMhLdBM5Ws/ngJg3ND6sYQ5PCBeHzXgSeoYcgfmaNW+86+NcJctTopZii8h8hj6u0In9jLYkMMZw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751631701; c=relaxed/simple; bh=VHMgjqRbb53kMCUcKmAl1Z7kVnTGEWXvHkowxoIxsu0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QU4oCOFgFD6GvIVN0QuCI7ReGVJ1HlWUvkJV4jat88cbue+gbIPrcSdOdpKrtbBMLCzpB0XP4QVobmEgF8YW0H91LC6Dc6nW9h8wXXZ61P/vr0d5dhTAmJVloIOMK1AOGGO04zWo+TeRYQBfs+xSG6hJ+yi5rap9JLheUbLhWWg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZiTqarR3; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZiTqarR3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751631698; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=fkahBsI5VNxUJE8D/bd1T6fawfYSiY+jT8womBzp5i4=; b=ZiTqarR3qCxaVew4ixt/emHRqxbCmR6tWuNpmB/bUfX41efUm6UjtsjQWoVE7yG6qr9r// kJip3okAJkFVlqPWTFg4/3rIxtlJ/EHVhb+Bxni0POKr1UdBpOG0HyIlriBIhHhmVi7Ydk OO/+COIFkPrOe/MjmDrvrQvmQap6Rc4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-563-TGZFXlhiOgabPBOOAUFjyg-1; Fri, 04 Jul 2025 08:21:36 -0400 X-MC-Unique: TGZFXlhiOgabPBOOAUFjyg-1 X-Mimecast-MFC-AGG-ID: TGZFXlhiOgabPBOOAUFjyg_1751631696 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4532514dee8so5859595e9.0 for ; Fri, 04 Jul 2025 05:21:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751631695; x=1752236495; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=fkahBsI5VNxUJE8D/bd1T6fawfYSiY+jT8womBzp5i4=; b=R648zyT9HE6l4F/rBzpS9bmK/6HzbxKq686GEmOP/UBcaVMO6ZPKEJ4B0KSWlE8t3A beDIIZbUlpoKge1/EcnyQNAHm0+6feitmQglgItzDwtLOAdS5MWhdZvGHLMRWdWAT0tY bq7Oa4Sw3zjnwhnycyo05ZNA0SrUQx4HXkacxPdZAvrzwiLF4fUH8H4At1toeTq7JsPL y7Y6m7B3u8/IE86J98LvsSAQ3q6RthbUks4h1xNHhMbxokx/vnOPma/3ze9/SyEzaIGS B+L9Kr6rIT6pNNrLbUZ/p8/oCWynEYrvfn9EydMZEMcyFhAoMf47Sj16Y+uJd012bd6O VmXw== X-Forwarded-Encrypted: i=1; AJvYcCVC7KpYMSTnYOSfmZHxjg+HiO/kWfxxslfjOGhx6TmVbHrTdPjliOEzGI/HWAh2dTqX6QUEABmAslhVUFI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1TqT3M4hExaBPksdghXP0NZo5mVwARE1PXZfTWWt9E7eqyQfJ tAkcWh0ALqM8j0rFd4Lmrp4ec2Q3jBeuemrr0z27gK2YKOih3nnTY1799a+80MwIm1iogAwQXWN Fe6UsYoT8l0dPXJcRpze8glBew0m9BUD2QrhL+uQahRN/7U7Qryff0Brxz6d5cS36Iw== X-Gm-Gg: ASbGnctQ9iA+GnuyUQL6BadoHIg+cZZGlOX81TuUTUpbNh+O1TpiOe5Q+TDeyIpIG3O U1vBs1CPCFbcfZ+h6yGcxX2bNUG0+UptjNhc1EauZ2KhpbvTgn2PGgXsX9xtrFgBim8Qa4Ohxnz ahrL4SA1mFvzN10k0q+0KFU2GL9VWMslSdOpaGMh8stcx8hZrtkJg3Ke3hS/xbjlc3FWfBLemP3 Kie/xFQTRgvY+HIztse9cajDHSeDC9Lnf0nreUSymctOtR4ryFdIOJkPJpjLHDpsLecZgdq3k5v v6izC811Z64Vcb17CoktiOoo/vTzaELUvQisqKv/fYqpGEAICOXxtecqapEYqPzlx9Q8motHyV9 /rTMkAHig72E/u7ypXgVPOhBVjQRGboJtdqairuHXVS46BrE= X-Received: by 2002:a05:600c:8b6f:b0:44b:eb56:1d45 with SMTP id 5b1f17b1804b1-454b30b4e96mr28391795e9.15.1751631695364; Fri, 04 Jul 2025 05:21:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEXg7u6lGXcf+dIc0GhzPq0GsACARq1xT2O67ZRsTnKiJsXkcINlfprRNMS1WIcRgYppep5HA== X-Received: by 2002:a05:600c:8b6f:b0:44b:eb56:1d45 with SMTP id 5b1f17b1804b1-454b30b4e96mr28390995e9.15.1751631694749; Fri, 04 Jul 2025 05:21:34 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2c:5500:988:23f9:faa0:7232? (p200300d82f2c5500098823f9faa07232.dip0.t-ipconnect.de. [2003:d8:2f2c:5500:988:23f9:faa0:7232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454a9bde3b9sm55238795e9.28.2025.07.04.05.21.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jul 2025 05:21:34 -0700 (PDT) Message-ID: <4b06b163-e1ce-4c20-b878-4593bc86bf53@redhat.com> Date: Fri, 4 Jul 2025 14:21:32 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 3/6] KVM: arm64: Block cacheable PFNMAP mapping To: Jason Gunthorpe , Ankit Agrawal Cc: Will Deacon , "maz@kernel.org" , "oliver.upton@linux.dev" , "joey.gouly@arm.com" , "suzuki.poulose@arm.com" , "yuzenghui@huawei.com" , "catalin.marinas@arm.com" , "ryan.roberts@arm.com" , "shahuang@redhat.com" , "lpieralisi@kernel.org" , "ddutile@redhat.com" , "seanjc@google.com" , Aniket Agashe , Neo Jia , Kirti Wankhede , Krishnakant Jaju , "Tarun Gupta (SW-GPU)" , Vikram Sethi , Andy Currid , Alistair Popple , John Hubbard , Dan Williams , Zhi Wang , Matt Ochs , Uday Dhoke , Dheeraj Nigam , "alex.williamson@redhat.com" , "sebastianene@google.com" , "coltonlewis@google.com" , "kevin.tian@intel.com" , "yi.l.liu@intel.com" , "ardb@kernel.org" , "akpm@linux-foundation.org" , "gshan@redhat.com" , "linux-mm@kvack.org" , "tabba@google.com" , "qperret@google.com" , "kvmarm@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "maobibo@loongson.cn" , "pbonzini@redhat.com" References: <20250621042111.3992-1-ankita@nvidia.com> <20250621042111.3992-4-ankita@nvidia.com> <20250630122501.GQ167785@nvidia.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250630122501.GQ167785@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 30.06.25 14:25, Jason Gunthorpe wrote: > On Mon, Jun 30, 2025 at 01:56:43AM +0000, Ankit Agrawal wrote: >>> Sorry for the drive-by comment, but I was looking at this old series from >>> Paolo (look at the cover letter and patch 5): >>> >>> https://lore.kernel.org/r/20250109133817.314401-1-pbonzini@redhat.com >>> >>> in which he points out that the arm64 get_vma_page_shift() function >>> incorrectly assumes that a VM_PFNMAP VMA is physically contiguous, which >>> may not be the case if a driver calls remap_pfn_range() to mess around >>> with mappings within the VMA. I think that implies that the optimisation >>> in 2aa53d68cee6 ("KVM: arm64: Try stage2 block mapping for host device >>> MMIO") is unsound. >> >> Hm yeah, that does seem problematic. Perhaps we need a new >> vma flag that could help the driver communicate to the KVM that the >> mapping is contiguous and it can go ahead with the optimization? >> E.g. something similar to VM_ALLOW_ANY_UNCACHED. > > I think Paolo has the right direction - remove any attempts by KVM to > expand contiguity, it should only copy the primary's PTEs and rely on > the primary to discover contiguity. No new flags. 100% -- Cheers, David / dhildenb