From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C12BACDB47E for ; Wed, 18 Oct 2023 11:46:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230073AbjJRLqW (ORCPT ); Wed, 18 Oct 2023 07:46:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230013AbjJRLqT (ORCPT ); Wed, 18 Oct 2023 07:46:19 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22BFF123 for ; Wed, 18 Oct 2023 04:46:17 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-4083740f92dso9999125e9.3 for ; Wed, 18 Oct 2023 04:46:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697629575; x=1698234375; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=hIZB4xEFiDqc2+Z84fN6WVGzHYrI2kiuxOOK9C2i8+I=; b=OsJYJIZ7N2aUiAtuMwVWHJsMh4uu2u34GY9Gwnv07oPTNrecxZCVY4KTbU+Ktw3CRj 3q57SyO8rPydvlVLdR69AqlO7YXRTbZ5yl1DRlaoZcFvGkebTFMDuFaArTRoybOAuQOf TfLAwWd9OnfJ29M6SIx3NZ7RrM/hVgzPl27fzG4Ss1/vm7ijw+EJYfo3WZ9vE16ps0VS ePpZa9ey+KrMFYVm+OKB1AwqKQyaiKO+HMhruH0gmaQ2kbfkzy1mtz3MoFvgDxnyGYfD 8+CQFdqF8GZ1L0bloWz7eMTYNU8PmtoaX2FNqAhmVpLVeJbBVB3vaYVQucP+Ltu+I9BN YMDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697629575; x=1698234375; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=hIZB4xEFiDqc2+Z84fN6WVGzHYrI2kiuxOOK9C2i8+I=; b=qsYKGm9C3ixSB4jVxcJwR9EpxmOg6pDiUZquYH13Ng6lMT2MRs6pYQfOcCRlo4D0Lo zhOohqRbJ7PpcADA44CcNn/+IUANifvE1VBmcM6G0LMEP2olag6QlQEdeTrXVlE4o6iS fDaNBo9DO0udj8O5lpdSmSRwppabQAh25pPJM2PHcpDPl+ThtAuLreLfcjQkTgNUnobE 65ORRTa3dHU1+Tq+tBrNULCPZKU/21UNx7Pv/cKYAzj+gbMU6CqqEuENYFZtKwu3YhAx 0FuvMBxJ8AWh80peBhPpuTVfMrRv7GQXu5Bl6K49Sj6P5uq+ABna86GPeaJdJTyJlZ4p /NCQ== X-Gm-Message-State: AOJu0YwI1cqCKPqUUiyuvjlbb8Zm4AhctR/zndCTpWq83QjHBOzaTfjI fOc/CkDkwVMoSsB5JiMaTEJMhA== X-Google-Smtp-Source: AGHT+IFST4zTv5e3F3vfbnDudoRjP5SBUIl6bdsoe+9WOadjGlN10iP2gifoV+us3GybdQCFKsaB5Q== X-Received: by 2002:a05:600c:468e:b0:405:3d04:5f52 with SMTP id p14-20020a05600c468e00b004053d045f52mr3756113wmo.24.1697629575441; Wed, 18 Oct 2023 04:46:15 -0700 (PDT) Received: from draszik.lan ([80.111.64.44]) by smtp.gmail.com with ESMTPSA id bs30-20020a056000071e00b0032d9a1f2ec3sm1991631wrb.27.2023.10.18.04.46.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 04:46:14 -0700 (PDT) Message-ID: <4b0b46f29955956916765d8d615f96849c8ce3f7.camel@linaro.org> Subject: Re: [PATCH v2] Revert "fuse: Apply flags2 only when userspace set the FUSE_INIT_EXT" From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Bernd Schubert Cc: Miklos Szeredi , "stable@vger.kernel.org" , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" Date: Wed, 18 Oct 2023 12:46:13 +0100 In-Reply-To: <717fd97a-6d14-4dc9-808c-d752d718fb80@ddn.com> References: <20230904133321.104584-1-git@andred.net> <20231018111508.3913860-1-git@andred.net> <717fd97a-6d14-4dc9-808c-d752d718fb80@ddn.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4-1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2023-10-18 at 11:39 +0000, Bernd Schubert wrote: > On 10/18/23 13:15, Andr=C3=A9 Draszik wrote: > > From: Andr=C3=A9 Draszik > >=20 > > This reverts commit 3066ff93476c35679cb07a97cce37d9bb07632ff. > >=20 > > This patch breaks all existing userspace by requiring updates as > > mentioned in the commit message, which is not allowed. > >=20 > > Revert to restore compatibility with existing userspace > > implementations. >=20 > Which fuse file system does it exactly break? In fact there haven't > been=20 > added too many flags after - what exactly is broken? The original patch broke the existing kernel <-> user ABI by now requiring user space applications to pass in an extra flag. There are various side-effects of this, like unbootable systems, just because the kernel was updated. Breaking the ABI is the one thing that is not allowed. This is not specific to any particular fuse file system. Kind Regards, Andre