From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752056AbdARJaX (ORCPT ); Wed, 18 Jan 2017 04:30:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46352 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751917AbdARJaU (ORCPT ); Wed, 18 Jan 2017 04:30:20 -0500 Subject: Re: [PATCH V3] x86: call smp vmxoff in smp stop To: Xishi Qiu References: <586CCA5A.8050607@huawei.com> <586DA529.1040803@huawei.com> <58798201.2@huawei.com> <9b0db9ff-19aa-5687-dac0-dc2fa2337cc0@redhat.com> <587ED0CB.6060109@huawei.com> Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , the arch/x86 maintainers , wanpeng.li@hotmail.com, Andrew Morton , hidehiro.kawai.ez@hitachi.com, LKML , Fengtiantian , Xiexiuqi From: Paolo Bonzini Message-ID: <4b0c16d2-b271-1aa6-f16a-0f5860397804@redhat.com> Date: Wed, 18 Jan 2017 10:30:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <587ED0CB.6060109@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Wed, 18 Jan 2017 09:30:15 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/01/2017 03:19, Xishi Qiu wrote: > On 2017/1/17 23:18, Paolo Bonzini wrote: > >> >> >> On 14/01/2017 02:42, Xishi Qiu wrote: >>> From: Tiantian Feng >>> >>> We need to disable VMX on all CPUs before stop cpu when OS panic, >>> otherwisewe risk hanging up the machine, because the CPU ignore INIT >>> signals when VMX is enabled. In kernel mainline this issue existence. >>> >>> Signed-off-by: Tiantian Feng >> >> Xishi, >> >> it's still missing your Signed-off-by. >> > > Hi Paolo, > > This patch is from fengtiantian, and I just send it for him, > so still should add my SOB? Yes, both of them should be there. The "signed-off-by" is a sequence of all people that managed the patch---so that would be Tiantian first, then you, then an x86 maintainer. Paolo > Thanks, > Xishi Qiu > >> Paolo >> >>> --- >>> arch/x86/kernel/smp.c | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/arch/x86/kernel/smp.c b/arch/x86/kernel/smp.c >>> index 68f8cc2..b574d55 100644 >>> --- a/arch/x86/kernel/smp.c >>> +++ b/arch/x86/kernel/smp.c >>> @@ -33,6 +33,7 @@ >>> #include >>> #include >>> #include >>> +#include >>> >>> /* >>> * Some notes on x86 processor bugs affecting SMP operation: >>> @@ -162,6 +163,7 @@ static int smp_stop_nmi_callback(unsigned int val, struct pt_regs *regs) >>> if (raw_smp_processor_id() == atomic_read(&stopping_cpu)) >>> return NMI_HANDLED; >>> >>> + cpu_emergency_vmxoff(); >>> stop_this_cpu(NULL); >>> >>> return NMI_HANDLED; >>> @@ -174,6 +176,7 @@ static int smp_stop_nmi_callback(unsigned int val, struct pt_regs *regs) >>> asmlinkage __visible void smp_reboot_interrupt(void) >>> { >>> ipi_entering_ack_irq(); >>> + cpu_emergency_vmxoff(); >>> stop_this_cpu(NULL); >>> irq_exit(); >>> } >>> >> >> . >> > > >