From: Jan Kiszka <jan.kiszka@siemens.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] Don't set wildcard filter for non-existing module
Date: Thu, 28 Sep 2017 13:11:40 +0200 [thread overview]
Message-ID: <4b13012c-8b08-8eb4-2cbd-0abdd1699af6@siemens.com> (raw)
From: Jan Kiszka <jan.kiszka@siemens.com>
If filter_mod is NULL, there is no need to add it to the list. This
avoids premature termination of trace-cmd on systems without
CONFIG_DYNAMIC_FTRACE.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
trace-record.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/trace-record.c b/trace-record.c
index 020a373..a0b6541 100644
--- a/trace-record.c
+++ b/trace-record.c
@@ -4680,7 +4680,7 @@ void trace_record (int argc, char **argv)
}
}
- if (!filtered)
+ if (!filtered && instance->filter_mod)
add_func(&instance->filter_funcs,
instance->filter_mod, "*");
--
2.12.3
next reply other threads:[~2017-09-28 11:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-28 11:11 Jan Kiszka [this message]
2017-10-03 21:44 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b13012c-8b08-8eb4-2cbd-0abdd1699af6@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®