From: "Christian König" <christian.koenig@amd.com>
To: Danilo Krummrich <dakr@redhat.com>,
Arvind.Yadav@amd.com, sumit.semwal@linaro.org,
gustavo@padovan.org
Cc: dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma-buf: actually set signaling bit for private sub fences
Date: Thu, 26 Jan 2023 07:58:53 +0100 [thread overview]
Message-ID: <4b13c48e-1677-3947-42e5-5ba241bcb96a@amd.com> (raw)
In-Reply-To: <20230126002844.339593-1-dakr@redhat.com>
Am 26.01.23 um 01:28 schrieb Danilo Krummrich:
> In dma_fence_allocate_private_stub() set the signaling bit of the newly
> allocated private stub fence rather than the signaling bit of the
> shared dma_fence_stub.
>
> Fixes: c85d00d4fd8b ("dma-buf: set signaling bit for the stub fence")
> Signed-off-by: Danilo Krummrich <dakr@redhat.com>
Good catch, Reviewed-by: Christian König <christian.koenig@amd.com>
Should I push it upstream as well or do you have commit access?
> ---
> drivers/dma-buf/dma-fence.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c
> index 406b4e26f538..0de0482cd36e 100644
> --- a/drivers/dma-buf/dma-fence.c
> +++ b/drivers/dma-buf/dma-fence.c
> @@ -167,7 +167,7 @@ struct dma_fence *dma_fence_allocate_private_stub(void)
> 0, 0);
>
> set_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT,
> - &dma_fence_stub.flags);
> + &fence->flags);
>
> dma_fence_signal(fence);
>
next prev parent reply other threads:[~2023-01-26 6:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 0:28 Danilo Krummrich
2023-01-26 6:58 ` Christian König [this message]
2023-01-26 22:25 ` Danilo Krummrich
2023-01-27 7:49 ` Christian König
2023-02-01 10:34 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b13c48e-1677-3947-42e5-5ba241bcb96a@amd.com \
--to=christian.koenig@amd.com \
--cc=Arvind.Yadav@amd.com \
--cc=dakr@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@padovan.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®