Re: [PATCH] selftests: futex: fix compilation error

[lei yang <lei.yang@windriver.com>]

On 2017年11月07日 07:45, Shuah Khan wrote:
> On 11/05/2017 09:03 PM, Lei Yang wrote:
>> I run into below error when building futext
>> /bin/sh: -c: line 5: syntax error: unexpected end of file
>>
>> the closing ";" and "\" are necessary.
>> My OS is "Ubuntu 14.04.5 LTS"
>>
>> Signed-off-by: Lei Yang <Lei.Yang@windriver.com>
>> ---
>>   tools/testing/selftests/futex/Makefile | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile
>> index f0c0369..943f3a2 100644
>> --- a/tools/testing/selftests/futex/Makefile
>> +++ b/tools/testing/selftests/futex/Makefile
>> @@ -11,9 +11,9 @@ all:
>>   		BUILD_TARGET=$(OUTPUT)/$$DIR;	\
>>   		mkdir $$BUILD_TARGET  -p;	\
>>   		make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\
>> -		if [ -e $$DIR/$(TEST_PROGS) ]; then
>> -			rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/;
>> -		fi
>> +		if [ -e $$DIR/$(TEST_PROGS) ]; then \
>> +			rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \
>> +		fi \
>>   	done
>>   
>>   override define RUN_TESTS
>>
> Hmm. I don't see this error on linux_4.14-rc8?
>
> Can you give more details on the gcc version you are using?

$ cat /proc/version
Linux version 3.16.0-30-generic (buildd@kissel) (gcc version 4.8.2 
(Ubuntu 4.8.2-19ubuntu1) ) #40~14.04.1-Ubuntu SMP Thu Jan 15 17:43:14 
UTC 2015

$ uname -a
Linux pek-lyang0-d1 3.16.0-30-generic #40~14.04.1-Ubuntu SMP Thu Jan 15 
17:43:14 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

I'm also surprised why nobody report this ? I thought it's because 
ksefltest community  is not active :-)

Lei

> thanks,
> -- Shuah