Re: [PATCH 3/5] dt-bindings: arm: microchip,sam9x60-pit64b : convert to DT schema

[Akhila YS <akhilayalmati@gmail.com>]

On 17-02-2026 23:23, Conor Dooley wrote:
> On Tue, Feb 17, 2026 at 05:24:21PM +0000, Akhila YS wrote:
>> Convert Atmel Periodic interval timer of 64bit (PIT64b) binding to YAML
>> format.
>> Changes during conversion:
>> - Add missing compatible "microchip,sama7g5-pit64b" along with a fallback
>> compatible "microchip,sam9x60-pit64b".
>>
>> Signed-off-by: Akhila YS <akhilayalmati@gmail.com>
>> ---
>>  .../bindings/arm/microchip,sam9x60-pit64b.yaml     | 71 ++++++++++++++++++++++
>>  1 file changed, 71 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/microchip,sam9x60-pit64b.yaml b/Documentation/devicetree/bindings/arm/microchip,sam9x60-pit64b.yaml
>> new file mode 100644
>> index 000000000000..6bf8e81d4c72
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/arm/microchip,sam9x60-pit64b.yaml
>> @@ -0,0 +1,71 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/arm/microchip,sam9x60-pit64b.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Microchip PIT64B 64-bit Periodic Interval Timer
>> +
>> +maintainers:
>> +  - Nicolas Ferre <nicolas.ferre@microchip.com>
>> +  - Claudiu Beznea <claudiu.beznea@microchip.com>
>> +
>> +description:
>> +  The Microchip PIT64B is a 64-bit periodic interval timer used in
>> +  several modern Microchip ARM SoCs including SAM9X60, SAM9X7 and
>> +  SAMA7D65 families. It provides extended timing range, flexible
>> +  clock selection and supports both periodic and one-shot interrupt
>> +  generation modes.
>> +
>> +properties:
>> +  compatible:
>> +    oneOf:
>> +      - const: microchip,sam9x60-pit64b
>> +      - items:
>> +          - const: microchip,sama7d65-pit64b
>> +          - const: microchip,sam9x60-pit64b
>> +      - items:
>> +          - const: microchip,sama7g5-pit64b
>> +          - const: microchip,sam9x60-pit64b
>> +      - items:
>> +          - const: microchip,sam9x7-pit64b
>> +          - const: microchip,sam9x60-pit64b
> These three can be merged into one enum + const items list.


Okay.

>
>> +  reg:
>> +    maxItems: 1
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +  clocks:
>> +    minItems: 1
>> +    maxItems: 2
>> +
>> +  clock-names:
>> +    oneOf:
>> +      - const: pclk
>> +      - items:
>> +          - const: pclk
>> +          - const: gclk
> This can be an items list with minItems: 1, but there should be some
> conditional logic used to permit gclk only where it is valid. The text
> binding removal is missing so I cannot say exactly what that logic
> should be.


Okay.

>
> pw-bot: changes-requested
>
> Cheers,
> Conor.
>
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - interrupts
>> +  - clocks
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/interrupt-controller/irq.h>
>> +    #include <dt-bindings/clock/at91.h>
>> +    timer@f0028000 {
>> +        compatible = "microchip,sama7g5-pit64b", "microchip,sam9x60-pit64b";
>> +        reg = <0xf0028000 0x100>;
>> +        interrupts = <37 IRQ_TYPE_LEVEL_HIGH 7>;
>> +        clocks = <&pmc PMC_TYPE_PERIPHERAL 37>, <&pmc PMC_TYPE_GCK 37>;
>> +        clock-names = "pclk", "gclk";
>> +    };
>> +...
>>
>> -- 
>> 2.43.0
>>
-- 
Best Regards,
Akhila.