From: Dan Carpenter <dan.carpenter@linaro.org>
To: Julien Massot <julien.massot@collabora.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] media: i2c: max96717: clean up on error in max96717_subdev_init()
Date: Fri, 27 Sep 2024 13:57:41 +0300 [thread overview]
Message-ID: <4b187b7e-7223-48f2-add4-bbc167ab7c4e@stanley.mountain> (raw)
In-Reply-To: <8d281bcbc504abaa9838ff666a36515cf7e57239.camel@collabora.com>
On Fri, Sep 27, 2024 at 12:47:03PM +0200, Julien Massot wrote:
> Hi,
> On Thu, 2024-09-12 at 11:51 +0300, Dan Carpenter wrote:
> > Call v4l2_ctrl_handler_free() to clean up from
> > v4l2_ctrl_handler_init().
> >
> > Fixes: 50f222455793 ("media: i2c: add MAX96717 driver")
>
> The right commit to fix is:
> Fixes: 19b5e5511ca4f ("media: i2c: max96717: add test pattern ctrl")
>
> Since there was no control to free in the initial driver.
>
> Reviewed-by: Julien Massot <julien.massot@collabora.com>
>
Yep. You're right. That makes more sense. I'll resend.
regards,
dan carpenter
prev parent reply other threads:[~2024-09-27 10:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 8:51 Dan Carpenter
2024-09-27 10:47 ` Julien Massot
2024-09-27 10:57 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b187b7e-7223-48f2-add4-bbc167ab7c4e@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=julien.massot@collabora.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®