From: "Arnd Bergmann" <arnd@arndb.de>
To: "Jacky Chou" <jacky_chou@aspeedtech.com>,
andrew+netdev@lunn.ch, "David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh@kernel.org>,
krzk+dt@kernel.org, "Conor Dooley" <conor+dt@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
Netdev <netdev@vger.kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next v2 5/7] net: ftgmac100: add pin strap configuration for AST2700
Date: Mon, 18 Nov 2024 07:34:23 +0100 [thread overview]
Message-ID: <4b1a9090-4134-4f77-a380-5ead03fd8ba8@app.fastmail.com> (raw)
In-Reply-To: <20241118060207.141048-6-jacky_chou@aspeedtech.com>
On Mon, Nov 18, 2024, at 07:02, Jacky Chou wrote:
> @@ -351,6 +352,10 @@ static void ftgmac100_start_hw(struct ftgmac100 *priv)
> if (priv->netdev->features & NETIF_F_HW_VLAN_CTAG_RX)
> maccr |= FTGMAC100_MACCR_RM_VLAN;
>
> + if (of_device_is_compatible(priv->dev->of_node, "aspeed,ast2700-mac")
> &&
> + phydev && phydev->interface == PHY_INTERFACE_MODE_RMII)
> + maccr |= FTGMAC100_MACCR_RMII_ENABLE;
> +
> /* Hit the HW */
Is there a way to probe the presence of 64-bit addressing from
hardware registers? That would be nicer than triggering it from
the compatible string, given that any future SoC is likely
also 64-bit.
Arnd
next prev parent reply other threads:[~2024-11-18 6:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 6:02 [net-next v2 0/7] Add Aspeed G7 FTGMAC100 support Jacky Chou
2024-11-18 6:02 ` [net-next v2 1/7] dt-bindings: net: ftgmac100: support for AST2700 Jacky Chou
2024-11-19 7:40 ` Krzysztof Kozlowski
2024-11-19 11:12 ` 回覆: " Jacky Chou
2024-11-18 6:02 ` [net-next v2 2/7] net: faraday: Add ARM64 in FTGMAC100 " Jacky Chou
2024-11-18 6:02 ` [net-next v2 3/7] net: ftgmac100: Add reset toggling for Aspeed SOCs Jacky Chou
2024-11-18 6:32 ` Arnd Bergmann
2024-11-18 7:45 ` 回覆: " Jacky Chou
2024-11-18 10:03 ` Philipp Zabel
2024-11-18 10:44 ` 回覆: " Jacky Chou
2024-11-18 6:02 ` [net-next v2 4/7] net: ftgmac100: Add support for AST2700 Jacky Chou
2024-11-18 6:02 ` [net-next v2 5/7] net: ftgmac100: add pin strap configuration " Jacky Chou
2024-11-18 6:34 ` Arnd Bergmann [this message]
2024-11-18 7:51 ` 回覆: " Jacky Chou
2024-11-18 9:04 ` Arnd Bergmann
2024-11-18 9:36 ` 回覆: " Jacky Chou
2024-11-18 6:02 ` [net-next v2 6/7] net: ftgmac100: Add 64-bit DMA support " Jacky Chou
2024-11-18 6:02 ` [net-next v2 7/7] net: ftgmac100: remove extra newline symbols Jacky Chou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b1a9090-4134-4f77-a380-5ead03fd8ba8@app.fastmail.com \
--to=arnd@arndb.de \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=jacky_chou@aspeedtech.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®