From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05980C001DF for ; Mon, 3 Jul 2023 14:59:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231310AbjGCO7f (ORCPT ); Mon, 3 Jul 2023 10:59:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230364AbjGCO7c (ORCPT ); Mon, 3 Jul 2023 10:59:32 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60D0AE5F for ; Mon, 3 Jul 2023 07:59:31 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2b6ef9ed2fdso4374121fa.2 for ; Mon, 03 Jul 2023 07:59:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688396369; x=1690988369; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ux3SJsWvIcNtyLBV4pxoycLjvjlI+oYJOk/HoRjmvBw=; b=JLt6ff0K6AlkSGvVOXKa26IAS1N0CeL9GHWrBfo8fQ2yXk0dAbFS5PvjOqladIjud4 +FQJ6XeuAUbxjMjHea3C58hEBpG6I/l8hxYUmf1aplKPnnRpdoH9DCpzuxrfZoJUq8gn am2JNiJD2Z0fxpnG7kk6mbUN08JIp2aoJBft3fU/GR3XF0DbZEyg2+WONSsYRq/O/v9z /oWq/qLAo7K5yS8yNZ5rBPvBMZ40tvCo/xbjxXpd8+XkFFIxFSOkZvQO0HWr6HR0XXHa eTwNWO75TVrZr7cXJsmXkS6duRuqFtmpcTONXafFD7A5H/LRWEMwUOZJR8gFe7dK7ReI iGKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688396369; x=1690988369; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ux3SJsWvIcNtyLBV4pxoycLjvjlI+oYJOk/HoRjmvBw=; b=fkRG+vCONEtgStU1YQFGGl7IPRQWBQSp45bi8kYMQreu2AamNf986UUD5rSmQ0ZTVd 2yu+/EEsZw6o0LjyPKFVil0ltAvB84bJzP2QSHeROxbIS5cIcikS6ZBn/IlLTLcSmdIX ndCnqHww9D2AMiC/P4+HxgOD46iTVSvV6qcVzIkVXpqMWX18jF4Jyd+yRiEyAvKtmWks vhNgZK55b9GfG79i+TF2xi+oGuUWfejW9nNBoB83bcv60HwoE6WSG6wi9tFgE40WKQ0a fKoDi7VU5N+zreoateiTbgd6vJg8jGE/vCDZVYKXl/zueX3uALYtrHSogI7BXqCEXub4 PRxA== X-Gm-Message-State: ABy/qLbdwG+yrBNU7WUdEEsoqy4GU5ovNnj2T/3kYlsA/XNXVbG8AOKc yA/hxoIrgwgzUiA93ruOJDppiQ== X-Google-Smtp-Source: APBJJlEEEcJT6hzruF4LYserl4hMFzP3P6NYtXj0bcH+2GwlEmR0i/2kSlzbMdVfbTYPxSlAn/dPaA== X-Received: by 2002:a2e:9844:0:b0:2b5:86e4:558e with SMTP id e4-20020a2e9844000000b002b586e4558emr6986594ljj.38.1688396369411; Mon, 03 Jul 2023 07:59:29 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id k22-20020a056402049600b0051e0bf5807bsm2280634edv.49.2023.07.03.07.59.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Jul 2023 07:59:28 -0700 (PDT) Message-ID: <4b1beb09-c9ba-82c5-69f0-058025c7f7e2@linaro.org> Date: Mon, 3 Jul 2023 16:59:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 3/5] dt-bindings: i2c: qcom,i2c-geni: Allow no qup-core icc path Content-Language: en-US From: Krzysztof Kozlowski To: Konrad Dybcio , Andy Gross , Bjorn Andersson , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Andi Shyti Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-i2c@vger.kernel.org References: <20230703-topic-8250_qup_icc-v1-0-fea39aa07525@linaro.org> <20230703-topic-8250_qup_icc-v1-3-fea39aa07525@linaro.org> <05869d6f-972b-75e1-6c0f-46baeafca5ff@linaro.org> In-Reply-To: <05869d6f-972b-75e1-6c0f-46baeafca5ff@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/07/2023 16:36, Krzysztof Kozlowski wrote: > On 03/07/2023 15:31, Konrad Dybcio wrote: >> Some SoCs (like SM8150 and SM8250) don't seem to provide a qup-core path. >> Allow such case. >> > > Reviewed-by: Krzysztof Kozlowski Un-reviewed. Don't define properties in oneOf, instead use the syntax I pointed out in other patch. If you remove interconnects from this example, you will reproduce the error. This should be something like: interconnects: minItems: 2 maxItems: 3 interconnect-names: oneOf: - items: - const: qup-config - const: qup-memory - items: - const: qup-core - const: qup-config - const: qup-memory Best regards, Krzysztof