From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Zhengjun Xing <zhengjun.xing@linux.intel.com>,
gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xhci:Fix NULL pointer in xhci debugfs
Date: Fri, 19 Jan 2018 09:03:20 +0200 [thread overview]
Message-ID: <4b1e0988-cf37-cc16-d365-0c19ab1aebf5@linux.intel.com> (raw)
In-Reply-To: <20180119021351.8881-1-zhengjun.xing@linux.intel.com>
On 19.01.2018 04:13, Zhengjun Xing wrote:
> Commit dde634057da7 ("xhci: Fix use-after-free in xhci debugfs") causes a
> null pointer dereference while fixing xhci-debugfs usage of ring pointers
> that were freed during hibernate.
>
> The fix passed addresses to ring pointers instead, but forgot to do this
> change for the xhci_ring_trb_show function.
>
> The address of the ring pointer passed to xhci-debugfs was of a temporary
> ring pointer "new_ring" instead of the actual ring "ring" pointer. The
> temporary new_ring pointer will be set to NULL later causing the NULL
> pointer dereference.
>
> This issue was seen when reading xhci related files in debugfs:
>
> cat /sys/kernel/debug/usb/xhci/*/devices/*/ep*/trbs
>
> [ 184.604861] BUG: unable to handle kernel NULL pointer dereference at (null)
> [ 184.613776] IP: xhci_ring_trb_show+0x3a/0x890
> [ 184.618733] PGD 264193067 P4D 264193067 PUD 263238067 PMD 0
> [ 184.625184] Oops: 0000 [#1] SMP
> [ 184.726410] RIP: 0010:xhci_ring_trb_show+0x3a/0x890
> [ 184.731944] RSP: 0018:ffffba8243c0fd90 EFLAGS: 00010246
> [ 184.737880] RAX: 0000000000000000 RBX: 0000000000000000 RCX: 00000000000295d6
> [ 184.746020] RDX: 00000000000295d5 RSI: 0000000000000001 RDI: ffff971a6418d400
> [ 184.754121] RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
> [ 184.762222] R10: ffff971a64c98a80 R11: ffff971a62a00e40 R12: ffff971a62a85500
> [ 184.770325] R13: 0000000000020000 R14: ffff971a6418d400 R15: ffff971a6418d400
> [ 184.778448] FS: 00007fe725a79700(0000) GS:ffff971a6ec00000(0000) knlGS:0000000000000000
> [ 184.787644] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 184.794168] CR2: 0000000000000000 CR3: 000000025f365005 CR4: 00000000003606f0
> [ 184.802318] Call Trace:
> [ 184.805094] ? seq_read+0x281/0x3b0
> [ 184.809068] seq_read+0xeb/0x3b0
> [ 184.812735] full_proxy_read+0x4d/0x70
> [ 184.817007] __vfs_read+0x23/0x120
> [ 184.820870] vfs_read+0x91/0x130
> [ 184.824538] SyS_read+0x42/0x90
> [ 184.828106] entry_SYSCALL_64_fastpath+0x1a/0x7d
>
> Fixes: dde634057da7 ("xhci: Fix use-after-free in xhci debugfs")
> Signed-off-by: Zhengjun Xing <zhengjun.xing@linux.intel.com>
> ---
Thanks, adding to queue
-Mathias
prev parent reply other threads:[~2018-01-19 7:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 2:13 Zhengjun Xing
2018-01-19 7:03 ` Mathias Nyman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b1e0988-cf37-cc16-d365-0c19ab1aebf5@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome