mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
	Dave Airlie <airlied@gmail.com>,
	Alex Deucher <alexander.deucher@amd.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git pull] drm for 6.2-rc1
Date: Wed, 14 Dec 2022 09:05:06 +0100	[thread overview]
Message-ID: <4b1f104f-3b2a-532d-3354-11c68c5b9aa6@amd.com> (raw)
In-Reply-To: <CAHk-=whVsxgtwvnK2=WRvs_i+miknfB2R7dQ4U8oooBFJZYH6w@mail.gmail.com>

Am 13.12.22 um 21:14 schrieb Linus Torvalds:
> On Mon, Dec 12, 2022 at 6:56 PM Dave Airlie <airlied@gmail.com> wrote:
>> There are a bunch of conflicts, one in amdgpu is a bit nasty, I've
>> cc'ed Christian/Alex to make sure they know to check whatever
>> resolution you find. The one I have is what we have in drm-tip tree.
> Hmm. My merge resolution is slightly different from yours.
>
> You seem to have basically dropped commit b09d6acba1d9 ("drm/amdgpu:
> handle gang submit before VMID").
>
> Now, there are other fence changes in the drm tree that may mean that
> that commit *should* be dropped, so it's entirely possible that my
> resolution which kept that ordering change might be wrong and your
> resolution that just took the drm tip code is the right one.
>
> Christian? Alex? Can you please double-check what I just pushed out?

Yeah, that's certainly not correct. The ordering problem b09d6acba1d9 
fixed is back there again.

I'm like 99% sure that I did the right thing and my local drm-tip 
certainly at some point had the right conflict resolution because I've 
used that for testing the change.

The last 1% is that it's possible that I only fixed this on the build 
server and never pushed into the upstream repository.

Anyway we need to re-apply b09d6acba1d9 which should be trivial.

Thanks,
Christian.

>
>              Linus


  reply	other threads:[~2022-12-14  8:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-13  2:56 Dave Airlie
2022-12-13 20:14 ` Linus Torvalds
2022-12-14  8:05   ` Christian König [this message]
2022-12-14 16:57     ` Linus Torvalds
2022-12-13 20:20 ` pr-tracker-bot
2022-12-14 22:06 Bert Karwatzki
2022-12-14 22:13 Bert Karwatzki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b1f104f-3b2a-532d-3354-11c68c5b9aa6@amd.com \
    --to=christian.koenig@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®