From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C428307AF0 for ; Thu, 19 Feb 2026 20:49:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771534162; cv=none; b=QGE2R267zTBce9HwTP7Yh0ofEUn/Qxs4jy5lGmGhwlJETI3JB5FuBhQRbTtDrHRyBwBbYW3yjychRggOI+DBP3JL6RHHcmCXFnDnLyt95PKBnMbaAcfDt5z9tXPr7u2LqzYLMskA68iRnTKKzBLeAcIglxCeJej3DXb6OXcbYJw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771534162; c=relaxed/simple; bh=w9oLg1R0wW4uMVOKbUTIgtKGy4OR4ye6n/7fMiajz5Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mvODgobNAoH6Tqb+URuCu2kkbB37+IcieR3+4tGywV3PqJoUSv1RFEtssOevuHpuIyDAS8veqNgtimhLudUc+lFjMRmMCIxu3x/v4oAknJIj1dZyzsvy4+P+zy94kX5mpg8G2vksemEyi8xVpCbiHgul9co6EQxeczcxlb6k2Cg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=OnxGDHIE; arc=none smtp.client-ip=209.85.167.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="OnxGDHIE" Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-45f0b597eb4so784237b6e.2 for ; Thu, 19 Feb 2026 12:49:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1771534158; x=1772138958; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UtgTLfGOcjGDe5PL0CHRRM4ZPGAPDgJhQWgABhxIwOI=; b=OnxGDHIEpSgwydxSo+Ox0VIZVoezIpwv0gPA9dVBHDoIXE+cFEhYjiudytjBVTJLi0 haAJDy4WNEAh0KMiVylCLsKeVZGR/1j5Niy8TNxNd2jNxpWrCZbkSejWOQxzcE4epwua 9NVQdpdK6BjwN5k9nO+opyGACXpSaK+GxRNKCh0okr6pTCLiWn1Zixw5HIe6WTQF9ABt aLdvpQjgYbeHSgSWCRIGsbNhXfj+ZoGdSP9PDQKFH5nGFpvOqAtCz08TpneJBdUPmqba FQodCMNIHSTG63bQkGY9N8/2WdA2ZhECvS9MABFC9RyqQddQ81zeKOKpsaKKWefmh3l+ X1FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771534158; x=1772138958; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UtgTLfGOcjGDe5PL0CHRRM4ZPGAPDgJhQWgABhxIwOI=; b=LP2lwQuC2se2HMbO/bK/QXPk3acouw0u+Q0hrUFDzoX1REo8tT7QZfe5tzq9QOUhdc lNM14bf7b34SXY0ZAKe2SVogM8o3s2soTrrtRRKAeflCTdX/ErwVMFFCMmehzlWJjlB+ nojFWFk9F++DydOVoN4UGWvyZaUBONSqeg9OcrWdxwPg2CfZxjo1PRyjwZHrsq0y6rk4 YJDebpmIV0oF4Q1HLZaxPyRijHX+fVTENIr/Yhp9XU0Cy3JnwSuW1QK4ULbaBVQeozLD 89ajJwT/FiWjqhalfXcAnyanjihP/T/5nqhziqOLruAqwm0Ai5NzJFWu25U9xMFjUZDp Sqvg== X-Forwarded-Encrypted: i=1; AJvYcCWuiLNWcUV7McPlUyC2SL02igVaQnWzyyDaVSGPMYflds0xLDccPahqSrBWJa33xihvmnEvAYxaKX4FAiQ=@vger.kernel.org X-Gm-Message-State: AOJu0YziZRZVHYPhP1CdDLYsIEzzAR5whwYL/V7zSib9RH9XsZKWoFH/ dypepHplNpQgWBiKq06dw9z+Pz9nPv23wIv9d40ljU6FwpgcJjDah7MlnG3sxowurDI= X-Gm-Gg: AZuq6aLz2g08fFC43blVAX0npQmk9ZR87mpDLO1+1VMrAeh7OaxD4E/P9stKsVCD3qi j/zmgQVOlLPLDL2O4Jx9K1FeWGnEZgS4LJFQrAjI0rydtd45Z2PwiVL094abUzGbRV6I7G9cBhE qas+ySB0J4oqtGmY9V0JIqb+5pALhnQkjkTC8KYeclGxIMzt1dvK2HHdGIBuH3MT3q9RRWUuabW 9NjQmcrPtQ3q5Fwl37YsKYj1iErjdyJz4Y3uGPhhWOQ4AklE+nzGTccxVHAbXkMWHzmjfn2riHl t7qxyO0VcVAwoniMchQATp1JkDa65rBzPTDuOWCP5ZOTWZ9NCP+i/baIlbiRrJfgfuj8LkYS4r3 V4Us29WLhm8olEdxnP4jdDTR02WRHBoHhAWO51tqxElMl3kbK1aQoA9UZGvT3+F0YJ1eH4YFS0e NPALtxYb/AUM+0i6mrqR/merleDutqTL1rXQ56eo4+a5wNrcI1sf0AdjDGUGIubPAO8gsyROlTr JeJytXr X-Received: by 2002:a05:6808:1448:b0:459:b569:702f with SMTP id 5614622812f47-46410b94689mr3904867b6e.15.1771534158258; Thu, 19 Feb 2026 12:49:18 -0800 (PST) Received: from ?IPV6:2600:8803:e7e4:500:d4c1:bce:26a1:c903? ([2600:8803:e7e4:500:d4c1:bce:26a1:c903]) by smtp.gmail.com with ESMTPSA id 5614622812f47-463a4ede045sm13618351b6e.9.2026.02.19.12.49.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Feb 2026 12:49:17 -0800 (PST) Message-ID: <4b22e998-b38e-4452-82ce-1389d7086a04@baylibre.com> Date: Thu, 19 Feb 2026 14:49:16 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 05/18] clk: mediatek: Add MT8189 vlpckgen clock support To: "irving.ch.lin" , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Richard Cochran , Bartosz Golaszewski , Chen-Yu Tsai , Miles Chen Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com, Qiqi Wang , sirius.wang@mediatek.com, vince-wl.liu@mediatek.com, jh.hsu@mediatek.com References: <20260202062840.342707-1-irving-ch.lin@mediatek.com> <20260202062840.342707-6-irving-ch.lin@mediatek.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260202062840.342707-6-irving-ch.lin@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/2/26 12:28 AM, irving.ch.lin wrote: > From: Irving-CH Lin > > Add support for the MT8189 vlpckgen clock controller, which provides > muxes and dividers for clock selection in vlp domain for other IP blocks. > > Signed-off-by: Irving-CH Lin > --- ... > +static const struct mtk_gate vlp_ck_clks[] = { > + GATE_VLP_CK(CLK_VLP_CK_VADSYS_VLP_26M_EN, "vlp_vadsys_vlp_26m", "clk26m", 1), > + GATE_VLP_CK_FLAGS(CLK_VLP_CK_FMIPI_CSI_UP26M_CK_EN, "VLP_fmipi_csi_up26m", Should "VLP_fmipi_csi_up26m" be all lower-case to match the style of all of the other clock names? i.e. "vlp_fmipi_csi_up26m" > + "osc_d10", 11, CLK_IS_CRITICAL), > +}; > +